This repository's default branch is main, but every workflow was still keyed to
master, so none of them could ever run:
- build-and-test.yml triggered on push/PR to master, so CI never fired and the
README's build badge had no status to report.
- docker-publish.yml keyed off a successful build-and-test run on master, so it
never fired either. Only trigger filters and comments referenced the branch;
the tag-vs-branch logic was already branch-agnostic.
- make-release.yml actively refused to run, failing with "Regular releases can
only be created from the 'master' branch."
Also updated the branch names throughout docs/DEVELOPMENT_WORKFLOW.md to match.
Anything that describes or acts on *this* repository now points here. Attribution
to the upstream authors is deliberately left untouched.
Functional, would otherwise misbehave on this fork:
- Docker workflows pushed to a ghcr namespace this account cannot write to.
- scripts/run_jmusicbot.sh auto-updated from arif-banai's releases, so it would
have replaced this jar with the upstream one.
- pom.xml scm/issueManagement/ciManagement described the upstream repo.
- Removed .github/FUNDING.yml, which put a Sponsor button on this repo that
funded arif-banai.
Cosmetic:
- Badges repointed; dropped the CircleCI, CodeFactor and Discord badges, which
reported on services this fork is not registered with.
- License badge now targets main rather than master.
- Fixed the README header image: it was a float-right <img> that overlapped the
note block, now centred above the title with alt text.
- Refreshed the stale JMusicBot-0.6.2 jar name in the run examples.
Left alone on purpose: copyright headers, pom.xml <developers>, the NOTICE and
README credit tables, and the upstream commit provenance in docs/ARCHITECTURE.md.
Based on JMusicBot by jagrosh (https://github.com/jagrosh/MusicBot),
via the maintained fork by arif-banai (https://github.com/arif-banai/MusicBot).
See NOTICE for attribution. Licensed under Apache 2.0.
YouTube-side changes had broken playback entirely. Fixes:
- Apply the remote signature cipher independently of OAuth. Deciphering and
authentication are unrelated, but the cipher was only configured when OAuth
was enabled, so the default install fell back to the bundled extractor and
failed with "Must find sig function from script: /s/player/<id>/...".
Now always applied, and configurable via playback.youtube.remoteCipher.url.
- Add the ANDROID client and order the client list by reliability. ANDROID is
currently the only client YouTube reliably streams to anonymously. WEB moves
last, as YouTube answers it with SABR-only responses carrying no playable
format ("No supported audio streams available, available types:").
- Detect sign-in failures across the whole exception graph. The existing hint
could never fire: it matched the aggregate AllClientsFailedException message
rather than the per-client reasons, and compared against an ASCII apostrophe
while YouTube sends U+2019.
- Track youtube-source past 1.18.2, which predates the TV client User-Agent fix
and the contentLength recovery fix.
Measured on previously failing tracks: 5/5 playing, stable across repeat runs
(was 1/5). No OAuth required. Adds 17 tests; 676 unit + 48 integration pass.
purnell569