1cc040b535
* feat(ui-open-in-app): announce settled open outcomes app-wide
The shared file and directory opener reported a nullable failure, so it could
not tell a handoff the Host acknowledged from a gesture an adapter deliberately
dropped — a duplicate already in flight, or a controller disposed before the
gesture ran. Its notice also lived inside the control that asked for the open,
so it died with the panel, tab, or card the gesture started in.
Replace that with a discriminated outcome on both controllers and adapters, and
report each settled gesture into one `shell.overlay` entry that renders the
app-wide Toast: the Session-header command, the files-tab and Session-header
buttons, both document-preview controls, and both delivery-card controls.
`{ kind: 'skipped' }` announces nothing, because no handoff happened, so card
status and the toast never disagree about what settled.
Name the action for what it does on every surface — "Open on your computer" —
instead of after whichever application would take the handoff. The application
stays supplementary, in the tooltip beside the shortcut it runs under, which is
what the accessible name, visible text, and command label now share.
* fix(client): unify open-in-app feedback
* fix(client): report native open outcomes accurately
* fix(client): tighten open feedback outcomes and lifecycle tests
* test(ptc): synchronize hot-loop log capture
Observe a synchronous child marker before cancellation so the console retention assertion does not depend on completing Node startup within one second.
* test(bench): interleave scaling samples
* fix(client): scope native-open feedback to mobile
Explain native opens on another device for mobile and PWA clients while keeping desktop success silent. Preserve failure feedback after the initiating surface closes and ignore skipped requests.
Remove unrelated benchmark and PTC test changes and retain existing button labels.
Refs #6097
---------
Co-authored-by: EricMoin <[email protected]>
Co-authored-by: EricMoin <[email protected]>
apps/web browser e2e
English | 中文
These tests boot the real web composition in-process and drive it with real browsers over real HTTP. Chromium runs the full lane; the model and reasoning picker scenario also runs in WebKit to cover native mouse focus behavior. Session replay recovery also runs in WebKit, sharing the fresh-round-trip recording and expected output without rewriting them. It covers active-stream reload, completed-turn reload, and reopening a Session. The lane's mechanics — modes, fixtures, goldens, and the deliberate composition divergences from dsh web — are documented in scaffold.ts and the browser e2e Agent Note.
After installing workspace dependencies, install the browsers and their system dependencies from the repository root:
pnpm --filter @deepseek-ai/dsh-web-frontend exec playwright install --with-deps chromium webkit
On Linux, --with-deps installs dependencies through the system package manager. The persistent CI VM must provide these dependencies through image maintenance; CI installs only the browser binaries, as required by the failover runbook.
Ordinary scenarios begin with no registered Workspace or Session and a durable marker recording a removed default Workspace, so explicit folder-selection scenarios retain control of their cwd. launchWebScaffold({ firstUse: true }) leaves initialization eligible for startup scenarios.
Same-day message goldens use the shared WEB_FIXTURE_TIME: seeded transcripts pass it as createdAt and pin the browser calendar with pinBrowserClock; scenarios that submit live messages also use pinHostClock and restore it after teardown. These clocks advance with real elapsed time while keeping native timers intact, so midnight does not change a scenario's date labels.
Completion observations
State-sensitive cases use Workspace, admission, attachment, and model-stream barriers to separate visible intermediate states from completed operations. Model-picker persistence assertions wait for the saved default, independently of menu closure. Details close waits for frame transitions; archive verification assigns an explicit title to the seeded Session and follows that identity across reload. The CI test reliability workflow owns these synchronization rules.
Idle-submission handoff waits up to the scaffold's 30-second turn-completion budget for Host frames and browser placement. Vitest owns scaffold teardown so a replay-consumption error does not replace the failed scenario assertion.
Plugin-manager and HMR lifecycle switches wait up to PLUGIN_TOGGLE_SETTLE_MS (10 seconds) for the Host's profile write and the store's follow-up inventory read, the two steps that republish aria-checked; that constant's JSDoc records the measured chain.
Explicit scrolling uses scrollIntoView from support.ts: it resolves the locator again when its old element detaches and checks connection in the same browser task as native scrolling. Scenarios retain their visibility and geometry assertions after scrolling.
Question-composer resize assertions wait for overflow, the clipping mask, and toggle visibility to agree after CSS scroll timelines update.
The snapshot after closing a sidebar pane moves the pointer outside the controls and waits for hover tooltips to close before capture. Keyboard focus remains on the pane.
The same-origin terminal case waits for the UI-triggered Host close operation before checking process termination. It also checks the first window's process, saved bindings and layout after reload.
These are Host-face tests
They type-check in the root tsconfig.host.json, not in the Client aggregate, because they read Host services directly: ctx.connection, the Host SessionStore, and ctx.sessionProjectionCache. Driving a browser at runtime does not make a file part of the Client program — the two faces merge Cordis Context under the same keys with different services, so one program cannot see both. Moving these files into the Client aggregate makes every Host-service access fail to compile.
A new scenario joins both program lists in the same change: its file in the root tsconfig.host.json include and in the Client aggregate's apps/web/tsconfig.json exclude. That project includes all of tests, so a file missing from the exclude compiles as Client code, and the Client compiler gate of pnpm run typecheck keeps failing with Host-service errors until it is listed.
Do not import @deepseek-ai/dsh-client-* here
Importing a Client package — a value or a type — pulls its TypeScript project and referenced projects into the Host build graph. Generated Remote declarations are available before package compilation, but this does not make the Host and Client Cordis Context declarations compatible. Keep these tests on the Host face and use only the explicit built-client harness exception below.
When a scenario needs a Client-owned constant or pure function, mirror it here instead, next to the commented-out import that names the source module. A drift then surfaces as a missed selector or a stale mirrored value — a loud failure, never a silent pass. scaffold.ts follows this rule for the welcome-notice namespace, acknowledgement field, version, and asserted Chinese copy.
The built-client harness is the exception. assembled-boot.ts imports AppWebEntry, the boot-manifest type, and RemoteMock; assembled-remote.ts imports the Client test runtime's default responses and RemoteMock. These packages are explicit project references for booting the real shell against a test-owned carrier. The chat scenarios mirror conversationContextKey in support.ts instead of importing its Client owner.
Nothing mechanically enforces this rule; keep it in review.