Commit Graph
2194 Commits
Author SHA1 Message Date
Yichen Jiang 28df6c3117 Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes
# Conflicts:
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/README.md
#	packages/experimental/forge-github/README.zh.md
#	packages/experimental/forge/README.i18n.yaml
#	packages/experimental/forge/src/index.ts
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-09 14:53:18 +08:00
Yichen Jiang 2479e6ddab Merge remote-tracking branch 'origin/master' into feat/forge-review-threads
# Conflicts:
#	docs/event-producer-consumer.md
#	docs/event-producer-consumer.zh.md
2026-11-09 14:43:20 +08:00
Yichen Jiang dacbc37209 Merge remote-tracking branch 'origin/master' into feat/forge-review-threads
# Conflicts:
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/README.md
#	packages/experimental/client-ui-forge/README.zh.md
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/client-ui-forge/src/client/DiffFile.tsx
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/README.md
#	packages/experimental/forge-github/README.zh.md
#	packages/experimental/forge/README.i18n.yaml
#	packages/experimental/forge/src/index.ts
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-09 14:28:39 +08:00
Yichen Jiang 6e882cd6e3 fix(forge): confine review writes to the bound pull request and reconcile unknown submissions
A write to a thread or comment now reads, in the head check, the pull
request that holds it and is refused without a mutation when that is
another pull request. Submitting the pending review keeps the
submission to reconcile, so an unknown outcome blocks a second review.
GraphQL errors count as refusals only when every type names one, so a
GitHub timeout reports an unknown outcome. Pending reviews are found
by viewerDidAuthor among up to 100, without the unused commit field. A
resolved thread stays open while the reader writes in it, unsupported
writes no longer poll, and the docs state the partial two-step write.
2026-11-09 14:08:22 +08:00
Jiawei Song b43fcce60e Merge pull request #8006 from deepseek-harness/refactor/tool-errors-fs
feat(fs,lsp,present): give file, search, LSP, and present tool failures error codes
2026-11-09 13:59:49 +08:00
Jiawei Song 74ae5f0da9 Merge pull request #8053 from deepseek-harness/refactor/tool-errors-shell
feat(shell,sandbox,jobs,terminal): give shell, sandbox, job, and terminal tool failures error codes
2026-11-09 13:56:40 +08:00
Yichen Jiang 9f875cf44d Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	docs/subsystems/forge.i18n.yaml
#	docs/subsystems/forge.md
#	docs/subsystems/forge.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/README.md
#	packages/experimental/client-ui-forge/README.zh.md
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/client-ui-forge/src/client/mount.ts
#	packages/experimental/client-ui-forge/src/client/thread-state.ts
#	packages/experimental/client-ui-forge/src/index.ts
#	packages/experimental/client-ui-forge/tests/changes-tab.client.spec.tsx
#	packages/experimental/client-ui-forge/tests/mount.client.spec.ts
#	packages/experimental/client-ui-forge/tests/review-cache.host.spec.ts
#	packages/experimental/client-ui-forge/tests/review.host.spec.ts
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/src/threads.ts
#	packages/experimental/forge-github/tests/threads.spec.ts
#	packages/experimental/forge/src/types.ts
#	packages/experimental/forge/tests/registry.spec.ts
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-09 13:03:22 +08:00
Yichen Jiang 1ba5977691 fix(forge-panel): address the review thread findings
- A jump to a thread centered its card on every later jump to the same file, since the jump target outlived the jump.
  The scroll target now carries the card to center and is cleared when the jump ends; unfolding still follows the
  latest thread jump.
- In a commit range view, a thread on a file the chosen commits do not change opened on the host instead of choosing
  all commits; a thread the chosen commits do not hold now always chooses all commits first.
- A quote of an old-side thread named the head as the commit its lines number. It now says the lines number the file
  before the change and names the head only as where the diff ends, and ForgeAnchor documents the same.
- Refresh reads review threads from the host past the panel's cache (`changeRequestReview` takes `fresh`), so a thread
  resolved since shows without waiting for `reviewRefreshMs`; `maxCachedReviewBytes` defaults to 16 MiB, at least
  one read under forge-github's default `maxOutputBytes`.
- Picking a thread from a list that covers the files moves the focus to the thread's card.
- `ForgeReviewData.viewer`, its GraphQL field, `ThreadActions.viewer`, and `ThreadReadState.unsupported` had no
  consumer and are removed.
- A quoted outdated thread is named by the lines it was written on; a missing pull request or repository makes a
  review read `not-found`; a truncated read that kept no thread still offers the thread list.
2026-11-09 12:50:33 +08:00
Yichen Jiang f03981630c Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	packages/experimental/client-ui-forge/README.i18n.yaml
2026-11-09 11:50:38 +08:00
Yichen Jiang ce1e1f2681 Merge remote-tracking branch 'origin/master' into perf/forge-changes-view 2026-11-09 11:47:49 +08:00
Yichen Jiang c04c40b68a docs(forge): document review writes and record pending review drafts
The forge subsystem page documents ctx.forge.writeReview, its write
and result types, and the panel's changeRequestReviewWrite; the package
READMEs describe the GitHub mutations and their measured behavior, the
thread actions, and the pending review flow. A new Agent Note records
moving pull request comment drafts to the code host's pending review,
and the forge panel note links it. The Web e2e replies to, edits,
deletes, and resolves threads, and starts, submits, and discards a
pending review through the scripted gh double.
2026-11-09 11:38:56 +08:00
Yichen Jiang e7e5ed638d Merge remote-tracking branch 'origin/master' into feat/forge-review-threads
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/src/client/DiffFile.tsx
#	scripts/type-equiv.manifest.json
2026-11-09 11:38:53 +08:00
Kexin Liu 6a20990684 Merge pull request #7933 from deepseek-harness/feat/session-append-events
feat(session): accept multiple events through append
2026-11-08 21:52:12 +08:00
Kexin Liu 2c37d513ed Merge pull request #8085 from deepseek-harness/agent/answer-concurrent-tools-2-fda34beac313
feat(tools): declare read-only tools concurrency-safe
2026-11-08 17:13:38 +08:00
liukx0205 7f6b7ba4b6 refactor(session): narrow batch publication metadata and validation 2026-11-07 17:02:19 +08:00
liukx0205 1e7f265cfd fix(session): complete batch API review coverage and declarations 2026-11-07 17:02:19 +08:00
liukx0205 143fabbc34 fix(session): share live append validation and expose batch publication 2026-11-07 17:02:19 +08:00
liukx0205 9d18b68095 fix(session): assign batch sequences after payload snapshots 2026-11-07 17:02:19 +08:00
liukx0205 b3d570cdf8 feat(session): accept positional event tuples for batch append 2026-11-07 17:02:19 +08:00
liukx0205 748c53b865 feat(session): accept single event objects through append 2026-11-07 17:02:19 +08:00
liukx0205 b5969f9e8d feat(session): accept multiple events through append 2026-11-07 17:02:19 +08:00
Kexin Liu e49a941d65 Merge pull request #7910 from deepseek-harness/fix/agent-input-lifecycle
fix(agent): drain work after cancellation failures
2026-11-07 17:02:15 +08:00
Yichen Jiang 9b456b4e93 perf(forge): compare from the recorded base while confirming the head
Status snapshots carry the base commit the host recorded with the head
(baseSha). ForgeService.diff passes it to the provider when the latest
status names the requested head, and forge-github starts the compare read
from it while its GraphQL read confirms the head; a stale head or another
base cancels and joins the early read.
2026-11-07 16:22:24 +08:00
Yichen Jiang f11daf3ad3 docs(forge): document review thread reads, the thread overlay, and the unsupported failure
The forge subsystem page documents ctx.forge.readReview, its thread
types, and the panel's changeRequestReview cache; the package READMEs
describe the GitHub thread mapping, the overlay and thread list, and the
new panel Config fields. An upgrade guide covers the unsupported
ForgeFailure code. The Web e2e overlays scripted threads, opens them from
the thread list, and sends a quoted thread through a replayed turn.
2026-11-07 14:31:30 +08:00
Yichen Jiang ef34a844de fix(forge-panel): refuse commit runs off the first-parent line and harden review state
- Shift-chosen commits must follow each other as first parents; the picker
  says why it keeps a run that leaves the line, and the Host refuses one with
  forgePanel/commits-not-linear for the Branch scope and change requests.
- The Branch scope lists its newest maxCommits commits with
  --no-show-signature, so log.showSignature cannot corrupt the listing.
- Viewed marks merge with the stored entry on each write and follow the
  storage event, so tabs of one Session keep each other's marks.
- .gitattributes patterns follow Git's wildmatch rules, checked against
  git check-attr; change digests include file mode lines.
- GitHub commit pagination refuses a repeated cursor or a changed count;
  commits validates the repository before its host like the other reads.
- The commit list is read once per head, base, or refresh; the lens menu
  hides the count of the disabled Tests lens.
2026-11-07 12:56:23 +08:00
Yichen Jiang fb637c2bfd Merge remote-tracking branch 'origin/master' into feat/forge-review-viewed-lenses
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	docs/subsystems/forge.i18n.yaml
#	docs/subsystems/forge.md
#	docs/subsystems/forge.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/README.md
#	packages/experimental/client-ui-forge/README.zh.md
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/client-ui-forge/src/index.ts
#	packages/experimental/client-ui-forge/tests/controller.host.spec.ts
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/README.md
#	packages/experimental/forge-github/README.zh.md
#	packages/experimental/forge-github/src/index.ts
#	packages/experimental/forge-github/src/provider.ts
#	packages/experimental/forge-github/tests/plugin.spec.ts
#	packages/experimental/forge-github/tests/provider.spec.ts
#	packages/experimental/forge-github/tests/review.spec.ts
#	packages/experimental/forge/README.i18n.yaml
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-07 12:13:56 +08:00
Yichen Jiang 0a10b6fd16 Merge pull request #8049 from deepseek-harness/fix/forge-pinned-diff
fix(forge): pin change request diffs to the polled head and count every review thread
2026-11-07 11:22:43 +08:00
Yudong Han 2d463af8d2 Merge pull request #7365 from deepseek-harness/feat/sidebar-file-search
feat(ui-sidebar-files): 侧栏文件树新增搜索栏 UI 与排除规则设置
2026-11-07 00:56:13 +08:00
edd2eee9e9 docs(tools): document parallel read-only tool contracts
Record the MCP resource provider concurrency requirement, the
working-directory recovery notice, and why lsp, goal, job_output and
job_kill stay exclusive; fix unbound-method lint in declaration tests.

Refs #8084

Co-authored-by: liukx0205 <[email protected]>
Co-authored-by: LegGasai <[email protected]>
2026-11-06 21:22:09 +08:00
liukx0205 0e5c4765e6 refactor(agent): isolate cancellation and quiescent teardown 2026-11-06 19:20:28 +08:00
liukx0205 9fc22ad970 fix(commands): report saved permission and plan changes during shutdown 2026-11-06 18:57:52 +08:00
Yichen Jiang 0e971200c4 feat(forge-panel): let repositories declare review layers in .gitattributes
A repository's root .gitattributes now decides a file's review layer first:
dsh-review-layer names test, interface, or implementation, and
linguist-generated still places a file in the test layer. The testPaths and
interfacePaths settings add globs before the built-in rules and are empty by
default. The built-in rules follow the default conventions of common
languages and tools instead of treating every JSON or YAML file and every
name containing config as interface. This repository declares its own locale
dictionaries, snapshot tree, pairing records, and types modules.
2026-11-06 18:47:22 +08:00
Yichen Jiang e07b170d77 fix(forge): address review of pinned diffs and thread counting
- forge-github: repeat a compare read without --allow-escape-sequences when
  a gh older than 2.97 rejects the option; such a gh prints escape sequences
  unchanged, so every version reads every diff (checked with gh 2.96.0 and
  2.100.0 on a pull request whose patch holds an ESC byte).
- client-ui-forge: a stale refusal now re-runs the read effect, so a status
  that arrived during the read, including a failed poll that keeps the
  earlier head, starts the next read at once instead of leaving the changes
  view loading.
- forge: ctx.forge.diff polls at once only for the first stale read at a head
  commit; later stale reads at it wait for the regular poll, which bounds the
  read-poll loop while GitHub's answers briefly disagree.
- forge-github: review thread pages share the byte budget of a complete
  check read.
- client-ui-forge: a truncated count shows its "+" even when it is zero.
- READMEs: document the batch deadline and rewritten-base limitations.
2026-11-06 18:17:04 +08:00
liukx0205 5a2cb1d4af fix(goal): keep shutdown handling local to attachment submission 2026-11-06 18:13:28 +08:00
Yichen Jiang 325b2d27e5 Merge remote-tracking branch 'origin/master' into feat/forge-review-viewed-lenses 2026-11-06 17:51:39 +08:00
Yichen Jiang c313392bf8 feat(forge-panel): review changes by layer, mark files viewed, and view chosen commits
The changes view gains a lens of All, Interface, Implementation, and Tests
that spans the file tree above it, a switch that hides test files from the
tree and the diff, and a viewed checkbox on each file header that collapses
the file. The toolbar counts viewed files and V toggles the file being read.
Marks are kept per Session, source, path, and change digest in browser
storage, so a file that changes again reads as changed since viewed. All
commits beside Submit review, and beside the base branch of the Branch scope,
shows one commit or a Shift run of commits.
2026-11-06 17:51:22 +08:00
liukx0205 d67e146e73 fix(goal): report saved objectives when attachment admission closes 2026-11-06 17:43:31 +08:00
lsdsjy d51d623bfc feat(account): 接入通用通知接口并统一账号服务 (#7550)
将赠金专用提示迁移到通用通知 list、content 和 events 接口,支持轮询、语言刷新及单次交互上报。

统一账号服务和 Remote,通知 UI 放入侧栏并保持独立生命周期。

Refs #6373
2026-11-06 17:40:24 +08:00
Yichen Jiang f489bcc9ed Merge branch 'master' into fix/forge-pinned-diff 2026-11-06 17:23:35 +08:00
Magolor 2f9d5d083c Show server-masked credential previews by Unicode code point 2026-11-06 16:59:29 +08:00
Magolor ef3a02167a fix(settings): preserve saved API key mask length 2026-11-06 16:59:27 +08:00
Magolor 86247d664b fix(settings): protect saved keys and preserve clear failure state 2026-11-06 16:58:59 +08:00
Magolor 334a76ef88 fix(settings): show masked saved keys and restore environment auth 2026-11-06 16:58:49 +08:00
sjw1231 fe2effea1f feat(terminal): give TerminalBackendCleanupError the CLEANUP_FAILED code
TerminalBackendCleanupError extended AggregateError, so a backend that
failed startup and then failed to clean its partial resources reached
tool/result with a name but no error.name/error.code. It now extends
TerminalError with code CLEANUP_FAILED, keeps spawnError, cleanupError,
and the errors list, and sets the setup failure as cause. TerminalError
and the cleanup error move to src/error.ts so src/types.ts stays
type-only; TerminalError's constructor accepts ErrorOptions.

Refs #7869
2026-11-06 16:39:37 +08:00
sjw1231 c92eded7e4 docs: regenerate catalogs for the shell, sandbox, and working-directory errors
Regenerated Cordis, config, and persistence catalogs pick up the new
WorkingDirectoryError and SandboxPreparationError exports and the
shifted source lines; persisted type digests are unchanged.

Refs #7869
2026-11-06 16:39:36 +08:00
sjw1231 9626ccfae8 feat(sandbox): code escalation outcomes and Windows ACL preparation failures
The sandbox Service Definition adds SandboxEscalationError with
SANDBOX_ESCALATION_INVALID_ARGUMENT, _UNAVAILABLE, _REJECTED, and
_CANCELLED, thrown by validateEscalationArgs() and approveEscalation()
with their existing messages. A cancelled approval for an aborted call
rethrows the call's cancellation instead.

It also adds SandboxPreparationError. sandbox-local wraps Windows ACL
SID, grant, temp-directory, and path-resolution failures as
SANDBOX_PREPARATION_FAILED with the Win32Error or Node error (or an
AggregateError with cleanup failures) as cause, and reports a temp root
inside the workspace as SANDBOX_INVALID_TEMP_ROOT. sandbox-windows-acl
exports isTempRootInsideWorkspace() for that check.

Refs #7869
2026-11-06 16:39:36 +08:00
sjw1231 e80eb062a1 fix(lsp): derive query capabilities from the handshake result
The instance's ready promise now resolves to the negotiated server
capabilities, so a query can no longer observe an instance without
them; LSP_NOT_INITIALIZED and its private-state test are removed.

The LSP failures page qualifies the teardown combination (uncoded query
failures surface as AggregateError without error.info) and the stderr
tail of LSP_SERVER_EXITED, and LspQueryTeardownError documents that it
does not keep the query failure's class.
2026-11-06 16:19:12 +08:00
Yichen Jiang 94336c6b3d fix(forge): pin change request diffs to the polled head and count every review thread
ForgeProvider.diff now takes the head commit it must describe. The GitHub
provider reads headRefOid before and after `gh pr diff` and returns the new
ForgeFailure code `stale` when either read names another commit, so the
forge panel never caches a patch under a head it does not describe. A stale
read polls the change request at once, and the changes view waits for the
next status before reading again.

Status polling pages reviewThreads up to the new `maxReviewThreads` setting
(default 1,000) instead of counting only the first 100, and sets
ChangeRequestSnapshot.threadsTruncated when the count is a lower bound.
2026-11-06 16:15:24 +08:00
sjw1231 360216b089 feat(lsp): give lsp tool failures structured error codes
tool-lsp argument checks throw ToolArgsError. lsp-stdio keeps FsError
codes from resolution and reads (adding the LSP operand to the message),
reports a missing or non-directory workspace and an oversized source as
FsError, and adds LspError codes for the stdio provider:
LSP_FILE_OUTSIDE_WORKSPACE, LSP_UNSUPPORTED_ENCODING, LSP_SPAWN_FAILED,
LSP_SERVER_EXITED, LSP_PROTOCOL_ERROR, LSP_MESSAGE_TOO_LARGE, and
LSP_SERVER_ERROR (JSON-RPC code and text in the message), and
LSP_NOT_INITIALIZED for a query that finds no negotiated capabilities
after a successful handshake. A query
failure whose teardown also fails keeps the query's name and code.
LspError assigns its literal name; the LSP subsystem page documents
every code.
2026-11-06 15:10:36 +08:00
liukx0205 4f10a9ef08 Merge commit '2ac25a5cedf1485be192b6eb99977b0baa8d7522' into HEAD 2026-11-06 14:52:34 +08:00