Commit Graph
26553 Commits
Author SHA1 Message Date
Yichen Jiang 3e299a491d Merge pull request #8179 from deepseek-harness/fix/forge-narrow-toolbar-comments
fix(forge): fold the changes toolbar and keep comments in their own column
2026-11-09 17:36:49 +08:00
CreatixChu 5a18be1c9a Merge pull request #8164 from deepseek-harness/feat/cua-ax-traversal-limits
feat(cua): 支持按次设置 AX 树的节点数和深度上限
2026-11-09 16:40:21 +08:00
creatixchu 1fb39a2283 test(cua): inspect the typed prompt section directly 2026-11-09 16:13:35 +08:00
creatixchu 9f5f2f5ae4 test(cua): verify scoped provider guidance independently of read defaults 2026-11-09 16:09:18 +08:00
Chinesezjc e9eeabacb6 Merge pull request #8046 from deepseek-harness/fix/ci-21078ac-scan-dot-dirs
test(ui-theme): skip dot directories in the package scan
2026-11-09 15:50:12 +08:00
Yichen Jiang 4d01598a26 Merge remote-tracking branch 'origin/master' into fix/forge-narrow-toolbar-comments
# Conflicts:
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/README.md
#	packages/experimental/client-ui-forge/README.zh.md
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/client-ui-forge/src/client/DiffFile.tsx
#	packages/experimental/client-ui-forge/src/client/ReviewThread.tsx
2026-11-09 15:48:26 +08:00
Yichen Jiang eba697f3d4 fix(forge): fold the changes toolbar and keep comments in their own column
A narrow changes toolbar wrapped its controls onto a second row and the
header's buttons broke their labels across two lines. Side by side, a
right-side comment was placed with clamp(10px, 100% - 700px, 50% + 10px),
so below about 1,420 px it crossed into the left column, and only one
comment editor could be open at a time.

The toolbar now keeps one line. observeToolbarFold measures what each
fold level needs and sets data-fold to the shallowest level that fits:
level 1 moves the line totals, expanding all files, two columns, and
wrapping into a More view options menu, level 2 the test file switch,
with the viewed progress shown as a ring and a count, and level 3
refresh; at level 3 the file list entry shortens its label. The menu
lists the controls of the level shown when it opens. Measuring instead of
fixed widths keeps every locale on one line: the full toolbar needs about
650 px in Chinese and nearly 800 px in Russian. Header buttons keep their
labels on one line.

Side by side, the comments that end on a row now sit in a row of two
cells under its columns, each continuing its line's gutter and
background, so a left and a right comment share the row. Any number of
editors can stay open; choosing an open editor's range focuses it.

Resolves #8176
2026-11-09 15:27:21 +08:00
Yichen Jiang 3e73384e25 Merge pull request #8156 from deepseek-harness/feat/forge-review-writes
feat(forge): reply to and resolve review threads, and keep pull request drafts in the GitHub pending review
2026-11-09 07:26:19 +00:00
Yichen Jiang c27eeb8eac fix(forge-panel): rebind the scrollbar on the review dialog's confirmation box 2026-11-09 15:15:09 +08:00
Yichen Jiang c49ffe9808 Merge pull request #8112 from deepseek-harness/feat/forge-review-threads
feat(forge): overlay GitHub review threads on the changes view
2026-11-09 15:05:48 +08:00
Yichen Jiang 7bbc407c99 test(forge-panel): spy on the memoized DiffFile's render in the pending review callback case 2026-11-09 15:01:34 +08:00
Yichen Jiang 28df6c3117 Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes
# Conflicts:
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/README.md
#	packages/experimental/forge-github/README.zh.md
#	packages/experimental/forge/README.i18n.yaml
#	packages/experimental/forge/src/index.ts
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-09 14:53:18 +08:00
Yichen Jiang 2479e6ddab Merge remote-tracking branch 'origin/master' into feat/forge-review-threads
# Conflicts:
#	docs/event-producer-consumer.md
#	docs/event-producer-consumer.zh.md
2026-11-09 14:43:20 +08:00
dsh-ci-bot b840ff5b9f fix(ci): brace the retry cleanup hook
`typescript/no-confusing-void-expression` rejects the shorthand arrow that
returns `rmSync`'s void expression; the staged lint configuration does not
enable type-aware rules, so only the full lint gate caught it.
2026-11-09 14:34:35 +08:00
Yichen Jiang dacbc37209 Merge remote-tracking branch 'origin/master' into feat/forge-review-threads
# Conflicts:
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/README.md
#	packages/experimental/client-ui-forge/README.zh.md
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/client-ui-forge/src/client/DiffFile.tsx
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/README.md
#	packages/experimental/forge-github/README.zh.md
#	packages/experimental/forge/README.i18n.yaml
#	packages/experimental/forge/src/index.ts
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-09 14:28:39 +08:00
creatixchu aeb278ce98 test(cua): replay recovery from truncated AX observations 2026-11-09 14:24:58 +08:00
creatixchu 9425b6defe fix(cua): report configured AX budgets and document migration 2026-11-09 14:23:46 +08:00
dsh-ci-bot 37ee8d34ad fix(ci): retry the Electron provisioning fetch
The Windows coverage lane provisions the locked Electron binary through the
runner proxy. A gateway timeout on that one fetch failed the required lane
before any test ran: on 2026-11-09 four jobs on three branches stopped at
`504 (Gateway Time-out)` for the release archive, while other jobs fetched the
same archive minutes later (2.5 s from a warm cache, 14.7 s cold).

`electron-install` now declares two retries with a 15 s wait, and the
aggregate executor repeats a failed gate only when it declares `retries`. A
gate the fail-fast signal terminated is not repeated, and the returned
duration covers every attempt.
2026-11-09 14:18:13 +08:00
creatixchu 1bd41d063e docs(cua): record why AX configuration sets per-read defaults 2026-11-09 14:17:42 +08:00
creatixchu dfc8671279 test(cua): refresh portable AX option and macOS guidance snapshots 2026-11-09 14:14:21 +08:00
creatixchu 9bd4a9aad7 test(cua-macos): exercise traversal budgets on the AppKit fixture 2026-11-09 14:13:11 +08:00
creatixchu 6b3ed06115 feat(cua-macos): raise AX traversal ceilings and document them per platform 2026-11-09 14:12:43 +08:00
Yichen Jiang 6e882cd6e3 fix(forge): confine review writes to the bound pull request and reconcile unknown submissions
A write to a thread or comment now reads, in the head check, the pull
request that holds it and is refused without a mutation when that is
another pull request. Submitting the pending review keeps the
submission to reconcile, so an unknown outcome blocks a second review.
GraphQL errors count as refusals only when every type names one, so a
GitHub timeout reports an unknown outcome. Pending reviews are found
by viewerDidAuthor among up to 100, without the unused commit field. A
resolved thread stays open while the reader writes in it, unsupported
writes no longer poll, and the docs state the partial two-step write.
2026-11-09 14:08:22 +08:00
creatixchu 47254be6f7 test(cua): capture typed traversal limits in model guidance and tool schemas 2026-11-09 14:02:28 +08:00
creatixchu 91f9d14fa8 feat(cua): bound accessibility tree reads with typed traversal options 2026-11-09 14:00:21 +08:00
Yichen Jiang e29a8f57c5 Merge pull request #8157 from deepseek-harness/fix/app-boot-home-env-deepseek-endpoints
fix(app-boot): accept DeepSeek endpoints from the Harness-home .env
2026-11-09 14:00:02 +08:00
Jiawei Song b43fcce60e Merge pull request #8006 from deepseek-harness/refactor/tool-errors-fs
feat(fs,lsp,present): give file, search, LSP, and present tool failures error codes
2026-11-09 13:59:49 +08:00
Jiawei Song 74ae5f0da9 Merge pull request #8053 from deepseek-harness/refactor/tool-errors-shell
feat(shell,sandbox,jobs,terminal): give shell, sandbox, job, and terminal tool failures error codes
2026-11-09 13:56:40 +08:00
Chinesezjc a6fc2ac61b Merge branch 'master' into fix/ci-21078ac-scan-dot-dirs 2026-11-09 13:54:30 +08:00
CreatixChu e5359d9a49 Merge pull request #8107 from deepseek-harness/feat/session-mouse-consent
feat(cua): 按会话授权 macOS 悬停移动系统鼠标
2026-11-09 13:51:42 +08:00
dsh-ci-bot dbf13cd572 test(ui-theme): name the dot-directory exclusion and cover a nested manifest
packageFiles() now states the dot-directory exclusion in its JSDoc, and the
inline comment no longer names one concrete temporary-root prefix. The spec
title describes what the case checks, and the case also asserts a manifest one
level below the root so an implementation that only scans the root fails.
2026-11-09 13:42:26 +08:00
Yichen Jiang 544fdb0b9c Merge pull request #8126 from deepseek-harness/perf/forge-changes-view
perf(forge): keep the changes view responsive on large diffs
2026-11-09 13:34:23 +08:00
Yichen Jiang 9b6e551054 fix(app-boot): accept DeepSeek endpoints from the home .env only as spelled
The Harness-home exemption matched every name case-insensitively, so a
home `.env` line such as `deepseek_base_url=...` passed the check and
landed in `process.env` under that spelling. The launch snapshot looks
names up exactly on POSIX, so llm-deepseek, web-search-deepseek, and
web-deepseek-api never saw it: the launch succeeded with the official
endpoint, where it used to fail. Proxy names keep matching in any letter
case because proxy clients read both spellings; the two endpoint names
now match only as `DEEPSEEK_BASE_URL` and `DEEPSEEK_SEARCH_BASE_URL`, and
another spelling fails the launch with the exact name to use.

The home-layer refusal case now covers `SSL_CERT_FILE`,
`NODE_TLS_REJECT_UNAUTHORIZED`, and `DSH_HOME`. The web-deepseek-api
README states where `DEEPSEEK_BASE_URL` may come from; the
launch-environment README, the development guide, and the configuration
source Agent Note no longer overstate which file is refused, which
Vitest configurations load the root `.env`, or what a checkout may carry.

Refs #8138
2026-11-09 13:15:10 +08:00
Yichen Jiang cd6792a38c Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes 2026-11-09 13:11:40 +08:00
Yichen Jiang 29541194cc fix(forge-panel): keep thread avatars round and rebind the scrollbar on resolved cards
The repository's stylesheet gates require a full-round radius to pair `corner-shape: round`, so the avatar and its
image stay circles where corners are smoothed, and a scrolling surface on an elevated background to rebind the
scrollbar thumb to the l2 pair. A resolved thread card paints `--dsw-alias-bg-layer-2` and holds the hunk excerpt and
the file at that commit, which scroll, so it now sets `--dsh-scrollbar-thumb` and `--dsh-scrollbar-thumb-hover`.
2026-11-09 13:10:00 +08:00
Yichen Jiang 9f875cf44d Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	docs/config-catalog.md
#	docs/config-catalog.zh.md
#	docs/subsystems/forge.i18n.yaml
#	docs/subsystems/forge.md
#	docs/subsystems/forge.zh.md
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/README.md
#	packages/experimental/client-ui-forge/README.zh.md
#	packages/experimental/client-ui-forge/src/client/ChangesTab.tsx
#	packages/experimental/client-ui-forge/src/client/mount.ts
#	packages/experimental/client-ui-forge/src/client/thread-state.ts
#	packages/experimental/client-ui-forge/src/index.ts
#	packages/experimental/client-ui-forge/tests/changes-tab.client.spec.tsx
#	packages/experimental/client-ui-forge/tests/mount.client.spec.ts
#	packages/experimental/client-ui-forge/tests/review-cache.host.spec.ts
#	packages/experimental/client-ui-forge/tests/review.host.spec.ts
#	packages/experimental/forge-github/README.i18n.yaml
#	packages/experimental/forge-github/src/threads.ts
#	packages/experimental/forge-github/tests/threads.spec.ts
#	packages/experimental/forge/src/types.ts
#	packages/experimental/forge/tests/registry.spec.ts
#	packages/extensions/tool-cordis/src/api-catalog.ts
2026-11-09 13:03:22 +08:00
Yichen Jiang 1ba5977691 fix(forge-panel): address the review thread findings
- A jump to a thread centered its card on every later jump to the same file, since the jump target outlived the jump.
  The scroll target now carries the card to center and is cleared when the jump ends; unfolding still follows the
  latest thread jump.
- In a commit range view, a thread on a file the chosen commits do not change opened on the host instead of choosing
  all commits; a thread the chosen commits do not hold now always chooses all commits first.
- A quote of an old-side thread named the head as the commit its lines number. It now says the lines number the file
  before the change and names the head only as where the diff ends, and ForgeAnchor documents the same.
- Refresh reads review threads from the host past the panel's cache (`changeRequestReview` takes `fresh`), so a thread
  resolved since shows without waiting for `reviewRefreshMs`; `maxCachedReviewBytes` defaults to 16 MiB, at least
  one read under forge-github's default `maxOutputBytes`.
- Picking a thread from a list that covers the files moves the focus to the thread's card.
- `ForgeReviewData.viewer`, its GraphQL field, `ThreadActions.viewer`, and `ThreadReadState.unsupported` had no
  consumer and are removed.
- A quoted outdated thread is named by the lines it was written on; a missing pull request or repository makes a
  review read `not-found`; a truncated read that kept no thread still offers the thread list.
2026-11-09 12:50:33 +08:00
Yichen Jiang 2284e3e714 fix(app-boot): accept DeepSeek endpoints from the Harness-home .env
`loadLayeredEnv` refused `DEEPSEEK_BASE_URL` and
`DEEPSEEK_SEARCH_BASE_URL` from every discovered `.env`, including the
user's own `$DSH_HOME/.env`, so a machine-level endpoint written there
made both the CLI and Desktop fail at startup.

The refusal exists for the invoking directory's file: it arrives with a
clone, and a repository must not choose where requests carrying the
user's DeepSeek credential go. The home file is the user's own, and the
profile patches in the same directory can already set these endpoints as
plugin `baseURL` fields, so refusing it there protected nothing.
`HOME_LAYER_PROXY_NAMES` becomes `HOME_LAYER_ROUTE_NAMES` and adds the
two endpoint names; a project `.env` that sets either still fails the
launch, and its message now names the home file as the second way out.
`DSH_HOME` stays bootstrap-only, and the CA and TLS names stay refused
everywhere.

Tests cover the project layer refusing both names, the home layer
accepting both below an exported value, and the project-layer message.
The app-boot, launch-environment, llm-deepseek, and web-search-deepseek
READMEs, the development guide, and the two Agent Notes that stated the
old rule now state this one.

Refs #8138
2026-11-09 12:33:59 +08:00
Yichen Jiang 1a6268ed52 Merge pull request #8152 from deepseek-harness/fix/worktree-archive-cleanup
fix(worktree): reclaim archived checkouts in large repositories
2026-11-09 12:31:05 +08:00
Yichen Jiang 088cd5dfba test(forge-panel): read the end position after scroll anchoring settles 2026-11-09 12:20:08 +08:00
Yichen Jiang 2d44c4ecc9 fix(forge-panel): let scroll anchoring keep a jumped-to file in place
The per-frame alignment after a jump pulled back scrolls it did not start,
such as a script or find in page setting the scroll position. Measured on
#7985, the browser's scroll anchoring already keeps an early, middle, or
late jump target at the top while the sections above it draw.
2026-11-09 12:07:17 +08:00
Yichen Jiang fcc33725d9 fix(worktree): keep an early streamed answer and document cleanup limits
- Return the early answer from scanCommand without awaiting a successful
  outcome: the SSH provider rejects done when termination cancels a
  launch it has not yet acknowledged, which turned a retained dirty
  checkout into a failed cleanup.
- Test that a never-initialized submodule is removed and that Git
  refuses a committed embedded repository, which inspection leaves to
  Git by design.
- Record the git-status-only trade-off and its sparse-checkout rationale
  in the worktree Agent Note, and align the README, upgrade guide,
  maxOutputBytes description, and comments with what is streamed.

Refs #8151
2026-11-09 12:00:23 +08:00
Yichen Jiang f03981630c Merge remote-tracking branch 'origin/feat/forge-review-threads' into feat/forge-review-writes
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	packages/experimental/client-ui-forge/README.i18n.yaml
2026-11-09 11:50:38 +08:00
Yichen Jiang ce1e1f2681 Merge remote-tracking branch 'origin/master' into perf/forge-changes-view 2026-11-09 11:47:49 +08:00
Yichen Jiang cfee330356 fix(forge-panel): highlight lines in the render that draws them
Deferred idle-time highlighting drew token text, so a file whose content
changed at the same path kept showing its previous text until the next
pass, and replacing the plain text collapsed a selection made meanwhile.
Sections highlight in their drawing render again, as before.

File sections now take the tab's visibility as a prop and the reach
tracker through their handlers, so no business component reads a React
context.
2026-11-09 11:47:05 +08:00
Yichen Jiang c04c40b68a docs(forge): document review writes and record pending review drafts
The forge subsystem page documents ctx.forge.writeReview, its write
and result types, and the panel's changeRequestReviewWrite; the package
READMEs describe the GitHub mutations and their measured behavior, the
thread actions, and the pending review flow. A new Agent Note records
moving pull request comment drafts to the code host's pending review,
and the forge panel note links it. The Web e2e replies to, edits,
deletes, and resolves threads, and starts, submits, and discards a
pending review through the scripted gh double.
2026-11-09 11:38:56 +08:00
Yichen Jiang e7e5ed638d Merge remote-tracking branch 'origin/master' into feat/forge-review-threads
# Conflicts:
#	apps/web/tests/forge-panel.e2e.ts
#	packages/experimental/client-ui-forge/README.i18n.yaml
#	packages/experimental/client-ui-forge/src/client/DiffFile.tsx
#	scripts/type-equiv.manifest.json
2026-11-09 11:38:53 +08:00
Yichen Jiang b1aa940b0f feat(forge-panel): reply to, resolve, and edit review threads and submit the pending review
Thread cards gain a reply field, Resolve and Unresolve, and edit and
delete for the viewer's own comments. Start review and Add to review
add pull request comments to the GitHub pending review, which Submit
review submits or discards; while one exists, replies join it and no
single comment is offered, as GitHub refuses one. On the viewer's own
pull request the dialog offers only Comment. Comment drafts an earlier
panel kept in the browser stay editable, can move into the pending
review, and block submission while one exists.
2026-11-09 11:21:15 +08:00
Yichen Jiang b02529e520 feat(forge): write review threads and the pending review through the provider
ForgeProvider gains an optional writeReview for replies, resolution,
comment edits and deletions, and the viewer's pending review, which
review reads now report with the viewer's permissions. The GitHub
provider checks the head and the pending review in one query, then
sends one GraphQL mutation on stdin and never retries it; a reply at
once is refused while a pending review exists, since GitHub adds it
to that review. The forge panel Remote changeRequestReviewWrite drops
the kept threads after every write, because resolving a thread does
not move a pull request's updatedAt.
2026-11-09 11:21:00 +08:00
Yichen Jiang bafc363d78 fix(worktree): reclaim archived checkouts in large repositories
Archive cleanup read whole Git listings into the 64 KiB maxOutputBytes
buffer, so every clean checkout in a repository with more than about a
thousand tracked files settled as failed.

- Drop the skip-worktree/assume-unchanged and gitlink listings; removal
  follows what `git status` reports, as peer agent products do.
- Stream `git status` and stop at its first entry, and stream the
  worktree listing, so neither is bounded by maxOutputBytes; restoring a
  worktree shares the streamed lookup.
- Retain a checkout whose administrative directory holds submodule
  repositories instead of letting Git refuse the removal.

Refs #8151
2026-11-09 10:59:09 +08:00