Commit Graph
23706 Commits
Author SHA1 Message Date
ZiyaZhang 39fa48b074 Merge feat/creation-recommendations into plugin recommendation experiment
Takes current master through the base, including the runtime-context
approval sentence that recorded Web fixtures replay against.
2026-10-22 09:27:46 -07:00
ZiyaZhang 3801502461 test(web): refresh the page card fixture after the approval prompt wording change
Master now describes enabled approval prompts in the runtime context; the fixture records the new sentence.
2026-10-22 09:17:59 -07:00
ZiyaZhang 1e9600be15 Merge remote-tracking branch 'origin/master' into pr-6635-ci 2026-10-22 09:14:14 -07:00
ZiyaZhang b62dfa2d63 feat(experimental): invite to plugin cards only from the accepted call's result
The model sometimes wrote the skill's invitation sentence without calling
propose_action, so users read "click below" with no card. The plugin kind
now registers its invitation, which only an accepted call's result carries:
"Card shown below your answer. Do not restate it. End with at most one short
invitation in the user’s language to click Enable below; do not say the
plugin is already on." The skill drops its invitation sentence and says the
call's result tells how to end the answer. A test runs a real turn and checks
that the accepted result carries the invitation and a refused call does not;
the plugin Web fixture is refreshed for the new skill and result text.
2026-10-22 09:04:47 -07:00
ZiyaZhang d9b95adf93 Merge feat/creation-recommendations into plugin recommendation experiment
Takes the card invitation that only an accepted call's result carries. The
page card fixture keeps the base's skill and result text and the plugin
recommendations entry in its catalog. The plugin kind gains its invitation
in the next commit.
2026-10-22 09:03:38 -07:00
ZiyaZhang 969b4bd5f2 feat(experimental): give the card invitation only in the accepted call's result
The model sometimes wrote the skill's invitation sentence without calling
propose_action, so users read "click below" with no card. Each card kind
now registers its invitation, and only an accepted call's result carries
it: "Card shown below your answer. Do not restate it. <invitation>".
The personalized-pages skill drops its invitation sentence and says the
call's result tells how to end the answer; the Web fixture is refreshed
for the new skill and result text.
2026-10-22 08:57:29 -07:00
Tianyi Cui 5219b36110 Merge pull request #6498 from deepseek-harness/turtle/approval-never-wording-7e59b56e7f5c
fix(user-approval): describe approval policies by meaning in model-visible text
2026-10-22 23:47:16 +08:00
imccyu 3725e75edd Merge pull request #6991 from deepseek-harness/worktree-sync-dsh-0.2.1-to-master-1022
release(dsh): sync 0.2.1 navigation and model listing to master
2026-10-22 23:39:15 +08:00
imccyu 261f2db185 Merge master into DSH 0.2.1 navigation and model listing sync 2026-10-22 23:22:35 +08:00
ZiyaZhang 38c05d24b2 fix(experimental): confirm unconfirmed plugin cards before Not now
An enable cut off by a plugin reload can still land. The kind now uses the
shared reconcile step: before every action on an unconfirmed card, including
Not now, it checks the profile and records enabled when the plugin is on, so
the card is not dismissed or enabled again.
2026-10-22 08:17:48 -07:00
ZiyaZhang dbe0eb3aa2 Merge feat/creation-recommendations into plugin recommendation experiment
Takes the action-card fixes: kinds reconcile before every action, only live
roots get cards, the tool refuses while messages are queued, and bodies no
longer receive ready. The plugin card drops ready, its queued-card test goes
with the suppressed phase, and the shared-row limitation follows the base's
new limitations.
2026-10-22 08:16:20 -07:00
ZiyaZhang cb425d1384 fix(experimental): settle plugin cards from what enabling reports
- An enable that a plugin reload cuts off records unconfirmed; the card
  offers a retry and Not now, and a retry that finds the plugin on records
  enabled because this card's change landed.
- A rejected profile change records failed with operation-error and keeps
  the retry instead of failing the click; overridden and cancelled are gone
  because enabling a bundle only reports applied, restart-required or failed.
- A refused or lost catalog lookup keeps Not now and offers Try again, with
  separate copy for each; a settled card keeps its outcome after its plugin
  leaves the catalog. Only the clicked button shows Working, the details
  label is interpolated, and the reason and description stay its
  accessible description.
- The Host entry exports its inject list, so the configuration catalog lists
  its services; the skill keeps its rules without the examples.
- With both experiment bundles on, the shared action-card rows cannot be
  switched or configured on the Plugins page; the READMEs say so and a
  Loader test pins it while the bundles still switch.
- The unused intent fixture is removed and the evaluation set expects a
  create_personalized_page card for the counter.
2026-10-22 08:13:22 -07:00
Tianyi Cui 035fcb88dc Preserve SDK approval wording fixtures after rebase
Co-authored-by: Tianyi Cui <[email protected]>
2026-10-22 23:13:19 +08:00
TurtleandTianyi Cui 747cbf13b6 Describe the ask approval policy by its meaning
Replace the literal "Approval policy: ask." runtime-context sentence
with a statement parallel to the never-policy sentence, and refresh the
current-generation fixtures that persist it.

Co-authored-by: Tianyi Cui <[email protected]>
2026-10-22 23:13:19 +08:00
TurtleandTianyi Cui 43149cd905 Sync approval switch notice snapshot and docs
Update the Web permission-policy snapshot, the config catalog line
reference and README text for the new switch notice; pin both switch
directions in the unit test.

Co-authored-by: Tianyi Cui <[email protected]>
2026-10-22 23:13:19 +08:00
TurtleandTianyi Cui c29cda3777 Clarify approval policy switch notice wording
Name each policy by its meaning in the model-visible switch notice so a
bare "never" is not read as "approval is never granted".

Refs #6496

Co-authored-by: Tianyi Cui <[email protected]>
2026-10-22 23:13:19 +08:00
ZiyaZhang 9fd47804c2 fix(experimental): reconcile action cards before Not now and offer them to live roots only
- Kinds can reconcile a card before every user action, including Not now;
  the page kind confirms uncertain runs against the installed profile, so an
  installed page keeps Undo instead of being dismissed.
- Only a live root's direct skill load activates propose_action; calls from
  subagents or from code are refused.
- The tool refuses while queuedMessageLimit messages wait, so the model is
  never told a hidden card was shown; the suppressed phase is gone and the
  projection moves to state version 2.
- record() refuses actions no kind registered and the derived replaced phase.
- Not now dismisses an unstarted card whose kind is no longer registered.
- The unused ready prop and dead locale keys are removed, and the READMEs
  state the card and row rules as implemented.
2026-10-22 08:01:23 -07:00
Xu Hanxiang 70e2d31cc3 Merge pull request #6486 from deepseek-harness/feat/client-extension-points
feat(liveshare): add client and host seams a served read-only page needs
2026-10-22 22:57:27 +08:00
ZiyaZhang ad482a45ec test(web): replay the plugin card through propose_action
The plugin fixture now offers the card with a propose_action call, the
tool schema pin records the tool addition after the skill load, and the
card goldens name the region after the card title as the shared frame does.
The page fixture's skill catalog lists the plugin recommendation bundle.
2026-10-22 07:18:05 -07:00
ZiyaZhang fcb7340be1 refactor(experimental): register plugin recommendations as an action card kind
Plugin recommendations now proposes through the shared propose_action tool
instead of a dsh-action answer block. The Host registers the
enable_official_plugin kind with the action card service: the
official-plugins skill, details holding the plugin name, the Enable verb
with global access, and the enabled, already-enabled and failed phases,
whose data carries the application outcome and the management error code.
The package drops its own projection, Remote act, status notice and
persisted record; it keeps the describe Remote for card text. The bundle
inserts the shared card rows beside its own, as Personalized pages does.
The browser half registers a card body in the shared frame that keeps the
catalog text cache, the reserved loading lines, the single details target
and the Enable and Not now footer. The skill's submission section now asks
for one propose_action call.
2026-10-22 07:18:05 -07:00
mektpoy 76e39794eb revert(ui-session,ui-conversation): let the stop shortcut reach the Host
A reviewer blocked the one-shot boolean access read the stop shortcut used:
the client should not expose a render-time access answer as a boolean API.
The Esc-Esc sequence submits its cancel again, and a Host refusal surfaces as
the composer failure the Stop button would have prevented. Send keeps the same
treatment: the access snapshot withholds the buttons, the Host refuses the
request, and the composer reports it.
2026-10-22 22:16:06 +08:00
mektpoy 80ce0669e9 revert(ui-conversation): leave a withheld submission to the Host
The access snapshot still withholds the Send button, Stop, and file intake, and
the Esc-Esc stop path still reads its own answer before sending a cancel. A
keyboard submission, however, once again reaches the Host, which refuses it and
reports the failure to the composer; gating that path needs a larger redesign
of the composer keyboard face.
2026-10-22 21:57:49 +08:00
ZiyaZhang c6d9a964d3 Merge feat/creation-recommendations into plugin recommendation experiment 2026-10-22 06:50:25 -07:00
mektpoy d9c012551a revert(client): return the fork seam to master
ui-chat goes back to origin/master as a whole package: the footer branch forks
through ctx.sessions.fork with its own atSeq and analytics again, and Workspace
navigation takes no ForkSessionOptions. The package is identical to
origin/master, which drops the served-page branch assertions and README lines
added on this branch; they pinned behavior master already has.

ui-workspace restores master's forkSession signature and implementation
(allowMigration only, increaseTitle: true, selection untouched) and drops the
ForkSessionOptions type. uiSession leaves the inject list because the removed
session/rename probe was its only consumer. The row fork keeps passing
{ allowMigration: false }, which master already does, so forking from a shared
page never starts source-format migration.

Regenerate the client API catalog, restore the README fork contract (fork does
not navigate; allowMigration carries migration permission), re-record the
translation pairing, and return the ui-chat unknown-cast baseline count to 2.
2026-10-22 21:44:25 +08:00
mektpoy 58785b975e fix(ui-workspace): name every branch and open it on request
`increaseTitle` renames the child, not the source, and whoever may fork a Session also holds `session/rename` on the child it creates; the source's access answer therefore never decides the child's title. Remove the source-rename probe, the listed-branch wait, and its refresh-failure notice: `selected` opens the child immediately and `listed` leaves the selection alone. Update the public READMEs and the client API catalog.
2026-10-22 21:44:25 +08:00
mektpoy 0b72a81411 chore(docs): re-record the conversation README pairing after the master rebase 2026-10-22 21:44:25 +08:00
mektpoy 3ecac5aad4 chore(catalogs): follow the branch contract and Session access edits
Regenerate the client API catalog after the forkSession contract and the
ui-workspace gating changes.
2026-10-22 21:44:25 +08:00
mektpoy d985f44124 chore(ui-chat): correct the branch-rejection test comment
A rejected branch leaves the source view unchanged, as master does; the old
comment described the removed notice.
2026-10-22 21:44:25 +08:00
mektpoy 3bcb22f732 fix(ui-conversation): gate keyboard submission and stop
Enter, Mod+Enter, and accelerated queue steering now read the same prompt
answer as the Send button, and the fixed Esc-Esc sequence reads the live
session/cancel answer before it consumes a press. The composer locks for a
denied prompt, the README states both paths, and tests pin each gesture.
2026-10-22 21:44:25 +08:00
mektpoy cfc2fd926e fix(ui-workspace): route row gates through the Session service
Read the branch-naming answer through uiSession.access instead of the
cross-kind source, drop the unused openListedBranch method, give the branch
list refresh its own notice, and gate the search result restore control like
the archive row. The forkSession contract now states its navigation and throws
behaviour, present documents its 2x2 landing table, and the README describes
the real branch policy and row gating.
2026-10-22 21:44:25 +08:00
mektpoy f0fcd68b7b feat(ui-session): answer Session access for JS callers
The Session kind owns its remoteAccess source, so other plugins get one
non-Hook read from this service instead of reading the source themselves.
Navigation uses it for the branch-naming answer.
2026-10-22 21:44:25 +08:00
mektpoy b1f10381cb fix(ui-deliverables): return the package to master
The owner-baseline gate this branch added has no reader on the master access
API, and the reader page reads files through the Host route instead.
2026-10-22 21:44:25 +08:00
mektpoy 491515268a chore(docs): regenerate the cordis catalog after the frontend-static simplification 2026-10-22 21:44:25 +08:00
mektpoy c3f2fbbdad chore(client): follow the merged seam records in generated artifacts
The client inspect catalog follows the seam signatures, the unknown-cast
baseline drops the two casts this branch retired, and the README pairing
records match the merged prose.
2026-10-22 21:44:25 +08:00
mektpoy 55deb7a6c6 fix(ui-workspace): keep the per-resource access gates on the whenAccess client
Master's rows and menus carry no answer of their own, so the served-page seams
thread the Slot-standard access Hooks through the workspace browser and the
session actions: New Session, workspace rename/delete/reorder, and a Session's
rename, pin, archive, and reorder appear only while their own resource allows
them. The rows spec keeps master's pointer-armed rename helper and supplies the
allow-all answers as props.
2026-10-22 21:44:25 +08:00
imccyu 0d521bdd0d refactor(client): drop owner-era leftovers and gate sidebar New Session on session/create
- The Conversation binding tracking returns to master: the retainInfo subscription and the
  plugin-owned binding effects are a separate fix, not a served-page seam.
- The deliverables opener drops the ownerHostRoutes parameter no caller passes any more.
- Assertions on existing connection and HMR behavior, the menu-open-state spec, and the
  settings-general roster splice return to master.
- Workspace shortcuts no longer re-read Session access through source(); the Host refuses a
  denied rename, fork, or archive.
- The sidebar New Session button, the window-chrome New Session control, and the expanded
  brand shortcut render only while useRemoteAccess('session/create') allows it.
2026-10-22 21:44:25 +08:00
imccyu a154f70ab9 refactor(client): read composer access through useAccess and drop the branch-refusal notice
- The composer decides file intake from the Session-scope useAccess('fileUploads/upload')
  answer, like Send and Stop. The optional fileIntake hook seat, the InputHub fileIntake
  entries, and the ui-slots optional-hook typing are removed.
- The fixed Stop shortcut no longer re-reads session/cancel through a shared stop; the
  button stays hidden by useAccess and the Host refuses a withdrawn cancel.
- uiConversation.noticeBranchRefusal, branch.ts, ForkRefusal, and message.branchRefused are
  removed; a failed Chat branch leaves the source view unchanged, as on master.
2026-10-22 21:44:25 +08:00
mektpoy e30684cf9c fix(client): keep the served-page records on the master access API
The owner-baseline gating commits are superseded by master's whenAccess seams,
so the remaining records revert to the master shapes: the deliverables opener
takes no owner answer, the Japanese dictionaries carry the surviving copy, and
the test splice and owner assertions match the current services.
2026-10-22 21:44:25 +08:00
mektpoy 82ed6eee99 fix(ui-chat): narrow the injected Chat View without an unknown assertion
Read the slot injection through its real rest-parameter function type and invoke it directly, so the static gate sees no new assertion to unknown. The client inspect catalog's expected uiWorkspace signature follows the generated catalog after the fork options became ForkSessionOptions.
2026-10-22 21:44:25 +08:00
mektpoy b191c5c865 revert(session-controller): restore the package to master
P1 keeps only the client/host extension seams; the requestId deduplication,
the cancel recheck, and the named fork child are deferred to a later change.
The package, its README pair, and the persistence schema lines return to the
master state, so the branch adds no session-controller behaviour.
2026-10-22 21:44:25 +08:00
mektpoy 1624faeb23 fix(ui-conversation): keep the released-binding and shared-stop edges
Type the tracked binding disposers by their real shape and let a disposed
context's shared stop surface its own loud unavailable error instead of
reporting a withdrawn permission.
2026-10-22 21:44:25 +08:00
mektpoy fbc90909b1 fix(ui-conversation): gate the fixed stop shortcut through the shared stop
The button re-read the live session/cancel answer but the fixed shortcut
received the raw stop, so a withdrawal still sent Esc-Esc cancellation. Build
one gated stop used by both entry points and cover the shared gate.
2026-10-22 21:44:25 +08:00
mektpoy 938e82484f fix(ui-conversation): narrow a fork rejection before reading its code
A rejection may be null, undefined, or any non-object; reading rpcError through
it threw a TypeError and replaced the branch-refusal notice with a crash. Narrow
the value first and cover the non-object rejections.
2026-10-22 21:44:24 +08:00
mektpoy 15ab556c3e fix(ui-conversation): release each binding effect with its Session scope
The long-lived plugin effect wrapped every Session-scope effect, so a released
binding's Context stayed referenced until plugin unload. Track the binding-scope
effects in a map that the binding cleanup and the plugin unload both drain;
nothing long-lived closes over a released binding.
2026-10-22 21:44:24 +08:00
mektpoy 44f0996974 fix(session-controller): ask the concrete access decision before cancelling
The recheck used allows(), the list-filter view that never sees call arguments,
so a policy narrowing cancel to args.request refused a legitimate caller as
access-withdrawn forever. Ask decide() with the principal and the request, keep
the policy's own refusal reason, and cover both an args-independent role and an
args-dependent condition.
2026-10-22 21:44:24 +08:00
mektpoy 258ff28b72 fix(session-controller): finish the Workspace attach a named fork left pending
A first attempt that materialized the child and then failed at attachSession
was reported as failed, but its retry adopted the stored child and returned
success before attaching it, leaving the child ungrouped. The adoption path now
completes the missing attach and reports the same session/workspace-attach-failed
if that still rejects.
2026-10-22 21:44:24 +08:00
mektpoy 608f08ab31 refactor(session-controller): drop the prompt pre-delivery access recheck
The Gateway already admits each call; P1 no longer re-reads the caller's access
after prompt admission. Cancellation still refuses delivery when the caller
aborts during admission, and the requestId dedup/conflict, cancel recheck, and
fork naming behavior stay. The README pair follows.
2026-10-22 21:44:24 +08:00
mektpoy 4322b97840 refactor(ui-workspace): own the branch naming and listed presentation
The published UiWorkspace no longer requires openListedBranch: that wait is an
internal navigation helper, and the service forkSession takes the branch
boundary and presentation choice as optional inputs. The Chat branch surface
now supplies only its branch point and analytics and lets Workspace navigation
decide whether the child may be named and when it becomes presentable.
2026-10-22 21:44:24 +08:00
mektpoy 5ff6b3cdc5 test(ui-chat): pin the owner page branch-refusal notice
A refused branch now reports itself on the owner's own page: the Chat
injection writes the notice on the addressed Session and the composer bar
renders it as an alert, so the owner-visible change has an assertion at both
seams.
2026-10-22 21:44:24 +08:00
mektpoy 52b2bd064f refactor(ui-conversation): read file intake through one InputHub entry
The composer hook source and the drop gate now resolve the same live intake
answer from InputHub, so the policy and its two readers cannot drift; the
caller keeps ownership of the rejection copy.
2026-10-22 21:44:24 +08:00