fix(open-in-app): 每次打开文件菜单都校验路径,已打开的菜单只响应本类型的回答
A file menu now reuses its verified Host path only while its own association subscription re-resolves it synchronously, and the verification record is cleared when a stat starts instead of when the registry observes. Every opening therefore runs its own stat whatever order the context-menu registry observes and resolves in; a registry change can at most cost another stat or a flicker. An open menu re-resolves only when its own file type's answer changes. The answer comparison lists every application field and fails to compile when the type gains one. README documents the remaining cache limitations.
This commit is contained in:
1 parent
0eda288f13
commit
ea7c21c8a4
6 files changed
+76
-33
No files matched your search
@@ -18,11 +18,11 @@
|
||||
en: b149da9963eb9837
|
||||
zh: 2426ea37fbd0f8b7
|
||||
/deepseek-ai-dsh-client-ui-open-in-app/use-this-package/what-to-expect:
|
||||
en: 4e40e41d89fe99a9
|
||||
zh: 818b488e997132f5
|
||||
en: 53d5d74d5b1d9b66
|
||||
zh: bdd9806dca51e957
|
||||
/deepseek-ai-dsh-client-ui-open-in-app/understand-the-implementation:
|
||||
en: 020fda5b8360fb3d
|
||||
zh: 7c33f3f45c41e64e
|
||||
en: c26d8937f5d38119
|
||||
zh: d353c2377b9747aa
|
||||
/deepseek-ai-dsh-client-ui-open-in-app/further-exploration:
|
||||
en: 720527877e452a97
|
||||
zh: b2241c7a336a3eeb
|
||||
@@ -33,8 +33,8 @@
|
||||
en: ca75c51c89c2c9b0
|
||||
zh: c2241315dc0c89c9
|
||||
/deepseek-ai-dsh-client-ui-open-in-app/known-limitations-and-deferred-work:
|
||||
en: 2fd6d93cc66f3b42
|
||||
zh: 9199fbf041fe2ad4
|
||||
en: f206d2fefa52f81d
|
||||
zh: 51025a6e19d01295
|
||||
/deepseek-ai-dsh-client-ui-open-in-app/known-limitations-and-deferred-work/dev-note:
|
||||
en: 84f92568fc74adf1
|
||||
zh: 286b47e6b5b1a556
|
||||
@@ -39,7 +39,7 @@ The **Open locally** shortcut captures the main Session’s directory and rememb
|
||||
|
||||
File menus list the discovered associated applications without a separate “Open in default app” row. “Show file location” stays in a fixed footer separated from the scrolling applications. A successful query with only one available action renders a single button without a dropdown. Initial file-association loading uses a gray skeleton icon. When the Host identifies a default application the menu marks it “(default)” and the main button opens it; otherwise the first associated application takes that place, so the main button reveals the file only when no application is registered. Directory menus have no reveal row. Choosing a file application does not change the system default. An unpreviewable file uses the same menu in a 40px-high split button with an icon and action text; its label is “Open” or “Show file location” according to the default action.
|
||||
|
||||
Mounted controls with the same association reader and file share one query and its results; opening either menu refreshes all of them. Releasing the last control cancels the query and discards its state. Cancelled queries cannot replace another file’s results. A successful answer also replaces the page’s record for the file’s association class unless a later-started query has already answered it; the class is the final name extension, compared case-sensitively, or the whole path when the name has none. A failed query displays a menu message and leaves reveal available as the default action. File-association discovery follows [native-command](../../util/native-command/README.md); an empty result, including a platform without a discovery adapter, uses the same reveal fallback without platform branches in the control.
|
||||
Mounted controls with the same association reader and file share one query and its results; opening either menu refreshes all of them. Releasing the last control cancels the query and discards its state. Cancelled queries cannot replace another file’s results. A successful answer also replaces the page’s record for the file’s association class unless a later-started query has already answered it; the class is the final name extension, compared case-sensitively, or the whole path when the name has none. Mounted controls do not read that record and keep their own answer until their menu opens again, so the file header and a context menu can name different applications for one file meanwhile. A failed query displays a menu message and leaves reveal available as the default action. File-association discovery follows [native-command](../../util/native-command/README.md); an empty result, including a platform without a discovery adapter, uses the same reveal fallback without platform branches in the control.
|
||||
|
||||
Workspace context menus reveal the captured folder through the shared directory application catalog. File-tree directories expose native reveal and Copy folder path; they do not offer file preview or save.
|
||||
|
||||
@@ -59,7 +59,7 @@ A file menu offers “Open in sidebar” and “Open in floating panel”, which
|
||||
|
||||
[`session-open-with.ts`](src/client/session-open-with.ts) shares one resolver across the shared context-menu package’s `session` and `sessionHeader` targets; other contributions do not cross between those targets. The file-tree slot uses `OpenInAppAction` with its owner’s `absolutePath`; there is no independent Session-header opener slot. A page-lifetime [`controller`](src/client/controller.ts) owns availability, persisted choice, and launch POST state. Menu observers and injected component hooks read those same sources. Document-relative routes and payload types come from the Host’s browser-safe `@deepseek-ai/dsh-host-open-in-app/shared` subpath. Adapters resolve native and transport failures to named outcomes; skipped requests announce nothing.
|
||||
|
||||
The directory and file adapters supply application metadata and operations to [`OpenTargetButton`](src/client/OpenTargetButton.tsx), which owns menu ordering, default markers, icons, and sizing. Its injected reporter sends outcomes to one feature-owned `shell.overlay` toast, so switching Sessions or closing the initiating preview cannot discard the result. The file header and empty state share `FileOpenTarget`, while `OpenPathInjected.applications` queries `session.workspacePathApplications` through [`open-path.ts`](src/client/open-path.ts). The same controller keeps the page’s answers by association class, runs one background refresh at a time, which the next opening cancels, and publishes a new snapshot only when an answer changes. The file menu observes that snapshot and re-resolves from its verified path synchronously, so the context-menu registry keeps the other rows while the application row changes. Opening uses `session.openWorkspacePath`; the Host revalidates an explicitly selected handler before launch. The directory adapter keeps the existing catalog routes. `FileRouteAction` supplies the same control to delivery cards and change review through `deliverables.file.actions` and `deliverables.review.file.actions`; their authenticated routes retain Session file authorization. A failed or unavailable file query therefore needs no platform-specific UI implementation.
|
||||
The directory and file adapters supply application metadata and operations to [`OpenTargetButton`](src/client/OpenTargetButton.tsx), which owns menu ordering, default markers, icons, and sizing. Its injected reporter sends outcomes to one feature-owned `shell.overlay` toast, so switching Sessions or closing the initiating preview cannot discard the result. The file header and empty state share `FileOpenTarget`, while `OpenPathInjected.applications` queries `session.workspacePathApplications` through [`open-path.ts`](src/client/open-path.ts). The same controller keeps the page’s answers by association class, runs one background refresh at a time, which the next opening or plugin unload cancels, and publishes a new snapshot only when an answer changes. The file menu observes that snapshot; when its own file type’s answer changes, it re-resolves synchronously from the path its opening verified, so the context-menu registry keeps the other rows while the application row changes. Opening uses `session.openWorkspacePath`; the Host revalidates an explicitly selected handler before launch. The directory adapter keeps the existing catalog routes. `FileRouteAction` supplies the same control to delivery cards and change review through `deliverables.file.actions` and `deliverables.review.file.actions`; their authenticated routes retain Session file authorization. A failed or unavailable file query therefore needs no platform-specific UI implementation.
|
||||
|
||||
</details>
|
||||
|
||||
@@ -93,7 +93,8 @@ The Host verifies the path through the composed filesystem before opening or rev
|
||||
|
||||
- **The dictionaries gate the menu.** A host catalog extension without a matching `app.<id>` entry in both dictionaries stays invisible instead of showing a raw id; extending the catalog means extending [`dsh-host-open-in-app`](../../host/open-in-app/README.md) and this package's locales together.
|
||||
- **Availability is read once per page.** An application installed while the page is open appears after a reload (and, host-side, after a host restart); the desktop answer behind the file controls is read once per page as well.
|
||||
- **File associations are cached by type for the page.** Files sharing a final name extension share one answer. A per-document override, such as a macOS “Open with” choice for one file, can therefore show the type’s previous answer until the background query corrects the open menu; Linux content sniffing and multi-part extensions such as `.tar.gz` have the same effect. Choosing the row before the correction opens the application that answer named. Names without an extension are recorded per path. Records, with one icon per application, grow with the file types seen and end with the page.
|
||||
- **File associations are cached by type for the page.** Files sharing a final name extension share one answer; extensions that differ only in case, such as `.PNG` and `.png`, are separate types. A per-document override, such as a macOS “Open with” choice for one file, can therefore show the type’s previous answer until the background query corrects the open menu. Linux content sniffing and multi-part extensions such as `.tar.gz` have the same effect, and one file’s empty answer shows the row disabled for the type’s other files the same way. Choosing the row before the correction opens the application that answer named. Names without an extension are recorded per path. Records, with one icon per application, grow with the file types seen and end with the page.
|
||||
- **One background refresh at a time.** Opening another file menu cancels the previous menu’s unanswered query, so that type keeps its earlier answer, or none, until its next opening.
|
||||
- **One reveal label for every platform.** The Session Remote reports whether a desktop exists, not which file manager it runs, so the menu says "Show file location" rather than naming Finder or File Explorer as the delivery cards do.
|
||||
- **The delivery cards keep their own opener.** [`ui-deliverables`](../ui-deliverables/README.md) still opens declared files through its own Session-and-event routes; folding those cards onto the file controls here remains deferred.
|
||||
|
||||
|
||||
@@ -39,7 +39,7 @@ kind: "package-reference"
|
||||
|
||||
文件菜单列出已发现的关联应用,不单列“用默认应用打开”。“显示文件位置”固定在菜单底部,通过分隔线与滚动的应用列表分开。查询成功且只有一个可用操作时显示单按钮,不再显示下拉箭头。文件关联首次加载时使用灰色骨架图标。Host 识别出默认应用时,菜单将该项标注为“(默认)”,主按钮打开该应用;否则第一个关联应用占据该位置,只有在一个关联应用都没有时主按钮才执行文件定位。目录菜单不包含定位项。选择文件应用不修改系统默认应用。无法预览文件时,空态使用同一菜单,按钮增大到 40px 高并显示图标和动作文字;根据默认动作显示“打开”或“显示文件位置”。
|
||||
|
||||
使用同一查询函数和文件的已挂载控件共用查询与结果,打开任一菜单会刷新所有相关控件。最后一个控件释放后取消查询并清除状态。已取消的查询不会覆盖其他文件的结果。查询成功后,结果还会替换本页面中该文件关联类别的记录,除非更晚发起的查询已经给出回答;类别按文件名的最后一个扩展名划分(区分大小写),没有扩展名的文件按完整路径划分。查询失败时菜单显示提示,并以文件定位作为默认动作。文件关联查询的平台支持范围见 [native-command](../../util/native-command/README.zh.md);查询结果为空时,包括平台尚无查询适配器的情况,控件统一使用定位动作,不按操作系统分支处理。
|
||||
使用同一查询函数和文件的已挂载控件共用查询与结果,打开任一菜单会刷新所有相关控件。最后一个控件释放后取消查询并清除状态。已取消的查询不会覆盖其他文件的结果。查询成功后,结果还会替换本页面中该文件关联类别的记录,除非更晚发起的查询已经给出回答;类别按文件名的最后一个扩展名划分(区分大小写),没有扩展名的文件按完整路径划分。已挂载控件不读取这份记录,会保留自己的回答,直到再次打开其菜单,因此在此期间同一个文件在文件标题栏和右键菜单中可能显示不同的应用。查询失败时菜单显示提示,并以文件定位作为默认动作。文件关联查询的平台支持范围见 [native-command](../../util/native-command/README.zh.md);查询结果为空时,包括平台尚无查询适配器的情况,控件统一使用定位动作,不按操作系统分支处理。
|
||||
|
||||
工作区右键菜单通过共享的目录应用列表定位被点击的文件夹。文件树目录提供原生定位与复制文件夹路径,不提供文件预览或保存。
|
||||
|
||||
@@ -59,7 +59,7 @@ kind: "package-reference"
|
||||
|
||||
[`session-open-with.ts`](src/client/session-open-with.ts) 为共享右键菜单包声明的 `session` 和 `sessionHeader` 目标共用一个解析器;其他贡献不会在这两种目标间扩散。文件树插槽通过所属组件的 `absolutePath` 使用 `OpenInAppAction`;会话头部没有独立打开按钮插槽。页面生命周期的 [`controller`](src/client/controller.ts) 持有可用性、持久化偏好与启动 POST 状态。菜单观察器和组件注入 hooks 读取同一组源。文档相对路由与载荷类型来自 Host 的浏览器安全子路径 `@deepseek-ai/dsh-host-open-in-app/shared`。适配器将原生操作及传输失败解析为具名结果;跳过的请求不播报。
|
||||
|
||||
目录和文件适配器把应用信息与操作交给 [`OpenTargetButton`](src/client/OpenTargetButton.tsx),由它统一管理菜单顺序、默认标记、图标和尺寸。注入的回调将结果交给本功能在 `shell.overlay` 中持有的唯一 toast,因此切换会话或关闭发起操作的预览不会丢失结果。文件标题栏和空态共用 `FileOpenTarget`,`OpenPathInjected.applications` 通过 [`open-path.ts`](src/client/open-path.ts) 查询 `session.workspacePathApplications`。同一控制器按关联类别保存本页面的回答,同一时间只运行一次后台刷新(下一次打开菜单会取消尚未完成的刷新),只在回答变化时发布新快照。文件菜单观察该快照,并基于已验证的路径同步重新解析,因此右键菜单注册表保留其他各项,只有应用这一项原地变化。打开操作使用 `session.openWorkspacePath`,Host 在启动前重新验证指定的关联应用。`FileRouteAction` 通过 `deliverables.file.actions` 和 `deliverables.review.file.actions` 为交付卡片和变更对比页提供同一控件,其认证路由保留会话文件校验。目录适配器继续使用已有的应用列表路由,文件查询失败或不可用时无需增加平台专用的界面实现。
|
||||
目录和文件适配器把应用信息与操作交给 [`OpenTargetButton`](src/client/OpenTargetButton.tsx),由它统一管理菜单顺序、默认标记、图标和尺寸。注入的回调将结果交给本功能在 `shell.overlay` 中持有的唯一 toast,因此切换会话或关闭发起操作的预览不会丢失结果。文件标题栏和空态共用 `FileOpenTarget`,`OpenPathInjected.applications` 通过 [`open-path.ts`](src/client/open-path.ts) 查询 `session.workspacePathApplications`。同一控制器按关联类别保存本页面的回答,同一时间只运行一次后台刷新(下一次打开菜单或插件卸载会取消尚未完成的刷新),只在回答变化时发布新快照。文件菜单观察该快照;只有本文件类型的回答变化时,才基于本次打开时验证的路径同步重新解析,因此右键菜单注册表保留其他各项,只有应用这一项原地变化。打开操作使用 `session.openWorkspacePath`,Host 在启动前重新验证指定的关联应用。`FileRouteAction` 通过 `deliverables.file.actions` 和 `deliverables.review.file.actions` 为交付卡片和变更对比页提供同一控件,其认证路由保留会话文件校验。目录适配器继续使用已有的应用列表路由,文件查询失败或不可用时无需增加平台专用的界面实现。
|
||||
|
||||
</details>
|
||||
|
||||
@@ -93,7 +93,8 @@ Host 在打开或定位前通过当前文件系统验证路径。没有对应 Ho
|
||||
|
||||
- **词典把守菜单。** 主机目录的新条目若在两份词典中没有对应的 `app.<id>` 条目,将保持不可见而不是显示裸 id;扩展目录意味着同时扩展 [`dsh-host-open-in-app`](../../host/open-in-app/README.zh.md) 与本包的 locale。
|
||||
- **可用性每页只读一次。** 页面打开期间安装的应用要重新加载页面后才出现(主机侧还需主机重启);文件控件背后的桌面回答同样每页只读一次。
|
||||
- **文件关联按类型在页面内缓存。** 最后一个扩展名相同的文件共用一个回答。因此单个文件的单独设置(例如 macOS 中只针对某个文件的“打开方式”)可能先显示该类型之前的回答,再由后台查询更正已打开的菜单;Linux 的内容嗅探和 `.tar.gz` 这类多段扩展名也有同样的效果。在更正之前选择这一项,会用该回答中的应用打开。没有扩展名的文件按路径记录。记录以及每个应用的一份图标随出现过的文件类型增长,并在页面关闭时释放。
|
||||
- **文件关联按类型在页面内缓存。** 最后一个扩展名相同的文件共用一个回答;只有大小写不同的扩展名(如 `.PNG` 和 `.png`)算作不同类型。因此单个文件的单独设置(例如 macOS 中只针对某个文件的“打开方式”)可能先显示该类型之前的回答,再由后台查询更正已打开的菜单。Linux 的内容嗅探和 `.tar.gz` 这类多段扩展名也有同样的效果;某个文件的空回答也会以同样的方式,让同类型其他文件的这一项先显示为禁用。在更正之前选择这一项,会用该回答中的应用打开。没有扩展名的文件按路径记录。记录以及每个应用的一份图标随出现过的文件类型增长,并在页面关闭时释放。
|
||||
- **同一时间只有一次后台刷新。** 打开另一个文件的菜单会取消前一个菜单尚未返回的查询,该类型保留之前的回答(或仍没有回答),直到下次打开。
|
||||
- **所有平台共用一个定位标签。** Session Remote 只报告有没有桌面,不报告它跑的是哪个文件管理器,所以菜单写「显示文件位置」,而不像交付卡片那样点名访达或文件资源管理器。
|
||||
- **交付卡片保留自己的打开器。** [`ui-deliverables`](../ui-deliverables/README.zh.md) 仍通过自己按 Session 与事件定位的路由打开声明过的文件;把这些卡片并到这里的文件控件上仍属延期工作。
|
||||
|
||||
|
||||
@@ -109,31 +109,46 @@ export function registerContextMenus(
|
||||
} },
|
||||
]
|
||||
}
|
||||
// The verified Host path of each open file menu. Association answers re-resolve the menu from it
|
||||
// synchronously, so the registry keeps the other rows while the application row changes in place.
|
||||
// This relies on the registry subscribing once per occurrence before its first resolution, and on a
|
||||
// synchronous resolution replacing rows without clearing them first.
|
||||
const verified = new WeakMap<ContextMenuTargetMap['file'], { readonly absolutePath: string | undefined } | null>()
|
||||
// The Host path from each file target's latest successful stat, shared by menus open on one target object at once.
|
||||
// A stat clears it while running; answers arriving meanwhile need no re-resolution, as that stat's resolution reads
|
||||
// the newest answers.
|
||||
const verified = new WeakMap<ContextMenuTargetMap['file'], string>()
|
||||
// The target whose changed association answer is being applied; only that re-resolution reuses the verified path,
|
||||
// so every opening runs its own stat. The in-place update relies on the registry re-resolving synchronously from
|
||||
// the notification, without which the menu stats again, and on a synchronous resolution replacing rows without
|
||||
// clearing them first, without which the rows flicker.
|
||||
let answering: ContextMenuTargetMap['file'] | undefined
|
||||
ctx.effect(() => ctx.contextMenus.register({
|
||||
id: 'open-in-app.file', target: 'file', order: 100,
|
||||
observe: (target) => {
|
||||
verified.set(target, null)
|
||||
// The first resolution reads the newest answers once verified; answers arriving earlier need no re-resolution.
|
||||
return [{
|
||||
getSnapshot: paths.associations.getSnapshot.bind(paths.associations),
|
||||
subscribe: (listener: () => void) => paths.associations.subscribe(() => { if (verified.get(target)) listener() }),
|
||||
}]
|
||||
},
|
||||
observe: target => [{
|
||||
getSnapshot: paths.associations.getSnapshot.bind(paths.associations),
|
||||
subscribe: (listener: () => void) => {
|
||||
// Answers for other file types leave this menu unchanged.
|
||||
let shown: ReturnType<typeof paths.cachedApplications>
|
||||
return paths.associations.subscribe(() => {
|
||||
const absolutePath = verified.get(target)
|
||||
if (absolutePath === undefined) return
|
||||
const applications = paths.cachedApplications(absolutePath)
|
||||
if (applications === shown) return
|
||||
shown = applications
|
||||
answering = target
|
||||
try { listener() } finally { answering = undefined }
|
||||
})
|
||||
},
|
||||
}],
|
||||
resolve: (target, signal) => {
|
||||
const settled = verified.get(target)
|
||||
if (settled) return fileMenu(target, settled.absolutePath)
|
||||
const verifiedPath = answering === target ? verified.get(target) : undefined
|
||||
if (verifiedPath !== undefined) return fileMenu(target, verifiedPath)
|
||||
verified.delete(target)
|
||||
return (async () => {
|
||||
await paths.load()
|
||||
const absolutePath = await resolvePath(target.sessionId, target.path, signal)
|
||||
signal.throwIfAborted()
|
||||
verified.set(target, { absolutePath })
|
||||
// A cached answer shows at once; every opening re-queries so a changed association reaches this menu.
|
||||
if (absolutePath !== undefined && paths.desktop.getSnapshot() === true) paths.refreshApplications(absolutePath)
|
||||
if (absolutePath !== undefined) {
|
||||
verified.set(target, absolutePath)
|
||||
// A cached answer shows at once; every opening re-queries so a changed association reaches this menu.
|
||||
if (paths.desktop.getSnapshot() === true) paths.refreshApplications(absolutePath)
|
||||
}
|
||||
return fileMenu(target, absolutePath)
|
||||
})()
|
||||
},
|
||||
|
||||
@@ -20,12 +20,16 @@ function associationKey(path: string): string {
|
||||
return dot > 0 && dot < name.length - 1 ? `extension:${name.slice(dot)}` : `path:${path}`
|
||||
}
|
||||
|
||||
/** The compared application fields; a field added to the type fails to compile until it is listed here. */
|
||||
const APPLICATION_FIELDS = Object.keys({
|
||||
id: true, name: true, default: true, icon: true,
|
||||
} satisfies Record<keyof SessionWorkspacePathApplication, true>) as readonly (keyof SessionWorkspacePathApplication)[]
|
||||
|
||||
/** Equal answers keep the published snapshot, so observers re-resolve only when an answer changes. */
|
||||
function sameApplications(left: Applications, right: Applications): boolean {
|
||||
return left.length === right.length && left.every((app, index) => {
|
||||
const other = right[index]
|
||||
return other !== undefined && app.id === other.id && app.name === other.name
|
||||
&& app.default === other.default && app.icon === other.icon
|
||||
return other !== undefined && APPLICATION_FIELDS.every(field => app[field] === other[field])
|
||||
})
|
||||
}
|
||||
|
||||
@@ -58,7 +62,7 @@ export class OpenInAppPathController {
|
||||
readonly associations: ObservableSnapshot<ReadonlyMap<string, Applications>> = this.answers
|
||||
private loading: Promise<void> | undefined
|
||||
private readonly lifetime = new AbortController()
|
||||
/** The background refresh in flight; a newer refresh cancels it. */
|
||||
/** The latest background refresh; a newer refresh aborts it. */
|
||||
private refresh: AbortController | undefined
|
||||
/** Start order of the query whose answer each class holds; an earlier query never replaces a later one. */
|
||||
private readonly answeredBy = new Map<string, number>()
|
||||
|
||||
@@ -209,6 +209,28 @@ it('verifies a file menu once when answers for other files arrive during verific
|
||||
menu.dispose()
|
||||
})
|
||||
|
||||
it('verifies every opening of a file target, whatever order the registry observes and resolves in', async () => {
|
||||
const register = vi.spyOn(MenuRegistry.prototype, 'register')
|
||||
const h = await boot()
|
||||
const contribution = register.mock.calls.map(([input]) => input).find(input => input.id === 'open-in-app.file')!
|
||||
const target = { sessionId, path: 'notes.txt' }
|
||||
// Resolving without observing first, as a registry that subscribes after its first resolution would.
|
||||
await contribution.resolve(target, new AbortController().signal)
|
||||
await contribution.resolve(target, new AbortController().signal)
|
||||
expect(h.remote.workspaceFiles.stat).toHaveBeenCalledTimes(2)
|
||||
})
|
||||
|
||||
it('re-resolves an open file menu only when its own file type answers differently', async () => {
|
||||
const h = await boot()
|
||||
const menu = await h.resolve({ kind: 'file', value: { sessionId, path: 'notes.txt' } })
|
||||
await vi.waitFor(() => { expect(menu.source.getSnapshot().find(item => item.id === 'open-in-app.file/open')?.label).toBe('open.title') })
|
||||
const shown = menu.source.getSnapshot()
|
||||
await h.paths.applications('/workspace/other.md', new AbortController().signal)
|
||||
expect(h.paths.cachedApplications('/workspace/other.md')).toHaveLength(1)
|
||||
expect(menu.source.getSnapshot()).toBe(shown)
|
||||
menu.dispose()
|
||||
})
|
||||
|
||||
it('keeps copy-path available on failed metadata and reports native action failures', async () => {
|
||||
const h = await boot()
|
||||
const file = { kind: 'file', value: { sessionId, path: 'file.svg' } } as const
|
||||
|
||||
Reference in new issue
Block a user