test(web): scope SVG delivery snapshot to the chat transcript
This commit is contained in:
yudshj authored and Yudong Han committed
1 parent
152e0f42ca
commit
9708c4bb42
5 files changed
+8
-37
No files matched your search
+2
-2
@@ -2,5 +2,5 @@
|
||||
# side as of the last confirmed-consistent state. Both languages carry equal authority;
|
||||
# after editing either side, bring the other along and re-record with:
|
||||
# pnpm run verify-translation-pairing --write .agents/notes/implemented/feature/2026-09-08-present-workspace-source-files.md
|
||||
2026-09-08-present-workspace-source-files.md: 876774e371174541406ec3423902b15c2ca7a27f
|
||||
2026-09-08-present-workspace-source-files.zh.md: e6d3d394ee0d5ef7aa130962c4fb3ba79ddccf39
|
||||
2026-09-08-present-workspace-source-files.md: 6a8ebfcf1fd7be22a5bda5a209d0fdc3586931bb
|
||||
2026-09-08-present-workspace-source-files.zh.md: d9361f2281eeb027e4c44b84c7f01af1639b66f2
|
||||
@@ -12,11 +12,11 @@ Users need to open and edit the files produced in their workspace, including she
|
||||
|
||||
The [present tool](../../../../packages/fs/tool-present/README.md) declares existing regular files inside the calling Session's workspace. It records paths and optional descriptions without reading or copying contents. The [deliverables plugin](../../../../packages/client/ui-deliverables/README.md) opens current workspace sources in the Host's default application. Edits are visible on the next open; deletion or movement makes the declaration unavailable. File-content preservation and copy-on-write storage are deferred until a persistence design owns them.
|
||||
|
||||
The tool description requires `present` after writing a file the user asked to receive and before the final response, including files created through Bash or code execution. A prose path reference does not replace the call. The recorded [SVG delivery scenario](../../../../snapshots/web/present-svg/snapshot.yml) uses a user request that does not name `present`, and checks the resulting file, delivery event, and card.
|
||||
The tool description requires `present` after writing a file the user asked to receive and before the final response, including files created through Bash or code execution. A prose path reference does not replace the call. The recorded [SVG delivery scenario](../../../../snapshots/web/present-svg/snapshot.yml) uses a user request that does not name `present`, and checks the resulting file, delivery event, and card. Its UI snapshot covers the expanded Chat transcript; navigation and composer controls belong to their own scenarios, so unrelated chrome changes cannot invalidate file-delivery expectations.
|
||||
|
||||
The tool remains an ordinary package with shared filesystem and tool error classes. Its pure type entry owns the delivery event without importing Host code into the browser. The `standard`, `ptc`, and `cordis` presets mount it; `minimal` retains its two tools. Each plugin instance correlates its executions with successful final `tools/result` notifications before appending `deliverables/presented`. Native and nested calls share this rule. A later enclosing program failure does not revoke a completed nested declaration; blocked results publish none, and same-name scoped replacements cannot publish another instance's results.
|
||||
|
||||
An authenticated POST selects a declaration by viewed Session, event sequence, and original file index. The event carries no owning Session ID; relative paths in inherited history resolve against the viewed Session's workspace. The Host rechecks canonical workspace containment and regular-file existence before native opening. Route disposal cancels and awaits pending commands. The “Files changed this turn” row lists successful file-tool mutations and retains its separate text-preview behavior. Its Chinese label is “本轮文件改动”; neither label implies final delivery.
|
||||
An authenticated POST selects a declaration by viewed Session, event sequence, and original file index. The event carries no owning Session ID; relative paths in inherited history resolve against the viewed Session's workspace. The Host rechecks canonical workspace containment and regular-file existence before native opening. Route disposal cancels and awaits pending commands. The “Files changed” row lists successful file-tool mutations and retains its separate text-preview behavior. Its Chinese label is “本轮文件改动”; neither label implies final delivery.
|
||||
|
||||
## Alternatives considered
|
||||
|
||||
|
||||
@@ -12,11 +12,11 @@ Status: implemented
|
||||
|
||||
[present 工具](../../../../packages/fs/tool-present/README.zh.md)声明交付调用方 Session 工作区中已存在的普通文件。它记录路径和可选说明，不读取或复制内容。[交付插件](../../../../packages/client/ui-deliverables/README.zh.md)使用 Host 默认应用打开当前工作区源文件。下次打开会看到编辑后的内容；删除或移动文件会使声明不可用。文件内容保留与写时复制存储延期到有持久化设计负责时实现。
|
||||
|
||||
工具说明要求在写好用户要求接收的文件后、最终回复前调用 `present`，包括通过 Bash 或代码执行创建的文件。正文中的路径引用不能替代调用。录制的 [SVG 交付场景](../../../../snapshots/web/present-svg/snapshot.yml)使用未提及 `present` 的用户请求，检查生成文件、交付事件和卡片。
|
||||
工具说明要求在写好用户要求接收的文件后、最终回复前调用 `present`，包括通过 Bash 或代码执行创建的文件。正文中的路径引用不能替代调用。录制的 [SVG 交付场景](../../../../snapshots/web/present-svg/snapshot.yml)使用未提及 `present` 的用户请求，检查生成文件、交付事件和卡片。其 UI 快照覆盖展开后的 Chat 对话内容；导航和输入框控件由各自场景负责，避免无关界面改动使文件交付预期失效。
|
||||
|
||||
工具保持为普通包，共享文件系统和工具错误类型。其纯类型入口拥有交付事件，不向浏览器导入 Host 代码。`standard`、`ptc` 与 `cordis` preset 挂载工具；`minimal` 保持两个工具。每个插件实例将其执行与成功的最终 `tools/result` 通知关联，再追加 `deliverables/presented`。原生与嵌套调用遵循同一规则。外层程序随后失败不会撤销已完成的嵌套声明；被阻止的结果不发布声明，同名作用域替换也不能发布其他实例的结果。
|
||||
|
||||
经过认证的 POST 按当前查看的 Session、事件序号和原始文件索引选择声明。事件不携带所属 Session ID；继承历史中的相对路径按当前查看的 Session 工作区解析。Host 在原生打开前重新检查规范路径的工作区包含关系和普通文件是否存在。路由释放时取消并等待进行中的命令。“本轮文件改动”行列出成功的文件工具修改，并保留独立的文本预览行为。其英文标签为“Files changed this turn”；两个标签均不表示最终交付。
|
||||
经过认证的 POST 按当前查看的 Session、事件序号和原始文件索引选择声明。事件不携带所属 Session ID；继承历史中的相对路径按当前查看的 Session 工作区解析。Host 在原生打开前重新检查规范路径的工作区包含关系和普通文件是否存在。路由释放时取消并等待进行中的命令。“本轮文件改动”行列出成功的文件工具修改，并保留独立的文本预览行为。其英文标签为“Files changed”；两个标签均不表示最终交付。
|
||||
|
||||
## 考虑过的替代方案
|
||||
|
||||
|
||||
@@ -114,7 +114,8 @@ describe('web e2e: requested SVG is explicitly delivered', () => {
|
||||
|
||||
it.skipIf(MODE === 'record')('replays the delivered file and Chinese conversation', async () => {
|
||||
await assertFinalWorkspaceSnapshot(DIR, cwd)
|
||||
const aria = await captureExpandedTurnProcessAria(page, '[class*="centerCol"]', scaffold.workspaceCwd)
|
||||
// Delivery owns the transcript; navigation and composer chrome have separate scenarios.
|
||||
const aria = await captureExpandedTurnProcessAria(page, '[data-chat-flow]', scaffold.workspaceCwd)
|
||||
await compareOrRefreshGolden(join(DIR, 'ui.expected.md'), aria, MODE)
|
||||
})
|
||||
})
|
||||
@@ -1,16 +1,3 @@
|
||||
- banner:
|
||||
- navigation "会话层级":
|
||||
- button "简单画一个 SVG 表示冯诺依曼" [disabled]
|
||||
- img
|
||||
- text: 标准模式
|
||||
- button "Session 日志":
|
||||
- text: Session 日志
|
||||
- img
|
||||
- button "展开侧栏":
|
||||
- img
|
||||
- tablist:
|
||||
- tab "对话" [selected]
|
||||
- tab "轨迹"
|
||||
- button "系统提示词":
|
||||
- img
|
||||
- img
|
||||
@@ -84,20 +71,3 @@
|
||||
- img
|
||||
- text: 用时 {{duration}}
|
||||
- text: {{clock}}
|
||||
- textbox "发消息或创建任务, / 调用指令, @ 文件或对话"
|
||||
- button "指令":
|
||||
- img
|
||||
- button "添加附件":
|
||||
- img
|
||||
- button "访问模式，当前：工作区内修改": 工作区内修改
|
||||
- button "选择模型，当前 DeepSeek-V4-Flash":
|
||||
- text: DeepSeek-V4-Flash
|
||||
- img
|
||||
- button "上下文已用 8%"
|
||||
- button "发送消息" [disabled]
|
||||
- button "1 轮 3 步 · {{throughput}} tok/s":
|
||||
- img
|
||||
- text: 1 轮 3 步{{throughput}} tok/s
|
||||
- button "32K tok · 缓存命中 75%":
|
||||
- img
|
||||
- text: 32K tok缓存命中 75%
|
||||
Reference in new issue
Block a user