Miles WardandClaude Opus 4.8
674a69f93b
Final cleanup before hardware testing. No behaviour changes; 248 tests green, clippy clean. #1 AppError newtype (http-api/src/error.rs) with one IntoResponse mapping (NotFound→404, Invalid→400, _→500) + From<core::Error>/From<io::Error>. Converted the clearly-safe handlers (sso_put, unattended_upload, branding_clear) to `?`; intentionally left handlers with bespoke status semantics (Invalid→404 on category, 409 on duplicate share / open upload) explicit so no asserted status changes. #2 figment-based Config::load (defaults → TOML → env). Keeps the historical flat OPENPXE_* names (Unraid/entrypoint compatible) AND adds the nested OPENPXE_SECTION__FIELD form; now covers every field (apply_env had silently skipped unattended_dir + bind addrs). 6 Jail tests prove backward-compat. Removed the hand-rolled apply_env. #3 thiserror 1→2; dropped unused mime/mime_guess/once_cell deps. #4 Re-evaluated: Duration::from_hours/from_mins are stable on the pinned 1.95 toolchain and clippy prefers them — kept the readable form (the "unstable" premise didn't hold; MSRV is intentionally 1.95). #5 insta snapshot of the rendered iPXE menu (version-filtered) + wiremock coverage of the SAML metadata-URL fetch (200 + non-2xx). #6 api_status → typed StatusResponse struct (was a 25-key json! blob) with a full_flow guard test asserting every UI key + the started_at string shape. Deferred the /api/docs typed conversion (lowest value, highest churn, zero functional benefit). #7 pct_encode/xml_escape de-duplicated into openpxe_core::encoding (were copied across app.rs + the SAML modules). No new crates. #8 UploadSessions registry → parking_lot::RwLock (sync, never held across .await); per-session lock stays tokio::Mutex. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
48 lines
1.5 KiB
TOML
48 lines
1.5 KiB
TOML
[package]
|
|
name = "openpxe-core"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
license.workspace = true
|
|
authors.workspace = true
|
|
description = "Shared types, config, and arch detection for OpenPXE"
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[dependencies]
|
|
serde.workspace = true
|
|
serde_json.workspace = true
|
|
toml.workspace = true
|
|
figment.workspace = true
|
|
thiserror.workspace = true
|
|
anyhow.workspace = true
|
|
tracing.workspace = true
|
|
tracing-subscriber.workspace = true
|
|
time.workspace = true
|
|
uuid.workspace = true
|
|
parking_lot.workspace = true
|
|
tokio = { workspace = true, features = ["sync", "rt", "macros", "time"] }
|
|
# bcrypt for the admin Forms auth (v0.4.5). Already in the workspace
|
|
# for per-ISO boot passwords; just re-exported here.
|
|
bcrypt.workspace = true
|
|
|
|
# v0.5.1: pure-Rust SAML 2.0 SP. bergshamra = XML-DSig verify + exclusive
|
|
# c14n (no OpenSSL/C). roxmltree/quick-xml parse + build SAML XML;
|
|
# x509-parser pulls the IdP signing cert out of metadata; flate2+base64
|
|
# encode the HTTP-Redirect binding's SAMLRequest.
|
|
bergshamra.workspace = true
|
|
roxmltree.workspace = true
|
|
quick-xml.workspace = true
|
|
x509-parser.workspace = true
|
|
flate2.workspace = true
|
|
base64.workspace = true
|
|
|
|
[dev-dependencies]
|
|
tempfile = "3.12"
|
|
# v0.5.4: figment's `Jail` (hermetic env/file sandbox) for the config
|
|
# loader tests lives behind the `test` feature.
|
|
figment = { workspace = true, features = ["test"] }
|
|
# v0.5.1: generate a throwaway self-signed signing cert/key so SAML
|
|
# verification tests can produce genuinely signed SAMLResponses.
|
|
rcgen = "0.13"
|