Files
deepseek-harness/apps/web/tests/present.e2e.ts
T
Turtle d1e22a7e24 feat(preset): declare Agent compositions in profile YAML (#4569)
* feat(preset): declare Agent compositions in profile YAML

* fix(preset): share scope binding cleanup and refresh module graph

* fix(preset): use host syntax colors in the YAML editor

* fix(preset): write new profile declarations as block YAML

* fix(preset): align eager activation with browser and worker surfaces

* fix(ui-agent-preset): retain the existing preset card layout

* fix(preset): keep rows waiting for a Host service mounted and re-audit after settlement

A preset row whose Host provider was still activating at declaration time
was reported as waiting for a missing service, and the registry recorded the
definition as broken for the rest of the process. Split the mount audit into
failed and pending rows: failures and root-realm leaks still reject the
mount, while pending rows stay mounted and every read and binding re-audits
them after the Host Loader tree settles.

Remove the accidental self-dependency of @deepseek-ai/dsh-web-app and its
lockfile self-link. Archive the copy-only preset authoring note, which the
declarative-preset note fully supersedes, and update the ralph note's
restore recipe to the profile-patch mechanism.

* chore(lint): re-key and prune the unknown-cast baseline after the master merge

* refactor(web-app): ship each Agent preset as its own bundle patch file

`dsh.bundle.patch` accepts an ordered file list, so the four shipped preset
declarations move out of the 1000-line web patch into
`presets/<id>.patch.yml`, one insert per file, applied after the host patch.
The host patch keeps the preset registry row. Gates and test scaffolds that
read the web layer resolve every patch file through `bundlePatchPaths`
instead of one hardcoded path.

* refactor(preset): drop the save notice injected into live Agents

The notice duplicated the save result the Web editor already shows, and
after the producer-owned message sources it would have needed its own
persisted source kind. Saving now only persists and reports the activation
diagnostic; the persistence catalog is unchanged from master.

* docs: regenerate the module graph after dropping the registry's llm dependency

* test(ui-agent-preset): cover the guide dialog's keyboard handling on the declarative section

* fix(preset): address the remaining review comments

Apply the lowercase id rule only when creating a declaration, so presets
declared with other ids stay editable. Export `isBuiltInPreset` from the
display fold and key the client card groups on it. Remove the dead `error`
and `retry` locale keys, the JSDoc orphaned by the `trust` removal, the
`trust` fields in the plugin-inventory test fixtures, and the stale
`dsh-agent-presets` package name in comments and READMEs.

* refactor(preset): make the Web preset page view-and-select only

Remove the child-plugin YAML editor, the `agent_preset` tool and the
registry's read/save Remote methods. Presets are declared and changed only by
bundle patches; the settings page keeps the roster, the new-task default and
the mode help, and its question icon explains that and offers to start a
Creator-mode task. The `editing-cordis-compositions` skill and the Creator
persona describe the bundle-based path, and the authored skill-load Session
and Web snapshots are refreshed for it.

* docs(skill): make the composition skill self-sufficient for preset authoring

State where the shipped declarations live, list every declaration field,
inline a complete minimal bundle and an override example, and name the
verification calls, so Creator mode no longer reads DSH package sources to
infer the format. Refresh the authored skill-load Session for the new text.

* test(tools): drop the removed agent_preset tool from the catalog expectation
2026-09-21 08:24:18 +00:00

296 lines
17 KiB
TypeScript

/** Recorded source-file delivery, edits, reload, deletion, and Session ZIP behavior. */
import { readFile, unlink, mkdir, mkdtemp, writeFile, rm, realpath } from 'node:fs/promises'
import { join, delimiter } from 'node:path'
import { fileURLToPath } from 'node:url'
import { chromium, type Browser, type Page } from 'playwright'
import { unzipSync, strFromU8 } from 'fflate'
import { afterAll, beforeAll, describe, expect, it, vi } from 'vitest'
import { tmpdir, release } from 'node:os'
import { createLaunchEnvironmentSnapshot } from '@deepseek-ai/dsh-launch-environment'
import type { SessionEvent, SessionId } from '@deepseek-ai/dsh-session'
import type {} from '@deepseek-ai/dsh-tool-present/types'
import {
acknowledgeReloadConnectionLoss, assertFinalWorkspaceSnapshot, captureExpandedTurnProcessAria,
compareOrRefreshGolden, fixtureUserPrompts, launchWebScaffold, recordFixture,
watchConsole, webSnapshotMode, type WebScaffold,
} from './scaffold.ts'
import { connectFreshWorkspace, newEnglishPage } from './support.ts'
const DIR = fileURLToPath(new URL('../../../snapshots/web/present', import.meta.url))
const FIXTURE = join(DIR, 'session.v3.jsonl')
const MODE = webSnapshotMode()
const PROMPT = 'Use one run_code program to do the following in order. Call present for missing.txt and catch its error without creating that file. '
+ 'Use bash to run exactly `printf "DELIVERED_REPORT\\n" > report.txt; printf "DELIVERED_NOTE\\n" > 说明.txt`. '
+ 'Call present for report.txt and 说明.txt. After present succeeds, deliberately throw the string "AFTER_PRESENT" (not an Error object) from that same run_code program. '
+ 'Do not retry the program or create any other files. Finish by mentioning `report.txt` and `说明.txt` in inline code, and put PRESENT_DONE in a separate paragraph.'
// The recorded Bash scenario and executable opener fixture require a POSIX host outside WSL.
describe.skipIf(process.platform === 'win32' || release().toLowerCase().includes('microsoft'))('web e2e: explicit file delivery', () => {
let scaffold: WebScaffold
let browser: Browser
let page: Page
let tripwire: ReturnType<typeof watchConsole>
let sessionId: SessionId
let cwd: string
let disposeApproval: (() => void) | undefined
const events: SessionEvent[] = []
let nativeRoot: string | undefined
let openLog: string
const opened = async (): Promise<Array<{ path: string; content: string | null; action: 'open' | 'reveal' }>> => (await readFile(openLog, 'utf8')).split('\n').filter(Boolean).map(line => JSON.parse(line) as { path: string; content: string | null; action: 'open' | 'reveal' })
const downloads: string[] = []
beforeAll(async () => {
nativeRoot = await mkdtemp(join(tmpdir(), 'dsh-present-native-'))
openLog = join(nativeRoot, 'opened.jsonl')
await writeFile(openLog, '')
// Exercise the built Host through its actual OS command, replacing only the desktop application.
const command = process.platform === 'darwin' ? 'open' : 'xdg-open'
await writeFile(join(nativeRoot, command), `#!${process.execPath}
const fs = require('node:fs');
const path = process.argv[2] === '-R' ? process.argv[3] : process.argv[2];
const action = process.argv[2] === '-R' || fs.statSync(path).isDirectory() ? 'reveal' : 'open';
fs.appendFileSync(${JSON.stringify(openLog)}, JSON.stringify({ path, action, content: action === 'open' ? fs.readFileSync(path, 'utf8') : null }) + '\\n');
`, { mode: 0o700 })
vi.stubEnv('PATH', `${nativeRoot}${delimiter}${process.env.PATH ?? ''}`)
await mkdir(DIR, { recursive: true })
scaffold = await launchWebScaffold({
openInAppEnvironment: createLaunchEnvironmentSnapshot([{ source: 'process', values: { SSH_CONNECTION: '10.0.0.2 55000 10.0.0.9 22' } }]),
extraOverlayPath: fileURLToPath(new URL('./present.overlay.yml', import.meta.url)),
agentPresets: { default: 'ptc' }, compareReplaySession: true,
...(MODE === 'record' ? {} : { replayFixture: FIXTURE }),
})
// File associations belong to the desktop rather than the recorded Session.
const controller = scaffold.ctx.get('sessionController')
if (controller === undefined) throw new Error('present requires Session Controller')
const nativeQuery: unknown = Reflect.get(controller, 'fileApplications')
if (typeof nativeQuery !== 'function') throw new Error('present requires native association discovery')
Reflect.set(controller, 'fileApplications', async () => [{ id: 'test-editor', name: 'Test Editor', default: true, icon: null }])
scaffold.ctx.effect(() => () => { Reflect.set(controller, 'fileApplications', nativeQuery) }, 'present: native association fixture')
disposeApproval = scaffold.ctx.on('approval/request', () => Promise.resolve('allowed-once'), { prepend: true })
scaffold.ctx.on('session/event', (_session, event) => { events.push(event) })
browser = await chromium.launch()
page = await newEnglishPage(browser)
tripwire = watchConsole(page)
page.on('download', (download) => { downloads.push(download.suggestedFilename()) })
await page.goto(scaffold.authenticatedUrl, { waitUntil: 'load' })
await page.waitForSelector('[class*="frame"]', { timeout: 30_000 })
await connectFreshWorkspace(page, scaffold.workspaceCwd)
}, 120_000)
afterAll(async () => {
try {
await browser?.close()
} finally {
disposeApproval?.()
try {
await scaffold?.close()
} finally {
vi.unstubAllEnvs()
if (nativeRoot !== undefined) await rm(nativeRoot, { recursive: true, force: true })
}
}
})
it('declares nested deliveries even when the enclosing program subsequently fails', async () => {
if (MODE !== 'record') expect(fixtureUserPrompts(await readFile(FIXTURE, 'utf8'))).toEqual([PROMPT])
const settled = scaffold.whenTurnSettled()
const input = page.locator('[data-composer-input]').first()
await input.fill(PROMPT)
await input.press('Enter')
sessionId = await settled
const workspace = scaffold.ctx.agents.get(sessionId)?.session.header.cwd
if (workspace === undefined) throw new Error('present Session has no workspace')
cwd = workspace
if (MODE === 'record') await recordFixture(scaffold, sessionId, FIXTURE)
await page.getByText(/^PRESENT_DONE\.?$/).waitFor({ timeout: 30_000 })
await assertFinalWorkspaceSnapshot(DIR, cwd)
expect(events.filter(event => event.type === 'deliverables/presented').flatMap(event => event.data.files.map(file => file.path)))
.toEqual(['report.txt', '说明.txt'])
for (const event of events) {
if (event.type === 'deliverables/presented') {
expect(event.data.files).toEqual([
{ path: 'report.txt', description: 'delivered report' },
{ path: '说明.txt', description: 'delivered note' },
])
}
}
expect(events.some(event => event.type === 'tool/ptc-dispatch' && event.data.name === 'present' && event.data.isError)).toBe(true)
expect(events.some(event => event.type === 'tool/result' && event.data.message.isError)).toBe(true)
}, 200_000)
it('opens current source files after edits and reload, and reports deletion without downloading', async () => {
await writeFile(join(cwd, 'report.txt'), 'EDITED_REPORT\n')
await writeFile(join(cwd, '说明.txt'), 'EDITED_NOTE\n')
for (const reload of [false, true]) {
if (reload) {
const warningStart = tripwire.warnings.length
await page.reload({ waitUntil: 'load' })
acknowledgeReloadConnectionLoss(tripwire, warningStart)
await page.getByText(/^PRESENT_DONE\.?$/).waitFor({ timeout: 30_000 })
}
const row = page.locator('[data-presented-files-row]')
await row.waitFor()
await expect.poll(() => row.getByRole('button', { name: 'More ways to open' }).count()).toBe(2)
expect(await row.getByText('report.txt', { exact: true }).innerText()).toBe('report.txt')
const card = row.locator('[data-presented-file]').filter({ hasText: 'report.txt' })
await card.getByRole('button', { name: 'Open in Test Editor', exact: true }).hover()
await page.getByRole('tooltip', { name: 'Open in Test Editor', exact: true }).waitFor()
expect(await page.getByRole('tooltip').evaluate((tooltip) => {
const rect = tooltip.getBoundingClientRect()
const previous = tooltip.style.pointerEvents
tooltip.style.pointerEvents = 'auto'
const visible = document.elementFromPoint(rect.left + rect.width / 2, rect.bottom - 1) === tooltip
tooltip.style.pointerEvents = previous
return tooltip.parentElement === document.body && visible
})).toBe(true)
await page.mouse.move(0, 0)
const beforePreview = (await opened()).length
const column = page.locator('[data-rightbar-col]')
for (const [name, content] of [['report.txt', 'EDITED_REPORT'], ['说明.txt', 'EDITED_NOTE']] as const) {
const mention = page.locator('code').getByRole('button', { name: `Open ${name} in sidebar`, exact: true })
await mention.click()
const preview = column.locator('[data-document-preview]')
await expect.poll(() => preview.getAttribute('data-textpreview-url'))
.toBe(`dsh-resource://file/session/${sessionId}/${encodeURIComponent(name)}`)
await preview.getByText(content, { exact: true }).waitFor()
await mention.click()
expect(await column.locator('[data-dockkit-tab]').filter({ hasText: name }).count()).toBe(1)
}
expect(await opened()).toHaveLength(beforePreview)
expect(downloads).toEqual([])
await page.getByRole('button', { name: 'Collapse right sidebar', exact: true }).click()
const beforeReveal = (await opened()).length
await row.locator('[data-presented-file]').filter({ hasText: 'report.txt' }).getByRole('button', { name: 'More ways to open', exact: true }).click()
const revealResponse = page.waitForResponse(response => response.url().includes('action=reveal') && response.request().method() === 'POST')
await page.getByRole('menuitem', { name: 'Show file location', exact: true }).click()
expect((await revealResponse).status()).toBe(204)
await expect.poll(opened).toHaveLength(beforeReveal + 1)
expect((await opened()).at(-1)).toEqual({ action: 'reveal', content: null, path: await realpath(process.platform === 'darwin' ? join(cwd, 'report.txt') : cwd) })
for (const [name, bytes] of [['report.txt', 'EDITED_REPORT\n'], ['说明.txt', 'EDITED_NOTE\n']] as const) {
const count = (await opened()).length
const response = page.waitForResponse(response => response.url().includes('/api/present.open?') && response.request().method() === 'POST')
await row.locator('[data-presented-file]').filter({ hasText: name }).getByRole('button', { name: 'Open in Test Editor', exact: true }).click()
expect((await response).status()).toBe(204)
await page.waitForFunction(() => document.querySelector('[data-presented-files-row] button:disabled') === null)
expect(await opened()).toHaveLength(count + 1)
expect((await opened()).at(-1)).toEqual({ action: 'open', path: await realpath(join(cwd, name)), content: bytes })
}
}
expect(downloads).toEqual([])
const response = await page.request.get(new URL(`/api/session.export?sessionId=${sessionId}`, scaffold.authenticatedUrl).href)
expect(response.status()).toBe(200)
const entries = unzipSync(await response.body())
expect(Object.keys(entries)).toHaveLength(1)
const exported = strFromU8(Object.values(entries)[0]!)
expect(exported).toContain('deliverables/presented')
const declarations = exported.trim().split('\n').map(line => JSON.parse(line) as SessionEvent)
.filter(event => event.type === 'deliverables/presented')
expect(declarations).toHaveLength(1)
expect(declarations[0]!.data.files).toEqual([
{ path: 'report.txt', description: 'delivered report' },
{ path: '说明.txt', description: 'delivered note' },
])
expect(exported).not.toContain('EDITED_REPORT')
if (MODE !== 'record') {
await expect.poll(() => page.locator('[data-presented-file] [role="status"]').count(), { timeout: 10_000 }).toBe(0)
const aria = await captureExpandedTurnProcessAria(page, '[class*="centerCol"]', scaffold.workspaceCwd)
await compareOrRefreshGolden(join(DIR, 'ui.expected.md'), aria, MODE)
await page.locator('[data-turn-process]').click()
const failed = page.locator('[data-tool="present"][data-state="error"]')
const delivered = page.locator('[data-tool="present"][data-state="ok"]')
expect(await failed.count()).toBe(1)
expect(await delivered.count()).toBe(1)
expect(await failed.innerText()).toContain('Delivery failed')
expect(await delivered.innerText()).toContain('Delivered')
await page.locator('[data-turn-process]').click()
const geometry = await page.evaluate(() => {
const requiredElement = <T extends Element>(value: T | null | undefined, name: string): T => {
if (value === null || value === undefined) throw new Error(`present layout is missing ${name}`)
return value
}
const answer = requiredElement(
[...document.querySelectorAll<HTMLElement>('[data-chat-flow-kind="assistant-step"]')]
.find(element => element.textContent?.includes('PRESENT_DONE')),
'final answer',
)
const presentedGrid = requiredElement(
document.querySelector<HTMLElement>('[data-presented-files-row]'),
'presented grid',
)
const presentedRoot = requiredElement(presentedGrid.parentElement, 'presented root')
const turnTail = requiredElement(presentedRoot.closest<HTMLElement>('[data-turn-tail]'), 'turn tail')
const actions = requiredElement(
turnTail.querySelector<HTMLButtonElement>('button[aria-label="Copy"]')?.parentElement,
'action row',
)
const cards = [...presentedGrid.querySelectorAll<HTMLElement>('[data-presented-file]')]
const report = requiredElement(
cards.find(card => card.textContent?.includes('report.txt')),
'report card',
)
const title = requiredElement(
report.querySelector<HTMLElement>('span[title="report.txt"]')
?? [...report.querySelectorAll<HTMLElement>('span')]
.find(element => element.textContent === 'report.txt'),
'report title',
)
const description = requiredElement(report.querySelector<HTMLElement>('[data-presented-description]'), 'report description')
const open = requiredElement(
report.querySelector<HTMLButtonElement>('[data-open-target] button'),
'report open action',
)
const icon = requiredElement(report.querySelector<SVGElement>('svg'), 'report icon')
const secondCard = requiredElement(cards[1], 'second card')
const answerRect = answer.getBoundingClientRect()
const presentedRect = presentedRoot.getBoundingClientRect()
const actionsRect = actions.getBoundingClientRect()
const firstCard = report.getBoundingClientRect()
const secondCardRect = secondCard.getBoundingClientRect()
const gridStyle = getComputedStyle(presentedGrid)
return {
answerToPresented: presentedRect.top - answerRect.bottom,
presentedToActions: actionsRect.top - presentedRect.bottom,
cardHeight: firstCard.height,
cardColumnGap: secondCardRect.left - firstCard.right,
gridColumnGap: gridStyle.columnGap,
gridRowGap: gridStyle.rowGap,
iconWidth: icon.getAttribute('width'),
titleFontSize: getComputedStyle(title).fontSize,
descriptionFontSize: getComputedStyle(description).fontSize,
openFontSize: getComputedStyle(open).fontSize,
}
})
expect(geometry.answerToPresented).toBeCloseTo(20, 1)
expect(geometry.presentedToActions).toBeCloseTo(20, 1)
expect(geometry.cardHeight).toBeCloseTo(60, 1)
expect(geometry.cardColumnGap).toBeCloseTo(10, 1)
expect(geometry.gridColumnGap).toBe('10px')
expect(geometry.gridRowGap).toBe('10px')
expect(geometry.iconWidth).toBe('20')
expect(geometry.titleFontSize).toBe('13px')
expect(geometry.descriptionFontSize).toBe('10px')
expect(geometry.openFontSize).toBe('11px')
await page.setViewportSize({ width: 480, height: 900 })
const row = page.locator('[data-presented-files-row]')
await row.scrollIntoViewIfNeeded()
for (const card of await row.getByRole('button').all()) {
const bounds = await card.boundingBox()
expect(bounds).not.toBeNull()
expect(bounds!.x).toBeGreaterThanOrEqual(0)
expect(bounds!.x + bounds!.width).toBeLessThanOrEqual(480)
}
}
const beforeDelete = (await opened()).length
await unlink(join(cwd, 'report.txt'))
const missing = page.waitForResponse(response => response.url().includes('/api/present.open?') && response.request().method() === 'POST')
await page.locator('[data-presented-file]').filter({ hasText: 'report.txt' })
.getByRole('button', { name: 'Open in Test Editor', exact: true }).click()
expect((await missing).status()).toBe(404)
await page.getByText('Could not open. Click to retry.', { exact: true }).waitFor()
expect(await opened()).toHaveLength(beforeDelete)
expect(downloads).toEqual([])
expect(tripwire.pageErrors).toEqual([])
expect(tripwire.warnings).toEqual([])
})
})