Yichen Jiang
cb2750019a
Review of #4539. A refusal pnpm view prints as JSON on stdout was read as unknown, so no registry was ever asked after a dead one; stderr and stdout are now read alike, and a lookup killed at its bound is a network refusal. pnpm's own registry joins the fallback plan only once pnpm config get registry names npm's own or a configured fallback, so a company registry in .npmrc is never followed by a public one, and a registry pnpm already names is asked once. The Host lays each failure at the registry or the spec's own host, reading the host off error lines only, and reports it as ChangeResult.failedAt; a stop that lands between attempts is cancelled, not failed. The package publishes its registry rule through ./registry so the dialog plans with the Host's own function, starts from the registry the Host asks first until one is remembered, tags that one as the default, labels pnpm's own by the host it names, and words and offers a change of registry from the Host's attribution. ERR_PNPM_NO_OFFLINE_META is no longer a network failure.
80 lines
5.8 KiB
TypeScript
80 lines
5.8 KiB
TypeScript
/** Reading install specs and classifying pnpm failures: pure, table-driven. */
|
|
|
|
import { describe, expect, it } from 'vitest'
|
|
import { classifyInstallFailure, InvalidInstallSpecError, parseInstallSpec } from '@deepseek-ai/dsh-plugin-manager'
|
|
|
|
describe('parseInstallSpec', () => {
|
|
it('reads registry names with an optional range, scoped or not', () => {
|
|
expect(parseInstallSpec(' dsh-better-sidebar ')).toEqual({ kind: 'registry', spec: 'dsh-better-sidebar', name: 'dsh-better-sidebar' })
|
|
expect(parseInstallSpec('@acme/dsh-tool@^1.2')).toEqual({ kind: 'registry', spec: '@acme/dsh-tool@^1.2', name: '@acme/dsh-tool', range: '^1.2' })
|
|
expect(parseInstallSpec('pkg@latest')).toEqual({ kind: 'registry', spec: 'pkg@latest', name: 'pkg', range: 'latest' })
|
|
})
|
|
|
|
it('reads absolute paths, with or without a file: or link: prefix, and tarballs on disk', () => {
|
|
expect(parseInstallSpec('/plugins/dsh-x')).toEqual({ kind: 'path', spec: '/plugins/dsh-x', path: '/plugins/dsh-x' })
|
|
expect(parseInstallSpec('file:/plugins/dsh-x')).toEqual({ kind: 'path', spec: 'file:/plugins/dsh-x', path: '/plugins/dsh-x' })
|
|
expect(parseInstallSpec('link:/plugins/dsh-x')).toEqual({ kind: 'path', spec: 'link:/plugins/dsh-x', path: '/plugins/dsh-x' })
|
|
expect(parseInstallSpec('/packs/dsh-x-1.0.0.tgz')).toEqual({ kind: 'tarball', spec: '/packs/dsh-x-1.0.0.tgz', path: '/packs/dsh-x-1.0.0.tgz' })
|
|
})
|
|
|
|
it('reads git hosts and tarball URLs, naming the host the spec itself is fetched from', () => {
|
|
const hosts: Record<string, string> = {
|
|
'github:someone/dsh-plugin': 'github.com', 'gitlab:a/b#main': 'gitlab.com', 'bitbucket:a/b': 'bitbucket.org', 'gist:0123abcd': 'gist.github.com',
|
|
'git+ssh://[email protected]/a/b.git': 'github.com', 'git://host/a/b': 'host', '[email protected]:a/b.git': 'github.com',
|
|
'https://github.com/a/b': 'github.com', 'https://github.com/a/b.git#v1': 'github.com', 'git+https://Git.Example.com:8443/a/b.git': 'git.example.com:8443',
|
|
}
|
|
for (const [spec, host] of Object.entries(hosts)) {
|
|
expect(parseInstallSpec(spec)).toEqual({ kind: 'git', spec, host })
|
|
}
|
|
expect(parseInstallSpec('https://cdn.example.com/x/y/z/dsh-x-1.0.0.tgz')).toEqual({ kind: 'tarball', spec: 'https://cdn.example.com/x/y/z/dsh-x-1.0.0.tgz', host: 'cdn.example.com' })
|
|
})
|
|
|
|
it('refuses what neither the registry nor pnpm would take, naming why', () => {
|
|
const refusal = (spec: string): string => {
|
|
try {
|
|
parseInstallSpec(spec)
|
|
} catch (error) {
|
|
expect(error).toBeInstanceOf(InvalidInstallSpecError)
|
|
const failure = error as InvalidInstallSpecError
|
|
expect(failure.spec).toBe(spec.trim())
|
|
expect(failure.message).toBe(`plugin-manager: ${failure.reason}: ${spec.trim()}`)
|
|
return failure.reason
|
|
}
|
|
throw new Error(`${spec} was accepted`)
|
|
}
|
|
expect(refusal(' ')).toBe('the package spec must not be empty')
|
|
expect(refusal('./dsh-x')).toBe('a local path must be absolute')
|
|
expect(refusal('../dsh-x')).toBe('a local path must be absolute')
|
|
expect(refusal('file:./dsh-x')).toBe('a local path must be absolute')
|
|
expect(refusal('https://example.com/not-a-package')).toBe('a URL must point at a git repository or a tarball')
|
|
expect(refusal('Dsh-Upper')).toBe('not a package name the registry accepts')
|
|
expect(refusal('.hidden')).toBe('not a package name the registry accepts')
|
|
expect(refusal('has space')).toBe('not a package name the registry accepts')
|
|
expect(refusal('a'.repeat(215))).toBe('not a package name the registry accepts')
|
|
expect(refusal('pkg@')).toBe('a version after @ must not be empty')
|
|
})
|
|
})
|
|
|
|
describe('classifyInstallFailure', () => {
|
|
it('names the run\'s end before reading its output, then the most specific code in the output', () => {
|
|
expect(classifyInstallFailure({ log: 'ENOSPC', timedOut: true })).toBe('timeout')
|
|
expect(classifyInstallFailure({ log: '', cause: Object.assign(new Error('spawn pnpm ENOENT'), { code: 'ENOENT' }) })).toBe('pnpm-missing')
|
|
expect(classifyInstallFailure({ log: 'ERR_PNPM_IGNORED_BUILDS Ignored build scripts: node-pty' })).toBe('build-blocked')
|
|
expect(classifyInstallFailure({ log: 'npm error code E404\nnpm error 404 Not Found - GET https://registry/x' })).toBe('not-found')
|
|
expect(classifyInstallFailure({ log: 'ERR_PNPM_NO_MATCHING_VERSION No matching version found for x@9' })).toBe('no-matching-version')
|
|
expect(classifyInstallFailure({ log: 'npm error code ETARGET' })).toBe('no-matching-version')
|
|
expect(classifyInstallFailure({ log: 'ENOSPC: no space left on device, write' })).toBe('disk-full')
|
|
expect(classifyInstallFailure({ log: 'EACCES: permission denied, mkdir' })).toBe('permission')
|
|
expect(classifyInstallFailure({ log: 'ERR_PNPM_TARBALL_INTEGRITY Got sha512-...' })).toBe('integrity')
|
|
expect(classifyInstallFailure({ log: 'ERR_PNPM_META_FETCH_FAIL GET https://registry/x: request to https://registry/x failed, reason: getaddrinfo ENOTFOUND registry' })).toBe('network')
|
|
expect(classifyInstallFailure({ log: 'ECONNRESET' })).toBe('network')
|
|
expect(classifyInstallFailure({ log: 'ERR_PNPM_FETCH_502 GET https://registry/x: Bad Gateway' })).toBe('network')
|
|
expect(classifyInstallFailure({ log: 'fatal: unable to access https://github.com/a/b/: Could not resolve host' })).toBe('network')
|
|
// An offline cache miss is no registry's failure, so it is not one another registry could change.
|
|
expect(classifyInstallFailure({ log: 'ERR_PNPM_NO_OFFLINE_META Failed to resolve x@1 in package mirror' })).toBe('unknown')
|
|
expect(classifyInstallFailure({ log: 'npm error code FETCH_ERROR\nnpm error errno FETCH_ERROR' })).toBe('network')
|
|
expect(classifyInstallFailure({ log: 'exited with 1', cause: new Error('no code') })).toBe('unknown')
|
|
expect(classifyInstallFailure({ log: '' })).toBe('unknown')
|
|
})
|
|
})
|