Tianyi Cui
cbf618845a
Cancelling during the prompt's initial whenIdle() wait could retain its slot indefinitely. If a child delivered a result while the aborted root was unwinding, Agent.whenIdle() followed the replacement driver and waited for the newly autonomous summary. The earlier child-wait recheck could not help because settlement had not yet reached that child wait. This is an inherited latent issue: the pre-PR ACP bridge also awaited the same replacement-following whenIdle() after cancellation. Existing continuable spawn children could expose it; the unified asynchronous fork default makes the ordering possible for fork delegations as well. Give the existing InflightPrompt one cancellation-completion promise, replacing the local cancellation wake-up and its listener. The private admission AbortSignal is the cancellation flag instead of duplicated boolean state. The exact root's emitted status identifies the interrupted activity's retirement and synchronously adopts that output queue. Later root work and later output cannot replace the first captured completion. Record whether cancellation began at public idle. Maintenance has that public status too, so its next running transition establishes release of work behind maintenance; the ordinary whenIdle promise provides a fallback when no transition occurs or plugin disposal detaches observers. Both observations settle the same promise. Settlement races that promise against initial idle and child waits, then waits only for the interrupted activity/output on the cancellation path. No future work is re-cancelled, child admission remains open, and session close keeps its separate full quiescence and descendant teardown. Add two deterministic real-Agent regressions. One gates aborted model cleanup, previously queued image delivery, and the later autonomous summary independently. The other gates cancelled maintenance cleanup and the later summary. Both failed before this fix; both now wait for old work and output, return cancelled while later work remains gated, and permit a subsequent ACP prompt to execute another real local delegation. Existing plugin-disposal tests also verify the idle fallback after observer cutoff. Update the bilingual ACP semantics and generated event-consumer matrix. Validation: - Both focused regressions reproduced pending cancellation before the fix. - pnpm exec vitest run packages/acp/acp/tests --coverage --coverage.include=packages/acp/acp/src/session.ts --coverage.include=packages/acp/acp/src/index.ts --coverage.reportsDirectory=/tmp/pr4394-acp-owned-cancel-89ec33e5788-consumer-v2 (150 passed; both changed source files have 100% statements, branches, functions, and lines) - pnpm exec tsc -b packages/acp/acp/tsconfig.json - pnpm exec tsdown --config-loader native --env.DSH_BUILD_FACE host --filter '@deepseek-ai/dsh-acp' - DSH_EXAMPLE_MODE=lib pnpm run test:e2e packages/subagent/subagent-dsh-sdk/tests/nested-delegation.e2e.ts -t '^external tasks.*acp' (3 passed, 3 unselected) - Focused lint, named translation pairing, generated graph verification, and git diff --check passed. Independent ACP rereview found no remaining issue, passed seven focused turn/disposal cases, and verified a prepended idle listener can start a new hanging root before ACP handles the old idle event without retaining the cancelled prompt.
description, kind
| description | kind |
|---|---|
| The DeepSeek Harness package workspace: how the npm packages under packages/ are grouped, what each group owns, and the conventions that bind them. | package-group |
Packages
English | 中文
Summary
The harness is assembled from npm packages under packages/, grouped by capability family: sessions and the agent loop, model-facing tools, shell and filesystem execution, web access, subagents, and the rest. Use this page as the top-level map: find the owning group, then open its README for the package list. Every package is scoped @deepseek-ai/dsh-* and lives in exactly one group; each group README is the authoritative package map for its family.
Table of Contents
Package groups
Every package lives in exactly one group; new packages join existing groups, and a new group updates its own README and this table.
| Group | Role |
|---|---|
core/ |
Product API spine: sessions, prompts, tools, agent services, and the concrete loop |
api/ |
Remote BFF assembly and Typert RPC gateway |
typert/ |
Type graph generation, artifact loading, and runtime registry |
goal/ |
Same-session goal persistence and lifecycle |
schedule/ |
Host-owned scheduled follow-ups |
feedback/ |
Human feedback capture and command |
telemetry/ |
Shared Cordis OTel reporting channels |
identity/ |
Shared anonymous identity |
llm/ |
LLM capability family: abstract service + provider adapters |
subprocess/ |
Subprocess capability family: Service Definition + local process-tree provider |
ssh/ |
POSIX remote connection with paired filesystem, subprocess and sandbox providers |
shell/ |
Bash capability family: executor seam, local impl, model-facing tools |
terminal/ |
Persistent PTY capability family: owner-scoped sessions, local implementation, model-facing tools |
ptc-runtime/ |
PTC execution capability family: Service Definition + sandboxed Node provider + PTC mode Consumer |
computer-use/ |
Exclusive named desktop-provider registration |
browser-use/ |
Exclusive named browser-provider registration |
sandbox/ |
Process-confinement seam; bwrap/Landlock/Seatbelt backends |
deliverables/ |
Turn deliverables: explicit file delivery and recorded workspace changes |
fs/ |
Filesystem capability family: seam, local impl, model-facing file tools, discovery tools |
lsp/ |
LSP capability family: seam, generic stdio provider, and the lsp tool |
skill/ |
Skill capability family: provider registry, local provider, model-facing catalog/loader |
compaction/ |
Compaction capability family: Service Definition + basic provider + command Consumer |
context/ |
Model-visible request context: workspace instructions, time context, references |
subagent/ |
Subagent capability family: provider-registry contract and model-facing delegation tools |
jobs/ |
Generic background-job runtime and model-facing job control tools |
experimental/ |
Pre-stable prototypes with explicit private exceptions |
workflow/ |
Workflow seam, PTC process engine, and model-facing workflow/ralph tools |
webhook/ |
Verified external events, trusted rules, and fire-and-forget Workspace Sessions |
web/ |
Web capability family: seam, search/fetch providers, model-facing web tools |
document/ |
Shared Host Office-to-PDF conversion |
attachment/ |
Durable attachment identity, validation, local content-addressed storage |
spill/ |
Spill capability family: storage seam, local impl, tool-result spill policy |
todo/ |
The model-facing todo_write tool |
plan/ |
Plan collaboration state with a direct entry command and reviewed exit |
preset/ |
Per-session agent composition from preset cordis.yml files |
guard/ |
Loop-hygiene guards: advisory repeat-call reminders + the tools/execute deadline enforcer |
bundle/ |
Installable dsh --profile patch layers |
extensions/ |
Agent runtime self-modification: live plugin/service inspection and model-written mount/unmount |
mcp/ |
External Model Context Protocol servers exposed as native tools |
hooks/ |
Hook bridges + the shared Claude Code / Codex wire-protocol library |
session/ |
Durable session data plane: persistence seam + backends, projection seam, log-backed titles, session reporting |
session-query/ |
Session retrieval family: logical corpus, bounded reads, lineage, semantic filtering, SQLite full-text search |
settings/ |
User-settings seam + file-backed provider |
credentials/ |
Credential-reference and credential-record seam + env-over-.env provider + authorization flows that ask a human |
storage/ |
Non-session storage hub + backends + domain form |
workspace/ |
Workspace entity |
sdk/ |
Out-of-process SDK: JSON-RPC protocol and TypeScript client/server |
acp/ |
Automation-only Agent Client Protocol server |
interaction/ |
Human-collaboration plane: approval/interaction seams, permission preset, commands, ask-user tool |
boot/ |
Shared app-bin boot glue |
host/ |
Web GUI host services, directory picking, application launch, plugin inventory, and product telemetry |
client/ |
Web-GUI browser half: shell, wire, object services, slots, ui-* plugins |
test-support/ |
Test infrastructure (testkits, replay, Loader smokes) |
util/ |
Low-level zero-dependency utilities shared across groups (Branded<B>, home/path helpers, timeout, retention) |
Release expectations
Most groups are product — stable API. The exceptions: experimental/ publishes without stability or support promises, and test-support/ and util/ are support with lower compatibility expectations.
Dependencies
The dependency graph is generated: docs/module-graph.md (pnpm run gen-module-graph, freshness-gated in CI).
Extension plugins depend on Service Definitions, never concrete providers. dsh-agent-loop is swappable; UI, hook, and tool plugins use dsh-agent. Composition bundles may depend on spine plugins. Capabilities separate Service Definition / Service Provider / Consumer roles when they evolve independently; see capability seams.
Package README contracts
Every package README covers purpose, configuration, extension points, and Model Experience unless the model-agnostic omission allowlist exempts it. It also carries ## Known Limitations and Deferred Work or uses its allowlist. Package conventions — exports, service access, tests — live in packages/AGENTS.md.
Dev Note
Working context for maintainers — click to expand
None.