deepseek-harness/packages/workflow/workflow-ptc/tests/host.spec.ts

import { setSandboxMode } from '@deepseek-ai/dsh-sandbox-policy'
import { provideWorkingDirectoryFixture } from '@deepseek-ai/dsh-agent-loop-testkit'
import { Context } from '@deepseek-ai/cordis'
import AgentRegistry from '@deepseek-ai/dsh-agent'
import { PtcRuntime } from '@deepseek-ai/dsh-ptc-runtime'
import type { PtcBindingFunction, PtcRunRequest, PtcRunResult, PtcRunSpec } from '@deepseek-ai/dsh-ptc-runtime'
import SessionStore, { SessionId } from '@deepseek-ai/dsh-session'
import SessionProjections from '@deepseek-ai/dsh-session-projection'
import SandboxPolicy from '@deepseek-ai/dsh-sandbox-policy'
import SubagentRuntime from '@deepseek-ai/dsh-subagent'
import type { SubagentActivation, SubagentResult } from '@deepseek-ai/dsh-subagent'
import { describe, expect, it, onTestFinished, vi } from 'vitest'
import PtcWorkflowEngine from '../src/index.ts'
import { fakeParent } from './setup.ts'

const completed: PtcRunResult = { logs: [], value: { value: null, stopReason: 'completed', agentsStarted: 0 } }
type HostBindings = Record<string, PtcBindingFunction>

class ControlledRuntime extends PtcRuntime {
  language = 'typescript'
  readonly isolation = 'process'
  policyMode: 'read-only' | undefined = 'read-only'
  override get sandboxMode(): 'read-only' | undefined { return this.policyMode }
  execute: (spec: PtcRunSpec) => Promise<PtcRunResult> = () => Promise.resolve(completed)

  resolve(request: PtcRunRequest): PtcRunSpec {
    return { ...request, cwd: request.cwd ?? process.cwd(), timeoutMs: request.timeoutMs === undefined ? 120_000 : request.timeoutMs }
  }

  run(spec: PtcRunSpec): Promise<PtcRunResult> { return this.execute(spec) }
}

async function setup(execute?: (bindings: HostBindings, spec: PtcRunSpec) => Promise<PtcRunResult>, language = 'typescript') {
  const ctx = new Context()
  onTestFinished(async () => { await ctx.fiber.dispose() })
  await ctx.plugin(SessionStore)
  await ctx.plugin(SessionProjections)
  await ctx.plugin(AgentRegistry)
  await ctx.plugin(SandboxPolicy, { mode: 'read-only' })
  provideWorkingDirectoryFixture(ctx)
  await ctx.plugin(SubagentRuntime)
  ctx.subagents.registerProvider({
    name: 'stub',
    capabilities: { agentOptions: true, agentPreset: false, outputSchema: true, depthLimit: false },
    inheritsParentContext: false,
    start: async () => ({
      id: SessionId('host-child'),
      result: Promise.resolve({ output: [], stopReason: 'completed' }),
      dispose: () => Promise.resolve(),
    }),
  })
  await ctx.plugin(ControlledRuntime)
  const runtime = ctx.ptcRuntime as ControlledRuntime
  runtime.language = language
  if (execute !== undefined) runtime.execute = spec => execute(spec.bindings[0]!.functions, spec)
  await ctx.plugin(PtcWorkflowEngine, { provider: 'stub' })
  const parent = await fakeParent(ctx)
  const start = () => ctx.workflowEngine.start({
    script: 'return null', meta: { name: 'host-test', description: 'workflow callbacks' }, parent,
  })
  return { ctx, runtime, start, parent }
}

describe('workflow host callback validation', () => {
  it('runs an unconfined provider under full access without forwarding a sandbox policy', async () => {
    const { runtime, parent, start } = await setup(async (_bindings, spec) => {
      expect(spec.sandboxPolicy).toBeUndefined()
      return completed
    })
    runtime.policyMode = undefined
    setSandboxMode(parent.session, 'danger-full-access')
    const handle = start()
    try {
      expect(await handle.result).toEqual({ value: null, stopReason: 'completed', agentsStarted: 0 })
    } finally { await handle.dispose() }
  })

  it('settles a failed directory lookup when the runtime cannot confine execution', async () => {
    const { ctx, runtime, start } = await setup()
    runtime.policyMode = undefined
    const ensureDirectory = vi.spyOn(ctx.workingDirectory, 'ensure').mockRejectedValue(new Error('selected directory is unavailable'))
    const execute = vi.spyOn(runtime, 'run')
    const run = start()
    try {
      const result = await run.result
      expect(result.stopReason).toBe('error')
      expect(result.error).toContain('selected directory is unavailable')
      expect(execute).not.toHaveBeenCalled()
    } finally {
      await run.dispose()
      ensureDirectory.mockRestore()
      execute.mockRestore()
    }
  })

  it('retains its selected directory for the process and later children when the parent moves', async () => {
    const entered = Promise.withResolvers<undefined>()
    const release = Promise.withResolvers<undefined>()
    let launched: PtcRunSpec | undefined
    const { ctx, start, parent } = await setup(async (bindings, spec) => {
      launched = spec
      entered.resolve(undefined)
      await release.promise
      await bindings.startChild!({ prompt: 'child' })
      return completed
    })
    const initial = `${process.cwd()}/selected`
    const ensureDirectory = vi.spyOn(ctx.workingDirectory, 'ensure').mockResolvedValue(initial)
    const childStart = vi.spyOn(ctx.subagents, 'startActivation')
    const run = start()
    try {
      await entered.promise
      ensureDirectory.mockResolvedValue(`${process.cwd()}/later`)
      release.resolve(undefined)
      expect((await run.result).stopReason).toBe('completed')
      expect(launched?.cwd).toBe(initial)
      expect(launched?.sandboxPolicy?.workspaceRoot).toBe(parent.session.header.cwd)
      expect(childStart).toHaveBeenCalledOnce()
      const selected = childStart.mock.calls[0]![0]
      expect(selected.provider).toBe('stub')
      expect(selected.cwd).toBe(initial)
      expect(ensureDirectory).toHaveBeenCalledOnce()
    } finally {
      release.resolve(undefined)
      await run.dispose()
    }
  })
  it.each([
    ['startChild', null, 'requires an object'],
    ['startChild', [], 'requires an object'],
    ['startChild', { prompt: 7 }, 'prompt must be a string'],
    ['startChild', { prompt: 'p', provider: 7 }, 'provider must be a string'],
    ['startChild', { prompt: 'p', model: false }, 'model must be a string'],
    ['progress', {}, 'requires an array of events'],
    ['progress', [{ type: 'phase', title: null }], 'phase must be a string'],
    ['progress', [{ type: 'agent-start', info: { seq: 0 } }], 'sequence must be a positive integer'],
    ['progress', [{ type: 'agent-end', info: { outcome: 'unknown' } }], 'invalid workflow agent outcome'],
    ['progress', [{ type: 'unknown' }], 'invalid workflow progress event'],
    ['childResult', { callId: '1' }, 'call id must be an integer'],
    ['disposeChild', { callId: 99 }, 'child call is not active'],
  ] as const)('rejects malformed %s callback data %j', async (name, input, message) => {
    const { start } = await setup(async (bindings) => {
      await expect(Promise.resolve().then(() => bindings[name]!(input))).rejects.toThrow(message)
      return completed
    })
    const handle = start()
    try { expect((await handle.result).stopReason).toBe('completed') }
    finally { await handle.dispose() }
  })

  it('does not emit duplicate agent-end notifications', async () => {
    const info = { seq: 1, label: 'child', childId: 'host-child' }
    const { ctx, start } = await setup(async (bindings) => {
      await bindings.progress!([{ type: 'agent-start', info }])
      await bindings.progress!([{ type: 'agent-end', info: { ...info, outcome: 'failed' } }])
      await bindings.progress!([{ type: 'agent-end', info: { ...info, outcome: 'cancelled' } }])
      return completed
    })
    const ended = vi.fn()
    ctx.on('workflow/agent-end', ended)
    const handle = start()
    try {
      expect((await handle.result).stopReason).toBe('completed')
      expect(ended).toHaveBeenCalledOnce()
    } finally { await handle.dispose() }
  })

  it.each([true, false])('carries Session cwd and an unlimited deadline with confinement capability %s', async (confined) => {
    const { ctx, runtime, parent, start } = await setup(async (bindings, spec) => {
      expect(spec.timeoutMs).toBeNull()
      expect(spec.cwd).toBe(parent.session.header.cwd)
      expect(spec.sandboxPolicy).toEqual(confined ? ctx.sandboxPolicy.resolve({ session: parent.session }) : undefined)
      expect(await bindings.begin!({})).toMatchObject({ body: 'return null', meta: { name: 'host-test' } })
      return completed
    })
    runtime.policyMode = confined ? 'read-only' : undefined
    const handle = start()
    try {
      const result = await handle.result
      expect(result.stopReason, result.error).toBe(confined ? 'completed' : 'error')
      if (!confined) expect(result.error).toContain('cannot enforce the read-only file policy')
    } finally { await handle.dispose() }
  })
})

describe('workflow runtime outcomes', () => {
  it('collects child results without parent delivery and waits for child cleanup before settling', async () => {
    const disposing = Promise.withResolvers<undefined>()
    const released = Promise.withResolvers<undefined>()
    const schema = { type: 'object' as const, properties: { answer: { type: 'number' as const } } }
    const { ctx, parent, start } = await setup(async (bindings) => {
      const child = await bindings.startChild!({ prompt: 'answer', schema, model: 'selected' })
      expect(child).toEqual({ callId: 1, childId: 'ready-child' })
      expect(await bindings.childResult!(child)).toEqual({ output: [], structured: { answer: 42 }, stopReason: 'completed' })
      await bindings.disposeChild!(child)
      return completed
    })
    const activation = vi.spyOn(ctx.subagents, 'startActivation').mockResolvedValue({
      childId: SessionId('ready-child'), name: 'ready-child',
      result: Promise.resolve({ output: [], structured: { answer: 42 }, stopReason: 'completed' }),
      dispose: () => { disposing.resolve(undefined); return released.promise },
    })
    const run = start()
    let settled = false
    void run.result.then(() => { settled = true })
    try {
      await disposing.promise
      expect(settled).toBe(false)
      expect(activation).toHaveBeenCalledOnce()
      const { signal, parent: delegatedParent, ...delegation } = activation.mock.calls[0]![0]
      expect(signal).toBeInstanceOf(AbortSignal)
      expect(delegatedParent).toBe(parent)
      expect(delegation).toEqual({
        provider: 'stub', label: 'host-test child 1', delivery: 'caller',
        cwd: ctx.workingDirectory.get(parent.session),
        prompt: [{ type: 'text', text: 'answer' }], outputSchema: schema, agentOptions: { model: 'selected' },
      })
      released.resolve(undefined)
      await expect(run.result).resolves.toMatchObject({ stopReason: 'completed' })
    } finally {
      released.resolve(undefined)
      await run.dispose()
    }
  })

  it.each([
    [null, 'requires an object'],
    [{ value: null, stopReason: 'unknown', agentsStarted: 0 }, 'invalid workflow stop reason'],
    [{ value: null, stopReason: 'cancelled', agentsStarted: -1 }, 'invalid workflow agent count'],
    [{ stopReason: 'completed', agentsStarted: 0 }, 'missing its value'],
    [{ value: null, stopReason: 'error', agentsStarted: 0, error: 5 }, 'error must be a string'],
  ] as const)('maps an invalid terminal result %j to a workflow error', async (value, message) => {
    const { start } = await setup(() => Promise.resolve({ logs: [], value }))
    const handle = start()
    try {
      const result = await handle.result
      expect(result.stopReason).toBe('error')
      expect(result.error).toContain(message)
    } finally { await handle.dispose() }
  })

  it('preserves cancellation when the runtime rejects during cancellation', async () => {
    const entered = Promise.withResolvers<undefined>()
    const failure = Promise.withResolvers<PtcRunResult>()
    const { start } = await setup(() => { entered.resolve(undefined); return failure.promise })
    const handle = start()
    try {
      await entered.promise
      handle.cancel('stop requested')
      failure.reject(new Error('execution provider failed while stopping'))
      const result = await handle.result
      expect(result.stopReason).toBe('cancelled')
      expect(result.error).toContain('stop requested')
    } finally {
      failure.reject(new Error('test cleanup'))
      await handle.dispose()
    }
  })

  it('rejects a non-TypeScript runtime while loading the workflow provider', async () => {
    await expect(setup(undefined, 'python')).rejects.toThrow('requires the Node TypeScript PTC runtime')
  })

  it('disposes a child published after workflow cancellation', async () => {
    const entered = Promise.withResolvers<undefined>()
    const publication = Promise.withResolvers<SubagentActivation>()
    const disposed = vi.fn(() => Promise.resolve())
    const { ctx, start } = await setup(async (bindings) => {
      await expect(bindings.startChild!({ prompt: 'child' })).rejects.toThrow('workflow child started after cancellation')
      return completed
    })
    vi.spyOn(ctx.subagents, 'startActivation').mockImplementation(() => {
      entered.resolve(undefined)
      return publication.promise
    })
    const child: SubagentActivation = {
      childId: SessionId('late-child'), name: 'late-child',
      result: Promise.resolve({ output: [], stopReason: 'aborted' }),
      dispose: disposed,
    }
    const handle = start()
    try {
      await entered.promise
      handle.cancel('stop during child startup')
      publication.resolve(child)
      expect((await handle.result).stopReason).toBe('cancelled')
      expect(disposed).toHaveBeenCalledOnce()
    } finally {
      publication.resolve(child)
      await handle.dispose()
    }
  })

  it('stops waiting for child output after disposal releases the child resources', async () => {
    const childResult = Promise.withResolvers<SubagentResult>()
    const disposed = vi.fn(() => Promise.resolve())
    let outputWait: Promise<unknown> | undefined
    const { ctx, start } = await setup(async (bindings) => {
      const child = await bindings.startChild!({ prompt: 'child' })
      outputWait = bindings.childResult!(child)
      void outputWait.catch(() => {})
      return completed
    })
    vi.spyOn(ctx.subagents, 'startActivation').mockResolvedValue({
      childId: SessionId('output-pending'), name: 'output-pending', result: childResult.promise, dispose: disposed,
    })
    const handle = start()
    let settled = false
    void handle.result.then(() => { settled = true })
    try {
      await new Promise(resolve => setImmediate(resolve))
      expect(settled).toBe(true)
      expect(disposed).toHaveBeenCalledOnce()
      await expect(outputWait).rejects.toBe('workflow settled')
      expect((await handle.result).stopReason).toBe('completed')
    } finally {
      childResult.resolve({ output: [], stopReason: 'aborted' })
      await handle.dispose()
    }
  })
})