Yichen Jiang
4d01598a26
# Conflicts: # packages/experimental/client-ui-forge/README.i18n.yaml # packages/experimental/client-ui-forge/README.md # packages/experimental/client-ui-forge/README.zh.md # packages/experimental/client-ui-forge/src/client/ChangesTab.tsx # packages/experimental/client-ui-forge/src/client/DiffFile.tsx # packages/experimental/client-ui-forge/src/client/ReviewThread.tsx
2285 lines
147 KiB
TypeScript
2285 lines
147 KiB
TypeScript
/** Worktree Sessions and the change request panel through the real optional bundle, a Git checkout, and a scripted GitHub CLI. */
|
||
import { execFile } from 'node:child_process'
|
||
import { existsSync } from 'node:fs'
|
||
import { access, chmod, mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises'
|
||
import { homedir, tmpdir } from 'node:os'
|
||
import { basename, join } from 'node:path'
|
||
import { fileURLToPath } from 'node:url'
|
||
import { promisify } from 'node:util'
|
||
import type {} from '@deepseek-ai/dsh-experimental-forge-session'
|
||
import { pluginRecordOf, type SessionEvent } from '@deepseek-ai/dsh-session'
|
||
import type { SessionId } from '@deepseek-ai/dsh-session/types'
|
||
import { initialShortcutConfig, type DesktopShortcutInput, type ShortcutRevision } from '@deepseek-ai/dsh-client-shortcuts/protocol'
|
||
import { abbreviateHomePath } from '@deepseek-ai/dsh-util-workspace-path'
|
||
import { chromium, type Browser, type Locator, type Page } from 'playwright'
|
||
import { expect, it, onTestFailed, onTestFinished } from 'vitest'
|
||
import {
|
||
captureStableAria, compareOrRefreshGolden, fixtureUserPrompts, launchWebScaffold, readPersistedEvents, watchConsole,
|
||
webSnapshotMode, type WebScaffold,
|
||
} from './scaffold.ts'
|
||
import { connectFreshWorkspaceZh, saveFailureShot, writeComposerDraft, ZH_BROWSER_LOCALE } from './support.ts'
|
||
|
||
declare global {
|
||
interface Window {
|
||
forgeKeyboard: { readonly revision: ShortcutRevision; deliver(input: DesktopShortcutInput): void }
|
||
}
|
||
}
|
||
|
||
const BUNDLE = fileURLToPath(new URL('../../../packages/experimental/forge-bundle', import.meta.url))
|
||
const FIXTURE = fileURLToPath(new URL('../../../snapshots/web/lifecycle-chrome/session.v4.jsonl', import.meta.url))
|
||
const EXPECTED = fileURLToPath(new URL('./expected/forge-panel', import.meta.url))
|
||
const MODE = webSnapshotMode()
|
||
const PULL = 'https://github.com/octo/demo/pull/7'
|
||
/** A draft change request that the double lets the panel mark ready and merge. */
|
||
const DRAFT = 'https://github.com/octo/demo/pull/9'
|
||
/** Message sent after the worktree is removed, which waits until the worktree is restored. */
|
||
const FOLLOW_UP = 'Summarize the failed check'
|
||
/** Reply to {@link FOLLOW_UP}, a model call appended after the borrowed scenario's single one. */
|
||
const FOLLOW_UP_REPLY = 'RESTORED'
|
||
const run = promisify(execFile)
|
||
|
||
/**
|
||
* GitHub CLI double: signed in to github.com, with octo/demo allowing every
|
||
* merge method and the viewer's usual one squash. GraphQL serves pull request
|
||
* 7 with one failed and one passed check run, one unresolved thread, and a
|
||
* required review, and pull request 9, an approved draft whose checks passed.
|
||
* `gh pr ready 9` and the REST merge of pull request 9 change what later
|
||
* queries report, through `state.json`, which can also move the head of pull
|
||
* request 9. The compare API serves `compare.json`, keyed by `base...head`, and
|
||
* otherwise, between a pull request's recorded base and its head, prints
|
||
* `pr-N.diff`, or, when `pr-N.refused` exists, fails with that JSON error body
|
||
* and the matching diagnostic as GitHub's HTTP 406 refusal. The raw contents API
|
||
* serves `contents.json`, keyed by `path@commit`, and the commit listing of pull
|
||
* request 7 serves `commits.json`, oldest first. The review thread read serves
|
||
* `threads.json` as its one page of threads, with the viewer `lin`, who may write
|
||
* to the repository and did not open either pull request, or no threads without it. Review mutations, which arrive as
|
||
* JSON on stdin, change what later reads report through `state.json`: replies,
|
||
* which join the pending review whenever one exists, resolution, comment edits and
|
||
* deletions, and the pending review of `lin` with its new threads, which a
|
||
* submission publishes. Each mutation is appended to
|
||
* `mutations.jsonl`, and every invocation to `calls.jsonl`.
|
||
*/
|
||
const GH = `#!/usr/bin/env node
|
||
import { appendFileSync, existsSync, readFileSync, writeFileSync } from 'node:fs'
|
||
import { dirname, join } from 'node:path'
|
||
import { fileURLToPath } from 'node:url'
|
||
const args = process.argv.slice(2)
|
||
const here = dirname(fileURLToPath(import.meta.url))
|
||
appendFileSync(join(here, 'calls.jsonl'), JSON.stringify(args) + '\\n')
|
||
const statePath = join(here, 'state.json')
|
||
const state = existsSync(statePath) ? JSON.parse(readFileSync(statePath, 'utf8')) : { ready: false, mergedAt: null }
|
||
const save = () => { writeFileSync(statePath, JSON.stringify(state)) }
|
||
if (args[0] === 'pr' && args[1] === 'view' && args[2] === '7') {
|
||
const fields = args[args.indexOf('--json') + 1]
|
||
process.stdout.write(JSON.stringify(fields === 'url'
|
||
? { url: 'https://github.com/octo/demo/pull/7' }
|
||
: { number: 7, title: 'Add the pull request panel' }))
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'pr' && args[1] === 'ready' && args[2] === '9') {
|
||
state.ready = true
|
||
save()
|
||
process.stderr.write('Pull request octo/demo#9 is marked as "ready for review"\\n')
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'api' && args[5] === 'repos/octo/demo/pulls/9/merge') {
|
||
state.mergedAt = new Date().toISOString()
|
||
save()
|
||
process.stdout.write(JSON.stringify({ sha: 'c'.repeat(40), merged: true, message: 'Pull Request successfully merged' }))
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'api' && args[3] === 'repos/octo/demo/pulls/7') {
|
||
process.stdout.write(JSON.stringify({ head: { sha: 'a'.repeat(40) }, state: 'open' }))
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'api' && args[4] === 'POST' && ['repos/octo/demo/pulls/7/comments', 'repos/octo/demo/pulls/7/reviews'].includes(args[5])) {
|
||
const body = JSON.parse(readFileSync(0, 'utf8'))
|
||
appendFileSync(join(here, 'reviews.jsonl'), JSON.stringify({ endpoint: args[5], body }) + '\\n')
|
||
process.stdout.write(JSON.stringify({ html_url: 'https://github.com/octo/demo/pull/7#pullrequestreview-1' }))
|
||
process.exit(0)
|
||
}
|
||
const BASE = 'e'.repeat(40)
|
||
const heads = () => ({ 7: 'a'.repeat(40), 9: state.head ?? 'b'.repeat(40) })
|
||
if (args[0] === 'api' && args.includes('Accept: application/vnd.github.diff')) {
|
||
const [, range] = args.at(-1).split('/compare/')
|
||
const chosen = existsSync(join(here, 'compare.json')) ? JSON.parse(readFileSync(join(here, 'compare.json'), 'utf8'))[range] : undefined
|
||
if (chosen !== undefined) {
|
||
process.stdout.write(chosen)
|
||
process.exit(0)
|
||
}
|
||
const [base, head] = range.split('...')
|
||
const number = Object.entries(heads()).find(([, oid]) => oid === head)?.[0]
|
||
if (base !== BASE || number === undefined) {
|
||
process.stderr.write('gh: Not Found (HTTP 404)\\n')
|
||
process.exit(1)
|
||
}
|
||
const refused = join(here, 'pr-' + number + '.refused')
|
||
if (existsSync(refused)) {
|
||
const message = readFileSync(refused, 'utf8')
|
||
process.stdout.write(JSON.stringify({ message, errors: [{ resource: 'PullRequest', field: 'diff', code: 'too_large' }], status: '406' }))
|
||
process.stderr.write('gh: ' + message + ' (HTTP 406)\\n')
|
||
process.exit(1)
|
||
}
|
||
await new Promise(resolve => process.stdout.write(readFileSync(join(here, 'pr-' + number + '.diff'), 'utf8'), resolve))
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'api' && args[3] === '-H' && args[4] === 'Accept: application/vnd.github.raw+json') {
|
||
const [resource, query] = args[5].split('?')
|
||
const path = decodeURIComponent(resource.slice('repos/octo/demo/contents/'.length))
|
||
const text = JSON.parse(readFileSync(join(here, 'contents.json'), 'utf8'))[path + '@' + query.slice('ref='.length)]
|
||
if (text === undefined) {
|
||
process.stderr.write('gh: Not Found (HTTP 404)\\n')
|
||
process.exit(1)
|
||
}
|
||
process.stdout.write(text)
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'auth' && args[1] === 'status') {
|
||
process.stdout.write('github.com\\n Logged in to github.com account octo\\n')
|
||
process.exit(0)
|
||
}
|
||
const review = () => ({ pending: null, published: [], replies: {}, resolved: {}, bodies: {}, deleted: [], ...state.review })
|
||
/** The signed-in reviewer, who did not open the pull requests. */
|
||
const VIEWER = 'lin'
|
||
/** One review comment node by \`login\`, which the viewer may change when it is the viewer's own. */
|
||
const commentNode = (id, body, login, pending) => ({ id, state: pending ? 'PENDING' : 'SUBMITTED', createdAt: '2026-10-09T01:00:00Z',
|
||
url: pending ? null : 'https://github.com/octo/demo/pull/7#discussion_' + id, body,
|
||
viewerCanUpdate: login === VIEWER, viewerCanDelete: login === VIEWER, author: { __typename: 'User', login, avatarUrl: null } })
|
||
if (args[0] === 'api' && args[1] === 'graphql' && args.includes('--input')) {
|
||
const { query, variables } = JSON.parse(readFileSync(0, 'utf8'))
|
||
const field = query.match(/\\{\\s*(\\w+)\\(input:/)[1]
|
||
appendFileSync(join(here, 'mutations.jsonl'), JSON.stringify({ field, variables }) + '\\n')
|
||
const current = review()
|
||
const draft = thread => ({ id: 'new-' + (current.published.length + (current.pending?.threads.length ?? 0) + 1),
|
||
path: thread.path, side: thread.side, line: thread.line, startLine: thread.startLine ?? null, body: thread.body })
|
||
let payload
|
||
if (field === 'addPullRequestReview') {
|
||
current.pending = { id: 'review-1', commit: variables.commit, threads: [] }
|
||
for (const thread of variables.threads ?? []) current.pending.threads.push(draft(thread))
|
||
payload = { pullRequestReview: { id: 'review-1' } }
|
||
} else if (field === 'addPullRequestReviewThread') {
|
||
current.pending.threads.push(draft(variables))
|
||
payload = { thread: { id: current.pending.threads.at(-1).id } }
|
||
} else if (field === 'addPullRequestReviewThreadReply') {
|
||
const replies = current.replies[variables.thread] ??= []
|
||
// As on GitHub, a reply joins the pending review whenever one exists.
|
||
replies.push({ id: variables.thread + '-reply-' + replies.length, body: variables.body, pending: variables.review !== null || current.pending !== null })
|
||
payload = { comment: { id: replies.at(-1).id } }
|
||
} else if (field === 'resolveReviewThread' || field === 'unresolveReviewThread') {
|
||
current.resolved[variables.thread] = field === 'resolveReviewThread'
|
||
payload = { thread: { id: variables.thread } }
|
||
} else if (field === 'updatePullRequestReviewComment') {
|
||
current.bodies[variables.comment] = variables.body
|
||
payload = { pullRequestReviewComment: { id: variables.comment } }
|
||
} else if (field === 'deletePullRequestReviewComment') {
|
||
current.deleted.push(variables.comment)
|
||
payload = { clientMutationId: null }
|
||
} else if (field === 'submitPullRequestReview' || field === 'deletePullRequestReview') {
|
||
if (field === 'submitPullRequestReview') current.published.push(...current.pending.threads)
|
||
for (const replies of Object.values(current.replies)) {
|
||
for (const reply of replies) if (reply.pending && field === 'deletePullRequestReview') current.deleted.push(reply.id)
|
||
for (const reply of replies) reply.pending = false
|
||
}
|
||
current.pending = null
|
||
payload = { pullRequestReview: { id: variables.review } }
|
||
}
|
||
state.review = current
|
||
save()
|
||
process.stdout.write(JSON.stringify({ data: { [field]: payload } }))
|
||
process.exit(0)
|
||
}
|
||
if (args[0] === 'api' && args[1] === 'graphql') {
|
||
const query = args.find(arg => arg.startsWith('query=')).slice('query='.length)
|
||
const check = (name, conclusion, completedAt, databaseId = 101) => ({
|
||
__typename: 'CheckRun', id: 'check-' + databaseId, name, status: 'COMPLETED', conclusion, databaseId,
|
||
detailsUrl: 'https://github.com/octo/demo/actions/runs/1', startedAt: '2026-10-09T00:00:00Z', completedAt,
|
||
checkSuite: { app: { id: 'github-actions' }, workflowRun: { event: 'pull_request', workflow: { id: 'ci', name: 'CI' } } },
|
||
})
|
||
const pulls = {
|
||
7: {
|
||
id: 'pull-7', number: 7, url: 'https://github.com/octo/demo/pull/7', title: 'Add the pull request panel', state: 'OPEN', isDraft: false,
|
||
updatedAt: '2026-10-09T00:00:00Z', closedAt: null, author: { login: 'octo' }, headRefName: 'feat', headRefOid: 'a'.repeat(40), baseRefOid: BASE,
|
||
baseRefName: 'main', additions: 128, deletions: 14, mergeable: 'MERGEABLE', mergeStateStatus: 'BLOCKED', reviewDecision: 'REVIEW_REQUIRED',
|
||
reviewThreads: { pageInfo: { hasNextPage: false, endCursor: null }, nodes: [{ isResolved: false }] },
|
||
commits: { nodes: [{ commit: { statusCheckRollup: { id: 'rollup-7', state: 'FAILURE', contexts: {
|
||
pageInfo: { hasNextPage: true, endCursor: 'checks-100' },
|
||
nodes: Array.from({ length: 100 }, (_, i) => check('lint', 'FAILURE', '2026-10-08T00:00:42Z', i + 1)),
|
||
} } } }] },
|
||
},
|
||
9: {
|
||
id: 'pull-9', number: 9, url: 'https://github.com/octo/demo/pull/9', title: 'Add the merge button', state: state.mergedAt === null ? 'OPEN' : 'MERGED',
|
||
isDraft: !state.ready, updatedAt: '2026-10-09T00:00:00Z', closedAt: state.mergedAt, author: { login: 'octo' },
|
||
headRefName: 'feat/merge', headRefOid: heads()[9], baseRefName: 'main', baseRefOid: BASE, additions: 30, deletions: 2, mergeable: 'MERGEABLE',
|
||
mergeStateStatus: state.ready ? 'CLEAN' : 'BLOCKED', reviewDecision: 'APPROVED',
|
||
reviewThreads: { pageInfo: { hasNextPage: false, endCursor: null }, nodes: [] },
|
||
commits: { nodes: [{ commit: { statusCheckRollup: { id: 'rollup-9', state: 'SUCCESS', contexts: {
|
||
pageInfo: { hasNextPage: false, endCursor: null }, nodes: [check('lint', 'SUCCESS', '2026-10-09T00:00:42Z')],
|
||
} } } }] },
|
||
},
|
||
}
|
||
if (query.includes('commits(first: $first')) {
|
||
const commits = existsSync(join(here, 'commits.json')) ? JSON.parse(readFileSync(join(here, 'commits.json'), 'utf8')) : []
|
||
process.stdout.write(JSON.stringify({ data: { repository: { pullRequest: { headRefOid: 'a'.repeat(40), commits: {
|
||
totalCount: commits.length, pageInfo: { hasNextPage: false, endCursor: null },
|
||
nodes: commits.map(commit => ({ commit: {
|
||
oid: commit.sha, messageHeadline: commit.title, authoredDate: '2026-10-08T00:00:00Z',
|
||
author: { name: 'Octo', user: { login: 'octo' } }, parents: { nodes: [{ oid: commit.parent }] },
|
||
} })),
|
||
} } } } }))
|
||
process.exit(0)
|
||
}
|
||
if (query.includes('viewer { login }')) {
|
||
const number = Number(args.find(arg => arg.startsWith('number=')).slice('number='.length))
|
||
const current = review()
|
||
const page = nodes => ({ pageInfo: { hasNextPage: false, endCursor: null }, nodes })
|
||
const written = (thread, pending) => ({
|
||
id: thread.id, isOutdated: false, isResolved: false, path: thread.path, diffSide: thread.side, startDiffSide: thread.startLine === null ? null : thread.side,
|
||
line: thread.line, startLine: thread.startLine, originalLine: thread.line, originalStartLine: thread.startLine, subjectType: 'LINE',
|
||
viewerCanReply: true, viewerCanResolve: true, viewerCanUnresolve: false,
|
||
root: { nodes: [{ diffHunk: '@@ -1,5 +1,5 @@', commit: { oid: pulls[number].headRefOid }, originalCommit: { oid: pulls[number].headRefOid } }] },
|
||
comments: page([commentNode(thread.id + '-0', thread.body, VIEWER, pending)]),
|
||
})
|
||
const stored = existsSync(join(here, 'threads.json')) ? JSON.parse(readFileSync(join(here, 'threads.json'), 'utf8')) : []
|
||
const threads = [...stored, ...current.published.map(thread => written(thread, false)),
|
||
...(current.pending?.threads ?? []).map(thread => written(thread, true))].map((thread) => {
|
||
const replies = (current.replies[thread.id] ?? []).map(reply => commentNode(reply.id, reply.body, VIEWER, reply.pending))
|
||
const comments = [...thread.comments.nodes, ...replies].filter(comment => !current.deleted.includes(comment.id))
|
||
.map(comment => ({ ...comment, body: current.bodies[comment.id] ?? comment.body }))
|
||
return { ...thread, isResolved: current.resolved[thread.id] ?? thread.isResolved, comments: page(comments) }
|
||
}).filter(thread => thread.comments.nodes.length > 0)
|
||
const pendingComments = threads.flatMap(thread => thread.comments.nodes).filter(comment => comment.state === 'PENDING').length
|
||
process.stdout.write(JSON.stringify({ data: { viewer: { login: VIEWER }, repository: { isArchived: false, viewerPermission: 'WRITE',
|
||
pullRequest: { id: 'pull-' + number, headRefOid: pulls[number].headRefOid, locked: false,
|
||
reviews: { nodes: current.pending === null ? [] : [{ id: current.pending.id, viewerDidAuthor: true, comments: { totalCount: pendingComments } }] },
|
||
reviewThreads: page(threads) } } } }))
|
||
process.exit(0)
|
||
}
|
||
if (query.includes('reviews(states: PENDING')) {
|
||
const number = Number(args.find(arg => arg.startsWith('number=')).slice('number='.length))
|
||
const pending = review().pending
|
||
// Every thread and comment the double serves belongs to the pull request it was read from.
|
||
const target = args.some(arg => arg.startsWith('target=')) ? { target: { pullRequest: { id: 'pull-' + number } } } : {}
|
||
process.stdout.write(JSON.stringify({ data: { repository: { pullRequest: { id: 'pull-' + number, headRefOid: pulls[number].headRefOid,
|
||
reviews: { nodes: pending === null ? [] : [{ id: pending.id, viewerDidAuthor: true }] } } }, ...target } }))
|
||
process.exit(0)
|
||
}
|
||
if (query.includes('pullRequest(number: $number)')) {
|
||
const number = Number(args.find(arg => arg.startsWith('number=')).slice('number='.length))
|
||
process.stdout.write(JSON.stringify({ data: { repository: { pullRequest: { headRefOid: pulls[number].headRefOid, baseRefOid: BASE } } } }))
|
||
process.exit(0)
|
||
}
|
||
if (query.includes('node(id: $id)')) {
|
||
process.stdout.write(JSON.stringify({ data: { node: { contexts: {
|
||
pageInfo: { hasNextPage: false, endCursor: null },
|
||
nodes: [check('lint', 'SUCCESS', '2026-10-09T00:00:42Z'), check('test', 'FAILURE', '2026-10-09T00:02:07Z')],
|
||
} } } }))
|
||
process.exit(0)
|
||
}
|
||
const settings = {
|
||
squashMergeAllowed: true, mergeCommitAllowed: true, rebaseMergeAllowed: true, viewerPermission: 'WRITE', viewerDefaultMergeMethod: 'SQUASH',
|
||
}
|
||
const data = {}
|
||
let repository
|
||
for (const match of query.matchAll(/(r\\d+): repository\\(|(p\\d+): pullRequest\\(number: (\\d+)\\)/g)) {
|
||
if (match[1] !== undefined) data[repository = match[1]] = { ...settings }
|
||
else data[repository][match[2]] = pulls[Number(match[3])] ?? null
|
||
}
|
||
process.stdout.write(JSON.stringify({ data }))
|
||
process.exit(0)
|
||
}
|
||
process.stderr.write('unexpected gh invocation\\n')
|
||
process.exit(1)
|
||
`
|
||
|
||
/** Head commit of pull request 7 in the GitHub CLI double. */
|
||
const HEAD7 = 'a'.repeat(40)
|
||
|
||
/** Patch of pull request 9: one line added to each of 301 files, more than the pull request diff endpoint accepts. */
|
||
const PR9_DIFF = Array.from({ length: 301 }, (_, index) => [
|
||
`diff --git a/merge/m${index}.ts b/merge/m${index}.ts`, 'index 1111111..2222222 100644', `--- a/merge/m${index}.ts`, `+++ b/merge/m${index}.ts`,
|
||
'@@ -1 +1,2 @@', ' export {}', `+export const m${index} = ${index}`, '',
|
||
].join('\n')).join('')
|
||
|
||
/** Message of the double's HTTP 406 refusal, which it sends in the error body format GitHub uses for a diff over its size limit. */
|
||
const PR9_REFUSAL = 'Sorry, the diff exceeded the size limit.'
|
||
|
||
/** Line `n` of `src/panel.ts` before (`old`) or after (`new`) pull request 7, which changes lines 2 and 15 of its 20. */
|
||
function panelLine(n: number, side: 'old' | 'new'): string {
|
||
if (n === 2) return side === 'old' ? 'export const n2 = 2' : 'export const n2 = \'two\''
|
||
if (n === 7) return 'export const n7 = "Long unchanged context stays wrapped while switching between Sessions and reviewing the same file"'
|
||
if (n === 15) return side === 'old' ? 'export const n15 = 15' : 'export const n15 = \'fifteen\''
|
||
return `export const n${n} = ${n}`
|
||
}
|
||
|
||
/** Patch of pull request 7 as `gh pr diff` prints it: two hunks of `src/panel.ts` and the new `docs/panel.md`. */
|
||
const PR7_DIFF = [
|
||
'diff --git a/src/panel.ts b/src/panel.ts',
|
||
'index 1111111..2222222 100644',
|
||
'--- a/src/panel.ts',
|
||
'+++ b/src/panel.ts',
|
||
'@@ -1,5 +1,5 @@',
|
||
` ${panelLine(1, 'new')}`, `-${panelLine(2, 'old')}`, `+${panelLine(2, 'new')}`,
|
||
...[3, 4, 5].map(n => ` ${panelLine(n, 'new')}`),
|
||
'@@ -12,7 +12,7 @@',
|
||
...[12, 13, 14].map(n => ` ${panelLine(n, 'new')}`), `-${panelLine(15, 'old')}`, `+${panelLine(15, 'new')}`,
|
||
...[16, 17, 18].map(n => ` ${panelLine(n, 'new')}`),
|
||
'diff --git a/docs/panel.md b/docs/panel.md',
|
||
'new file mode 100644',
|
||
'index 0000000..3333333',
|
||
'--- /dev/null',
|
||
'+++ b/docs/panel.md',
|
||
'@@ -0,0 +1,2 @@',
|
||
'+# Panel',
|
||
'+Shows the change requests of a Session.',
|
||
'',
|
||
].join('\n')
|
||
|
||
/** A patch section that adds `lines` as the new file `path`. */
|
||
function addedSection(path: string, lines: readonly string[]): string[] {
|
||
return [`diff --git a/${path} b/${path}`, 'new file mode 100644', 'index 0000000..4444444', '--- /dev/null', `+++ b/${path}`,
|
||
`@@ -0,0 +1,${lines.length} @@`, ...lines.map(line => `+${line}`)]
|
||
}
|
||
|
||
/** Commits of pull request 7 in the review fixture, oldest first; the last is its head. */
|
||
const REVIEW_COMMITS = [
|
||
{ sha: '1'.repeat(40), parent: 'f'.repeat(40), title: 'Add the pull request panel' },
|
||
{ sha: '2'.repeat(40), parent: '1'.repeat(40), title: 'Test the panel and translate it' },
|
||
{ sha: HEAD7, parent: '2'.repeat(40), title: 'Publish the panel schema' },
|
||
] as const
|
||
|
||
/** New files of each review fixture commit after the first, which changes `src/panel.ts` and adds `docs/panel.md`. */
|
||
const REVIEW_SECTIONS = {
|
||
test: [
|
||
...addedSection('src/panel.spec.ts', ['it(\'shows the panel\', () => {})']),
|
||
...addedSection('locale/zh.json', ['{ "title": "面板" }']),
|
||
],
|
||
schema: [
|
||
...addedSection('package.json', ['{ "name": "demo" }']),
|
||
...addedSection('docs/schema.json', ['{ "type": "object" }']),
|
||
],
|
||
}
|
||
|
||
/**
|
||
* Pull request 7 with review layers: `src/panel.ts` and `docs/panel.md` are implementation, `package.json` is
|
||
* interface, and the spec, the locale dictionary, which `.gitattributes` places in the test layer, and
|
||
* `docs/schema.json`, which it marks generated, are tests.
|
||
*/
|
||
const REVIEW_DIFF = [PR7_DIFF.trimEnd(), ...REVIEW_SECTIONS.test, ...REVIEW_SECTIONS.schema, ''].join('\n')
|
||
|
||
/** Write the review fixture of pull request 7: its patch, commits, commit ranges, and root `.gitattributes`. */
|
||
async function writeReviewFixture(root: string): Promise<void> {
|
||
await writeFile(join(root, 'pr-7.diff'), REVIEW_DIFF)
|
||
await writeFile(join(root, 'commits.json'), JSON.stringify(REVIEW_COMMITS))
|
||
await writeFile(join(root, 'compare.json'), JSON.stringify({
|
||
[`${'1'.repeat(40)}...${'2'.repeat(40)}`]: [...REVIEW_SECTIONS.test, ''].join('\n'),
|
||
[`${'1'.repeat(40)}...${HEAD7}`]: [...REVIEW_SECTIONS.test, ...REVIEW_SECTIONS.schema, ''].join('\n'),
|
||
}))
|
||
const contents = JSON.parse(await readFile(join(root, 'contents.json'), 'utf8')) as Record<string, string>
|
||
for (const commit of ['2'.repeat(40), HEAD7]) {
|
||
contents[`.gitattributes@${commit}`] = 'docs/schema.json linguist-generated\nlocale/*.json dsh-review-layer=test\n'
|
||
}
|
||
await writeFile(join(root, 'contents.json'), JSON.stringify(contents))
|
||
}
|
||
|
||
async function git(cwd: string, ...args: string[]): Promise<string> {
|
||
const { stdout } = await run('git', args, { cwd, env: { ...process.env, GIT_CONFIG_NOSYSTEM: '1', GIT_TERMINAL_PROMPT: '0' } })
|
||
return stdout.trim()
|
||
}
|
||
|
||
/** A Web scaffold with the bundle, a GitHub checkout of `main` and `release`, and the New Session screen of that workspace. */
|
||
interface PanelLaunch {
|
||
readonly scaffold: WebScaffold
|
||
readonly page: Page
|
||
/** Temporary directory of the GitHub CLI double and its call log. */
|
||
readonly root: string
|
||
/** The Session's workspace, a main checkout. */
|
||
readonly project: string
|
||
readonly tripwire: ReturnType<typeof watchConsole>
|
||
}
|
||
|
||
/**
|
||
* Launch the bundle against a GitHub checkout of `main` and `release` and open the New Session screen of that workspace.
|
||
* @param failureShot - name of the screenshot saved when the test fails.
|
||
* @param scenario - normal conversation, a restoration follow-up, or a numbered PR lookup.
|
||
* @param options - desktop transport, checkout branch, browser input, sandbox runner availability, and diff output limit.
|
||
* @returns the scaffold, page, and checkout.
|
||
*/
|
||
async function launchPanel(failureShot: string, scenario: 'normal' | 'follow-up' | 'reference' = 'normal',
|
||
options: { desktop?: 'darwin' | 'win32'; branch?: string; hasTouch?: boolean; missingSandbox?: boolean; maxDiffBytes?: number } = {}): Promise<PanelLaunch> {
|
||
const { desktop } = options
|
||
const resources: { scaffold?: WebScaffold; browser?: Browser } = {}
|
||
const root = await mkdtemp(join(tmpdir(), 'dsh-forge-panel-'))
|
||
onTestFinished(async () => {
|
||
const failures: unknown[] = []
|
||
await resources.browser?.close().catch((error: unknown) => failures.push(error))
|
||
await resources.scaffold?.close().catch((error: unknown) => failures.push(error))
|
||
await rm(root, { recursive: true, force: true }).catch((error: unknown) => failures.push(error))
|
||
if (failures.length > 0) throw new AggregateError(failures, 'Forge panel teardown failed')
|
||
})
|
||
const gh = join(root, 'gh')
|
||
await writeFile(gh, GH)
|
||
await chmod(gh, 0o755)
|
||
await writeFile(join(root, 'pr-7.diff'), PR7_DIFF)
|
||
await writeFile(join(root, 'pr-9.diff'), PR9_DIFF)
|
||
const panelText = `${Array.from({ length: 20 }, (_, index) => panelLine(index + 1, 'new')).join('\n')}\n`
|
||
await writeFile(join(root, 'contents.json'), JSON.stringify({ [`src/panel.ts@${HEAD7}`]: panelText }))
|
||
const overlay = join(root, 'forge.patch.yml')
|
||
await writeFile(overlay, `- id: forge-github\n config: ${JSON.stringify({ ghCommand: gh })}\n`
|
||
+ (options.maxDiffBytes === undefined ? '' : `- id: forge-panel\n config: ${JSON.stringify({ maxDiffBytes: options.maxDiffBytes })}\n`)
|
||
+ (options.missingSandbox ? `- id: sandbox\n config: ${JSON.stringify({ runnerCommand: [join(root, 'missing-sandbox')], runnerFailureSignatures: ['sandbox startup failed'] })}\n` : ''))
|
||
const override = join(root, 'replay.override.json')
|
||
// The borrowed scenario records one model call, so index 1 appends the reply to the follow-up.
|
||
if (scenario === 'follow-up') await writeFile(override, JSON.stringify({ patches: [{ at: 1, entry: { kind: 'chunks', chunks: textReply(FOLLOW_UP_REPLY) } }] }))
|
||
if (scenario === 'reference') {
|
||
const command = `PATH=${JSON.stringify(`.fixture-bin:${process.env.PATH ?? ''}`)} gh pr view 7 --repo octo/demo --json number,title 2>&1 | head -200`
|
||
const call = { type: 'tool-call', id: 'view-pr', name: 'bash', arguments: JSON.stringify({ command, description: 'View PR metadata' }) }
|
||
await writeFile(override, JSON.stringify({ patches: [
|
||
{ at: 0, entry: { kind: 'chunks', chunks: [
|
||
{ type: 'block-start', index: 0, blockType: 'tool-call' },
|
||
{ type: 'block-end', index: 0, block: call },
|
||
{ type: 'finish', reason: { kind: 'tool-calls' } },
|
||
] } },
|
||
{ at: 1, entry: { kind: 'chunks', chunks: textReply('Viewed PR 7.') } },
|
||
] }))
|
||
}
|
||
const scaffold = await launchWebScaffold({
|
||
profile: { packages: [{ dir: BUNDLE, enabled: true }] },
|
||
extraOverlayPath: overlay,
|
||
replayFixture: FIXTURE,
|
||
...scenario !== 'normal' ? { replayOverride: override } : {},
|
||
// The worktree notice, worktree records, and bindings are asserted separately from the borrowed conversation.
|
||
compareReplaySession: false,
|
||
})
|
||
resources.scaffold = scaffold
|
||
|
||
const project = join(scaffold.workspaceCwd, 'workspace')
|
||
await mkdir(project, { recursive: true })
|
||
await git(project, 'init', '--quiet', '--initial-branch=main')
|
||
await git(project, 'config', 'user.name', 'Forge Panel')
|
||
await git(project, 'config', 'user.email', '[email protected]')
|
||
await git(project, 'config', 'commit.gpgsign', 'false')
|
||
await writeFile(join(project, 'README.md'), 'demo\n')
|
||
await git(project, 'add', 'README.md')
|
||
await git(project, 'commit', '--quiet', '-m', 'init')
|
||
await git(project, 'remote', 'add', 'origin', 'https://github.com/octo/demo.git')
|
||
await git(project, 'branch', 'release')
|
||
await git(project, 'commit', '--quiet', '--allow-empty', '-m', 'main only')
|
||
if (options.branch !== undefined) await git(project, 'checkout', '--quiet', '-b', options.branch)
|
||
if (scenario === 'reference') {
|
||
// The model's confined command must own the CLI double's writable call log.
|
||
const modelBin = join(project, '.fixture-bin')
|
||
await mkdir(modelBin)
|
||
await writeFile(join(modelBin, 'gh'), GH)
|
||
await chmod(join(modelBin, 'gh'), 0o755)
|
||
}
|
||
|
||
const browser = await chromium.launch()
|
||
resources.browser = browser
|
||
const page = await browser.newPage({ viewport: { width: 1680, height: 1000 }, locale: ZH_BROWSER_LOCALE, timezoneId: 'Asia/Shanghai',
|
||
hasTouch: options.hasTouch ?? false })
|
||
if (desktop !== undefined) {
|
||
// Only Electron's keyboard transport is substituted; the product registry and menus remain real.
|
||
await page.addInitScript(({ device, config }) => {
|
||
const mark = () => { document.documentElement.dataset.platform = device }
|
||
if (document.documentElement === null) window.addEventListener('DOMContentLoaded', mark)
|
||
else mark()
|
||
const listeners = new Set<(input: DesktopShortcutInput) => void>()
|
||
Object.assign(window, {
|
||
forgeKeyboard: { revision: config.revision,
|
||
deliver: (input: DesktopShortcutInput) => { for (const listener of listeners) listener(input) } },
|
||
dshDesktop: { protocolVersion: 1,
|
||
shortcuts: { get: async () => config, subscribe: () => () => {}, recording: async () => {}, edit: async () => { throw new Error('Unused preference edit') } },
|
||
keyboard: {
|
||
subscribe: (listener: (input: DesktopShortcutInput) => void) => {
|
||
listeners.add(listener)
|
||
return () => { listeners.delete(listener) }
|
||
},
|
||
closeWindow: async () => {},
|
||
},
|
||
},
|
||
})
|
||
}, { device: desktop, config: { ...initialShortcutConfig(), status: 'ready' as const } })
|
||
}
|
||
const tripwire = watchConsole(page)
|
||
onTestFailed(async () => { await saveFailureShot(page, failureShot) })
|
||
await page.goto(scaffold.authenticatedUrl, { waitUntil: 'load' })
|
||
await connectFreshWorkspaceZh(page, scaffold.workspaceCwd)
|
||
return { scaffold, page, root, project, tripwire }
|
||
}
|
||
|
||
/** Stream chunks of a model reply that is one text block. */
|
||
function textReply(text: string): unknown[] {
|
||
return [
|
||
{ type: 'block-start', index: 0, blockType: 'text' },
|
||
{ type: 'text-delta', index: 0, text },
|
||
{ type: 'block-end', index: 0, block: { type: 'text', text } },
|
||
{ type: 'usage', usage: { inputTokens: 50, outputTokens: 2, cacheReadTokens: 0, reasoningTokens: 0 } },
|
||
{ type: 'finish', reason: { kind: 'stop' } },
|
||
]
|
||
}
|
||
|
||
/**
|
||
* Launch the panel and choose the worktree option of the fresh Session from `release`.
|
||
* @param failureShot - name of the screenshot saved when the test fails.
|
||
* @param followUp - whether the replay answers a second model call.
|
||
* @returns the scaffold, page, and checkout.
|
||
*/
|
||
async function requestReleaseWorktree(failureShot: string, followUp = false): Promise<PanelLaunch> {
|
||
const launched = await launchPanel(failureShot, followUp ? 'follow-up' : 'normal')
|
||
const { page } = launched
|
||
const option = page.locator('[data-forge-worktree]')
|
||
await option.waitFor({ timeout: 20_000 })
|
||
await option.getByRole('checkbox', { name: '新建工作树', exact: true }).check()
|
||
await option.getByRole('button', { name: '基于 main', exact: true }).click()
|
||
await page.getByRole('menuitem', { name: 'release', exact: true }).click()
|
||
await option.getByRole('button', { name: '基于 release', exact: true }).waitFor()
|
||
return launched
|
||
}
|
||
|
||
/**
|
||
* Send the first prompt of the borrowed scenario.
|
||
* @returns the prompt and the turn's settlement, which resolves to the Session id.
|
||
*/
|
||
async function sendPrompt(page: Page, scaffold: WebScaffold): Promise<{ readonly prompt: string; readonly settled: Promise<SessionId> }> {
|
||
const [prompt] = fixtureUserPrompts(await readFile(FIXTURE, 'utf8'))
|
||
if (prompt === undefined) throw new Error('The borrowed scenario requires a user prompt')
|
||
const settled = scaffold.whenTurnSettled()
|
||
const composer = page.locator('[data-composer-input]').first()
|
||
await writeComposerDraft(page, composer, prompt)
|
||
await composer.press('Enter')
|
||
return { prompt, settled }
|
||
}
|
||
|
||
function worktreeRecords(events: readonly SessionEvent[]): unknown[] {
|
||
return events.flatMap((event) => {
|
||
const record = pluginRecordOf(event)
|
||
if (record?.type === 'plugin:client-ui-forge/worktree') return [record.data]
|
||
if (record?.type === 'plugin:worktree/created') return [{ created: record.data }]
|
||
return []
|
||
})
|
||
}
|
||
|
||
it.skipIf(MODE === 'record')('reads local Git with full access when the sandbox runner cannot start', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-permissions', 'normal', { missingSandbox: true })
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await writeFile(join(project, 'README.md'), 'demo\nchanged\n')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
await page.getByText('LIGHTHOUSE', { exact: true }).waitFor()
|
||
await page.locator('[data-forge-header]').click()
|
||
const panel = page.locator('[data-forge-panel]')
|
||
await panel.getByText('无法读取 Git 信息', { exact: true }).waitFor({ timeout: 20_000 })
|
||
|
||
const permission = page.locator('button[aria-label^="访问模式"]').first()
|
||
await permission.click()
|
||
await page.getByRole('menuitem', { name: '完全权限', exact: true }).click()
|
||
const confirmation = page.getByRole('dialog', { name: '确认启用完全权限？' })
|
||
await confirmation.getByRole('checkbox', { name: '我已了解风险，并愿意继续' }).check()
|
||
await confirmation.getByRole('button', { name: '启用完全权限' }).click()
|
||
const local = page.locator('[data-forge-local]')
|
||
await local.getByRole('button', { name: '查看本会话的变更：1 个文件，新增 1 行，删除 0 行', exact: true }).waitFor({ timeout: 20_000 })
|
||
await compareOrRefreshGolden(join(EXPECTED, 'full-access.expected.md'), await captureStableAria(page, '[data-forge-local]', scaffold.workspaceCwd), MODE)
|
||
await local.getByRole('button', { name: '查看本会话的变更：1 个文件，新增 1 行，删除 0 行', exact: true }).click()
|
||
await page.locator('[data-forge-diff-file="README.md"]').getByText('changed', { exact: true }).waitFor()
|
||
|
||
await permission.click()
|
||
await page.getByRole('menuitem', { name: '工作区内修改', exact: true }).click()
|
||
if (!await panel.isVisible()) await page.locator('[data-forge-header]').click()
|
||
await panel.getByText('无法读取 Git 信息', { exact: true }).waitFor({ timeout: 20_000 })
|
||
await expect.poll(async () => (await readPersistedEvents(scaffold, sessionId))
|
||
.filter(event => event.type === 'sandbox/mode').map(event => event.data.mode).slice(-2))
|
||
.toEqual(['danger-full-access', 'workspace-write'])
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('reports incomplete filter configuration and retries after it is corrected', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-filter-config', 'normal', { maxDiffBytes: 512 })
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await writeFile(join(project, 'README.md'), 'demo\nchanged\n')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.getByText('LIGHTHOUSE', { exact: true }).waitFor()
|
||
await page.locator('[data-forge-header]').click()
|
||
const openChanges = page.locator('[data-forge-local]').getByRole('button', { name: '查看本会话的变更：1 个文件，新增 1 行，删除 0 行', exact: true })
|
||
await openChanges.waitFor({ timeout: 20_000 })
|
||
const key = `filter.${'long'.repeat(200)}.clean`
|
||
await git(project, 'config', key, 'cat')
|
||
await openChanges.click()
|
||
const changes = page.locator('[data-forge-changes="local"]')
|
||
await changes.getByText('无法完整读取 Git 过滤器配置，尚未执行比较。请检查 Git 配置和读取上限后重试', { exact: true }).waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'filter-config-failed.expected.md'),
|
||
await captureStableAria(page, '[data-forge-changes="local"]', scaffold.workspaceCwd), MODE)
|
||
|
||
await git(project, 'config', '--unset', key)
|
||
await changes.getByRole('button', { name: '重试', exact: true }).click()
|
||
await changes.locator('[data-forge-diff-file="README.md"]').getByText('changed', { exact: true }).waitFor()
|
||
expect(await changes.getByRole('status').count()).toBe(0)
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('automatically shows a numbered PR when gh JSON omits its URL', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-numbered-reference', 'reference')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
const events = await readPersistedEvents(scaffold, sessionId)
|
||
const request = events.find(event => event.type === 'request/header')
|
||
expect(request?.data.header.tools?.filter(tool => tool.name === 'create_worktree')).toHaveLength(1)
|
||
const toolOutput = events.flatMap(event => event.type === 'tool/result'
|
||
? event.data.message.content.flatMap(block => block.type === 'text' ? [block.text] : []) : []).join('\n')
|
||
expect(toolOutput).toContain('Add the pull request panel')
|
||
const header = page.locator('[data-forge-header]')
|
||
await expect.poll(() => header.getAttribute('aria-label'), { timeout: 20_000 }).toBe('本会话的变更请求需要处理')
|
||
await header.click()
|
||
const change = page.locator(`[data-forge-change="${PULL}"]`)
|
||
await change.getByRole('link', { name: 'Add the pull request panel', exact: true }).waitFor({ timeout: 20_000 })
|
||
await change.getByText('等待评审 · 1 条未解决讨论', { exact: true }).waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'reference.expected.md'),
|
||
await captureStableAria(page, `[data-forge-change="${PULL}"]`, scaffold.workspaceCwd), MODE)
|
||
await expect.poll(async () => {
|
||
await scaffold.ctx.sessionPersistence.flush()
|
||
const boundEvents = await readPersistedEvents(scaffold, sessionId)
|
||
return boundEvents.flatMap((event) => {
|
||
const record = pluginRecordOf(event)
|
||
return record?.type === 'plugin:forge-session/binding' ? [record.data] : []
|
||
})
|
||
}).toEqual([{ action: 'reference', url: PULL }])
|
||
const calls = (await readFile(join(project, '.fixture-bin', 'calls.jsonl'), 'utf8')).trim().split('\n').map(line => JSON.parse(line) as string[])
|
||
expect(calls).toContainEqual(['pr', 'view', '7', '--repo', 'octo/demo', '--json', 'url'])
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('starts a Session in a worktree before its first message, follows its change request, and restores the removed worktree', async () => {
|
||
const { scaffold, page, root, project, tripwire } = await requestReleaseWorktree('web-e2e-forge-panel', true)
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
await page.getByText('LIGHTHOUSE', { exact: true }).waitFor()
|
||
await page.locator('[data-forge-creation]').waitFor({ state: 'detached' })
|
||
await page.locator('[data-forge-worktree]').waitFor({ state: 'detached' })
|
||
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('The worktree Session must stay loaded')
|
||
const directory = scaffold.ctx.workingDirectory.get(session)
|
||
const branch = basename(directory)
|
||
expect(directory).toBe(join(project, '.agents', 'worktrees', branch))
|
||
expect(branch).toMatch(new RegExp(`^dsh-${sessionId.slice('session-'.length, 'session-'.length + 8)}-[0-9a-f]{4}$`))
|
||
expect(await git(directory, 'rev-parse', '--abbrev-ref', 'HEAD')).toBe(branch)
|
||
const baseCommit = await git(project, 'rev-parse', 'release')
|
||
expect(await git(directory, 'rev-parse', 'HEAD')).toBe(baseCommit)
|
||
const events = await readPersistedEvents(scaffold, sessionId)
|
||
expect(worktreeRecords(events)).toEqual([
|
||
{ action: 'request', from: 'main' },
|
||
{ action: 'request', from: 'release' },
|
||
{ created: { path: directory, branch, baseCommit, repositoryRoot: project } },
|
||
])
|
||
// The worktree existed before the turn, so the first model request carried its directory notice.
|
||
const created = events.findIndex((event) => {
|
||
const record = pluginRecordOf(event)
|
||
return record?.type === 'plugin:worktree/created'
|
||
})
|
||
const turn = events.findIndex(event => event.type === 'turn/start')
|
||
const notice = events.findIndex(event => event.type === 'user/message' && event.data.source.kind === 'working-directory')
|
||
expect(created).toBeLessThan(turn)
|
||
expect(notice).toBeGreaterThan(turn)
|
||
expect(notice).toBeLessThan(events.findIndex(event => event.type === 'assistant/message'))
|
||
|
||
// A change request bound the way a `gh pr create` result binds one.
|
||
scaffold.ctx.forgeSession.track(session, PULL)
|
||
const header = page.locator('[data-forge-header]')
|
||
await expect.poll(() => header.getAttribute('aria-label'), { timeout: 20_000 }).toBe('本会话的变更请求需要处理')
|
||
expect(await header.getAttribute('aria-pressed')).toBe('false')
|
||
|
||
// The Session row marks the worktree and its change request's state, and its hover card names both.
|
||
const row = page.locator(`[data-row-key="session:${sessionId}"]`)
|
||
await row.getByRole('img', { name: '在自己的工作树中', exact: true }).waitFor({ timeout: 20_000 })
|
||
await row.getByRole('img', { name: '变更请求状态：需要处理 · 检查失败', exact: true }).waitFor({ timeout: 20_000 })
|
||
// A fresh page cannot retain the previous browser source's status values.
|
||
await page.goto('about:blank')
|
||
await expect.poll(() => scaffold.ctx.storageDomain.get('forge_panel_change_requests')).toBeUndefined()
|
||
await page.goto(scaffold.authenticatedUrl, { waitUntil: 'load' })
|
||
await row.getByRole('img', { name: '变更请求状态：需要处理 · 检查失败', exact: true }).waitFor({ timeout: 20_000 })
|
||
await row.hover()
|
||
const rowHover = page.locator('[data-forge-session-hover]')
|
||
await rowHover.getByText('#7 Add the pull request panel', { exact: true }).waitFor({ timeout: 20_000 })
|
||
await compareOrRefreshGolden(join(EXPECTED, 'session-row-hover.expected.md'),
|
||
await captureStableAria(page, '[data-forge-session-hover]', scaffold.workspaceCwd, { replacements: [[branch, 'dsh-{{worktree}}']] }), MODE)
|
||
await page.mouse.move(0, 0)
|
||
await rowHover.waitFor({ state: 'detached' })
|
||
await header.click()
|
||
await expect.poll(() => header.getAttribute('aria-pressed')).toBe('true')
|
||
const panel = page.locator('[data-forge-panel]')
|
||
const checkout = panel.locator('[data-forge-checkout]')
|
||
const checkoutName = checkout.getByText(branch, { exact: true })
|
||
await checkoutName.waitFor({ timeout: 20_000 })
|
||
await checkout.getByText('工作树 · 基于 release', { exact: true }).waitFor()
|
||
await checkoutName.hover()
|
||
await page.getByRole('tooltip').filter({ hasText: `工作树（基于 release）：${abbreviateHomePath(directory, homedir())}` }).waitFor()
|
||
await page.mouse.move(0, 0)
|
||
const change = panel.locator(`[data-forge-change="${PULL}"]`)
|
||
const title = change.getByRole('link', { name: 'Add the pull request panel', exact: true })
|
||
await title.waitFor({ timeout: 20_000 })
|
||
// The only open change request starts expanded.
|
||
await change.getByText('等待评审 · 1 条未解决讨论', { exact: true }).waitFor()
|
||
// The random branch suffix can read as a duration, so the branch is replaced before the capture normalizes durations.
|
||
await compareOrRefreshGolden(join(EXPECTED, 'panel.expected.md'),
|
||
await captureStableAria(page, '[data-forge-panel]', scaffold.workspaceCwd, { replacements: [[branch, 'dsh-{{worktree}}']] }), MODE)
|
||
const beforeChecks = (await readFile(join(root, 'calls.jsonl'), 'utf8')).trim().split('\n').map(line => JSON.parse(line) as string[])
|
||
expect(beforeChecks.some(args => args.includes('id=rollup-7'))).toBe(false)
|
||
const checksRow = change.getByRole('button', { name: /^检查/ })
|
||
await checksRow.click()
|
||
const checks = page.getByRole('menu')
|
||
await expect.poll(() => checks.getByRole('menuitem').allTextContents()).toEqual([expect.stringMatching(/^test/), expect.stringMatching(/^lint/)])
|
||
const afterChecks = (await readFile(join(root, 'calls.jsonl'), 'utf8')).trim().split('\n').map(line => JSON.parse(line) as string[])
|
||
expect(afterChecks.filter(args => args.includes('id=rollup-7'))).toHaveLength(1)
|
||
await page.keyboard.press('Escape')
|
||
await checks.waitFor({ state: 'detached' })
|
||
expect(await checksRow.getAttribute('aria-expanded')).toBe('false')
|
||
|
||
const bindings = async () => (await readPersistedEvents(scaffold, sessionId)).flatMap((event) => {
|
||
const record = pluginRecordOf(event)
|
||
return record?.type === 'plugin:forge-session/binding' ? [record.data] : []
|
||
})
|
||
await change.getByRole('button', { name: '从本会话移除 #7', exact: true }).click()
|
||
await change.waitFor({ state: 'detached' })
|
||
await panel.getByText('本会话还没有变更请求', { exact: true }).waitFor()
|
||
await page.getByRole('alert').filter({ hasText: '已从本会话移除 #7' }).getByRole('button', { name: '撤销', exact: true }).click()
|
||
await title.waitFor({ timeout: 20_000 })
|
||
await expect.poll(bindings).toEqual([{ action: 'track', url: PULL }, { action: 'dismiss', url: PULL }, { action: 'track', url: PULL }])
|
||
|
||
const calls = (await readFile(join(root, 'calls.jsonl'), 'utf8')).trim().split('\n').map(line => JSON.parse(line) as string[])
|
||
expect(calls).toContainEqual(['auth', 'status', '--hostname', 'github.com'])
|
||
expect(calls.some(args => args[0] === 'api' && args[1] === 'graphql' && args.includes('--hostname'))).toBe(true)
|
||
await header.click()
|
||
await expect.poll(() => header.getAttribute('aria-pressed')).toBe('false')
|
||
|
||
// Removing the worktree outside the Session holds the next message in the inbox until the worktree is restored.
|
||
await git(project, 'worktree', 'remove', '--force', directory)
|
||
const composer = page.locator('[data-composer-input]').first()
|
||
await writeComposerDraft(page, composer, FOLLOW_UP)
|
||
const accepted = page.waitForResponse('**/api/session/prompt')
|
||
await composer.press('Enter')
|
||
const envelope = await (await accepted).json() as { readonly result: unknown }
|
||
expect(envelope.result).toMatchObject({ ok: true })
|
||
const missing = page.locator('[data-forge-missing]')
|
||
await missing.getByText(`可以在原位置恢复分支 ${branch} 的工作树。删除前未提交的修改无法恢复`, { exact: true }).waitFor()
|
||
await missing.getByText('恢复工作树或在项目目录继续后，消息会接着发送', { exact: true }).waitFor()
|
||
await expect.poll(() => checkout.getAttribute('data-missing')).toBe('')
|
||
const turns = async (): Promise<number> => (await readPersistedEvents(scaffold, sessionId)).filter(event => event.type === 'turn/start').length
|
||
expect(await turns()).toBe(1)
|
||
await missing.getByRole('button', { name: '恢复工作树', exact: true }).click()
|
||
await missing.waitFor({ state: 'detached', timeout: 20_000 })
|
||
await page.getByRole('alert').filter({ hasText: '工作树已恢复' }).waitFor()
|
||
expect(await git(directory, 'rev-parse', '--abbrev-ref', 'HEAD')).toBe(branch)
|
||
expect(await git(directory, 'rev-parse', 'HEAD')).toBe(baseCommit)
|
||
await expect.poll(() => checkout.getAttribute('data-missing')).toBeNull()
|
||
// The waiting message goes on in the restored worktree.
|
||
await page.getByText(FOLLOW_UP_REPLY, { exact: true }).waitFor({ timeout: 20_000 })
|
||
expect(await turns()).toBe(2)
|
||
expect(scaffold.ctx.workingDirectory.get(session)).toBe(directory)
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('keeps the first message waiting when the worktree cannot be created, tries again, and sends it without the worktree', async () => {
|
||
const { scaffold, page, project, tripwire } = await requestReleaseWorktree('web-e2e-forge-panel-failure')
|
||
await git(project, 'branch', '--quiet', '-D', 'release')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const card = page.locator('[data-forge-creation="failed"]')
|
||
const failure = card.getByRole('region', { name: '创建工作树失败', exact: true })
|
||
await failure.getByText('原因', { exact: true }).waitFor({ timeout: 20_000 })
|
||
const attempted = await failure.getByRole('definition').first().textContent()
|
||
expect(attempted).toMatch(/^dsh-[0-9a-f]{8}-[0-9a-f]{4}$/)
|
||
await failure.getByText('消息会在工作树建好后发送', { exact: true }).waitFor()
|
||
|
||
// Retry makes another attempt with a new branch name while the message keeps waiting.
|
||
await card.getByRole('button', { name: '重试', exact: true }).click()
|
||
await expect.poll(() => failure.getByRole('definition').first().textContent(), { timeout: 20_000 }).not.toBe(attempted)
|
||
|
||
await card.getByRole('button', { name: '不使用工作树', exact: true }).click()
|
||
const sessionId = await settled
|
||
await page.getByText('LIGHTHOUSE', { exact: true }).waitFor()
|
||
await card.waitFor({ state: 'detached' })
|
||
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('The Session must stay loaded')
|
||
expect(scaffold.ctx.workingDirectory.get(session)).toBe(project)
|
||
const events = await readPersistedEvents(scaffold, sessionId)
|
||
expect(worktreeRecords(events)).toEqual([{ action: 'request', from: 'main' }, { action: 'request', from: 'release' }, { action: 'cancel' }])
|
||
expect(events.filter(event => event.type === 'turn/start')).toHaveLength(1)
|
||
expect(events.some(event => event.type === 'user/message' && event.data.source.kind === 'working-directory')).toBe(false)
|
||
await page.locator('[data-forge-header]').click({ timeout: 20_000 })
|
||
const checkout = page.locator('[data-forge-panel] [data-forge-checkout]')
|
||
const checkoutName = checkout.getByText('main', { exact: true })
|
||
await checkoutName.waitFor({ timeout: 20_000 })
|
||
await checkout.getByText('项目目录', { exact: true }).waitFor()
|
||
await checkoutName.hover()
|
||
await page.getByRole('tooltip').filter({ hasText: `项目目录：${abbreviateHomePath(project, homedir())}` }).waitFor()
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('marks a draft change request ready for review and merges it with the usual method', async () => {
|
||
const { scaffold, page, root, tripwire } = await launchPanel('web-e2e-forge-panel-merge')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
await page.getByText('LIGHTHOUSE', { exact: true }).waitFor()
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('The Session must stay loaded')
|
||
|
||
scaffold.ctx.forgeSession.track(session, DRAFT)
|
||
const header = page.locator('[data-forge-header]')
|
||
await expect.poll(() => header.getAttribute('aria-label'), { timeout: 20_000 }).toBe('本会话的变更请求')
|
||
await header.click()
|
||
const change = page.locator(`[data-forge-change="${DRAFT}"]`)
|
||
await change.getByRole('link', { name: 'Add the merge button', exact: true }).waitFor({ timeout: 20_000 })
|
||
|
||
// The only open change request starts expanded, so its action is in view.
|
||
await change.getByRole('button', { name: '标记为可评审', exact: true }).click()
|
||
await page.getByRole('alert').filter({ hasText: '已将 #9 标记为可评审' }).waitFor()
|
||
const merge = change.getByRole('button', { name: '合并', exact: true })
|
||
await merge.waitFor({ timeout: 20_000 })
|
||
await merge.click()
|
||
const menu = page.getByRole('menu')
|
||
await menu.getByText('将 #9 合并到 main', { exact: true }).waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'merge-menu.expected.md'), await captureStableAria(page, '[role="menu"]', scaffold.workspaceCwd), MODE)
|
||
await writeFile(join(root, 'state.json'), JSON.stringify({ ready: true, mergedAt: null, head: 'c'.repeat(40) }))
|
||
scaffold.ctx.forge.refresh({ repository: { forge: 'github', host: 'github.com', owner: 'octo', name: 'demo' }, number: 9 })
|
||
const stale = menu.getByRole('menuitem', { name: '提交已更新，请重新检查后再打开合并菜单', exact: true })
|
||
await stale.waitFor()
|
||
expect(await stale.isDisabled()).toBe(true)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'merge-stale.expected.md'), await captureStableAria(page, '[role="menu"]', scaffold.workspaceCwd), MODE)
|
||
await merge.click()
|
||
await merge.click()
|
||
await menu.getByRole('menuitem', { name: '确认合并', exact: true }).click()
|
||
await page.getByRole('alert').filter({ hasText: '已合并 #9' }).waitFor()
|
||
// Merged, the change request is no longer open, so its card collapses to the merge line.
|
||
await change.getByText(/^已合并到 main · /).waitFor({ timeout: 20_000 })
|
||
|
||
const calls = (await readFile(join(root, 'calls.jsonl'), 'utf8')).trim().split('\n').map(line => JSON.parse(line) as string[])
|
||
expect(calls).toContainEqual(['pr', 'ready', '9', '--repo', 'github.com/octo/demo'])
|
||
expect(calls).toContainEqual([
|
||
'api', '--hostname', 'github.com', '--method', 'PUT', 'repos/octo/demo/pulls/9/merge', '-f', 'merge_method=squash', '-f', `sha=${'c'.repeat(40)}`,
|
||
])
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('shows the local changes of the Session by scope and the changes of its change requests, expanding unchanged lines', async () => {
|
||
const { scaffold, page, root, project, tripwire } = await launchPanel('web-e2e-forge-panel-changes', 'follow-up', { branch: 'feat' })
|
||
// origin/main stops at the twelve-line README; the branch adds a commit, which `topic` also has, a staged file, an edit,
|
||
// and an untracked file.
|
||
await writeFile(join(project, 'README.md'), Array.from({ length: 12 }, (_, index) => `line ${index + 1}\n`).join(''))
|
||
await git(project, 'commit', '--quiet', '-am', 'readme')
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await mkdir(join(project, 'src'))
|
||
await writeFile(join(project, 'src', 'app.ts'), 'export const app = 1\n')
|
||
await git(project, 'add', 'src/app.ts')
|
||
await git(project, 'commit', '--quiet', '-m', 'app')
|
||
await git(project, 'branch', 'topic')
|
||
await writeFile(join(project, 'src', 'extra.ts'), 'export const extra = 1\n')
|
||
await git(project, 'add', 'src/extra.ts')
|
||
await writeFile(join(project, 'README.md'), Array.from({ length: 12 }, (_, index) => index === 9 ? 'line ten\n' : `line ${index + 1}\n`).join(''))
|
||
await writeFile(join(project, 'notes.md'), 'note\n')
|
||
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
await page.getByText('LIGHTHOUSE', { exact: true }).waitFor()
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('The Session must stay loaded')
|
||
const header = page.locator('[data-forge-header]')
|
||
await page.getByRole('button', { name: '打开右侧边栏', exact: true }).click()
|
||
const guide = page.locator('[data-sidebar-right-guide]')
|
||
await guide.getByRole('button', { name: /^代码审查和变更/ }).waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-guide.expected.md'),
|
||
await captureStableAria(page, '[data-sidebar-right-guide-entry="forge-panel"]', scaffold.workspaceCwd), MODE)
|
||
await guide.getByRole('button', { name: /^代码审查和变更/ }).click()
|
||
// The New Session screen inspected the checkout before these changes, which came from outside the Session.
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
const card = page.locator('[data-forge-local]')
|
||
await card.getByText('HEAD → origin/main', { exact: true }).waitFor({ timeout: 20_000 })
|
||
await card.getByRole('button', { name: '查看本会话的变更：4 个文件，新增 4 行，删除 1 行', exact: true }).click()
|
||
|
||
const local = page.locator('[data-forge-changes="local"]')
|
||
await local.getByRole('button', { name: '基准分支：origin/main', exact: true }).waitFor({ timeout: 20_000 })
|
||
await local.getByText('包含未提交的修改', { exact: true }).waitFor()
|
||
const files = local.locator('[data-forge-diff-file]')
|
||
await expect.poll(() => files.evaluateAll(sections => sections.map(section => section.getAttribute('data-forge-diff-file'))), { timeout: 20_000 })
|
||
.toEqual(['src/app.ts', 'src/extra.ts', 'README.md', 'notes.md'])
|
||
await local.locator('[data-forge-diff-file="notes.md"]').getByText('新文件 · 未提交', { exact: true }).waitFor()
|
||
const readme = local.locator('[data-forge-diff-file="README.md"]')
|
||
await page.context().grantPermissions(['clipboard-read', 'clipboard-write'])
|
||
await page.evaluate(() => navigator.clipboard.writeText('unchanged'))
|
||
await readme.locator('[data-forge-file-label]').click()
|
||
await expect.poll(() => page.evaluate(() => navigator.clipboard.readText())).toBe('unchanged')
|
||
await readme.locator('[data-forge-path-spacer]').click()
|
||
await expect.poll(() => page.evaluate(() => navigator.clipboard.readText())).toBe('unchanged')
|
||
await readme.getByRole('button', { name: '6 行未变更', exact: true }).click()
|
||
await readme.getByText('line 1', { exact: true }).first().waitFor({ timeout: 20_000 })
|
||
await local.getByRole('button', { name: '全部 4 个文件', exact: true }).click()
|
||
const tree = page.getByRole('menu')
|
||
await tree.getByRole('textbox', { name: '筛选文件…' }).fill('extra')
|
||
await tree.getByRole('menuitem', { name: 'src/extra.ts', exact: true }).click()
|
||
for (const [path, comment] of [['src/app.ts', '请解释这行代码'], ['src/extra.ts', '请检查这项修改']] as const) {
|
||
const section = local.locator(`[data-forge-diff-file="${path}"]`)
|
||
const lineNumber = section.getByRole('button', { name: '选择第 R1 行', exact: true })
|
||
await lineNumber.hover()
|
||
expect(await lineNumber.evaluate(element => getComputedStyle(element).backgroundColor)).toBe('rgba(0, 0, 0, 0)')
|
||
const content = await section.locator('[data-review-code]').first().boundingBox()
|
||
const fileBox = await section.boundingBox()
|
||
if (content === null || fileBox === null) throw new Error('Added file must be visible')
|
||
expect(content.x - fileBox.x).toBeLessThan(70)
|
||
await lineNumber.click()
|
||
expect(await section.getByRole('textbox', { name: '留下评论…' }).count()).toBe(0)
|
||
await section.getByRole('button', { name: '添加评论', exact: true }).click()
|
||
await section.getByRole('textbox', { name: '留下评论…' }).fill(comment)
|
||
await section.locator('[data-forge-comment]').getByRole('button', { name: '添加到输入框', exact: true }).click()
|
||
await section.locator('[data-forge-review-thread="agent"]').getByText(comment, { exact: true }).waitFor()
|
||
}
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-quotes.expected.md'),
|
||
await captureStableAria(page, '[data-composer-input]', scaffold.workspaceCwd), MODE)
|
||
expect((await readPersistedEvents(scaffold, sessionId)).some(event => event.type === 'user/message'
|
||
&& event.data.content.some(block => block.type === 'text' && block.text.includes('## User Comment')))).toBe(false)
|
||
const reviewed = scaffold.whenTurnSettled()
|
||
await page.locator('[data-composer-input]').first().press('Enter')
|
||
await reviewed
|
||
await page.getByText(FOLLOW_UP_REPLY, { exact: true }).waitFor()
|
||
const comments = (await readPersistedEvents(scaffold, sessionId)).flatMap(event => event.type === 'user/message'
|
||
? event.data.content.flatMap(block => block.type === 'text' && block.text.includes('## User Comment') ? [block.text] : []) : [])
|
||
expect(comments).toHaveLength(1)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-message.expected.md'), comments.join('').trimEnd(), MODE)
|
||
|
||
// Compared with `topic`, which already has the committed `src/app.ts`, the branch scope keeps only the later changes.
|
||
await local.getByRole('button', { name: '基准分支：origin/main', exact: true }).click()
|
||
const bases = page.locator('[data-forge-base-menu]')
|
||
await bases.getByRole('menuitem', { name: 'topic', exact: true }).waitFor({ timeout: 20_000 })
|
||
await compareOrRefreshGolden(join(EXPECTED, 'base-menu.expected.md'), await captureStableAria(page, '[data-forge-base-menu]', scaffold.workspaceCwd), MODE)
|
||
await bases.getByRole('textbox', { name: '搜索分支' }).fill('TOP')
|
||
await expect.poll(() => bases.getByRole('menuitem').allTextContents()).toEqual(['topic'])
|
||
await bases.getByRole('textbox', { name: '搜索分支' }).press('Enter')
|
||
await local.getByRole('button', { name: '基准分支：topic', exact: true }).waitFor()
|
||
await expect.poll(() => files.evaluateAll(sections => sections.map(section => section.getAttribute('data-forge-diff-file'))), { timeout: 20_000 })
|
||
.toEqual(['src/extra.ts', 'README.md', 'notes.md'])
|
||
|
||
await local.getByRole('button', { name: '分支', exact: true }).click()
|
||
await page.getByRole('menuitem', { name: '已暂存', exact: true }).click()
|
||
await local.getByText('暂存区与 HEAD 比较', { exact: true }).waitFor()
|
||
await expect.poll(() => files.evaluateAll(sections => sections.map(section => section.getAttribute('data-forge-diff-file'))), { timeout: 20_000 })
|
||
.toEqual(['src/extra.ts'])
|
||
|
||
// A change request bound the way a `gh pr create` result binds one.
|
||
scaffold.ctx.forgeSession.track(session, PULL)
|
||
await expect.poll(() => header.getAttribute('aria-pressed'), { timeout: 20_000 }).toBe('false')
|
||
await header.click()
|
||
const change = page.locator(`[data-forge-change="${PULL}"]`)
|
||
await change.getByRole('link', { name: 'Add the pull request panel', exact: true }).waitFor({ timeout: 20_000 })
|
||
await card.getByRole('button', { name: '查看本会话的变更：4 个文件，新增 4 行，删除 1 行', exact: true }).waitFor()
|
||
expect(await card.getByRole('button', { name: '创建变更请求', exact: true }).count()).toBe(0)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'local-and-pr.expected.md'),
|
||
await captureStableAria(page, '[data-forge-panel]', scaffold.workspaceCwd), MODE)
|
||
await card.getByRole('button', { name: '查看本会话的变更：4 个文件，新增 4 行，删除 1 行', exact: true }).click()
|
||
await local.getByText('暂存区与 HEAD 比较', { exact: true }).waitFor()
|
||
await expect.poll(() => header.getAttribute('aria-pressed')).toBe('false')
|
||
await header.click()
|
||
await change.getByRole('button', { name: '查看 #7 的变更：新增 128 行，删除 14 行', exact: true }).click()
|
||
const view = page.locator('[data-forge-changes="change"]')
|
||
const panelFile = view.locator('[data-forge-diff-file="src/panel.ts"]')
|
||
const title = await view.getByText('Add the pull request panel', { exact: true }).boundingBox()
|
||
const submit = await view.getByRole('button', { name: '提交评审', exact: true }).boundingBox()
|
||
if (title === null || submit === null) throw new Error('PR title and submit action must be visible')
|
||
expect(Math.abs(title.y + title.height / 2 - submit.y - submit.height / 2)).toBeLessThan(1)
|
||
|
||
await panelFile.getByRole('button', { name: '6 行未变更', exact: true }).waitFor({ timeout: 20_000 })
|
||
await compareOrRefreshGolden(join(EXPECTED, 'changes-view.expected.md'),
|
||
await captureStableAria(page, '[data-forge-changes="change"]', scaffold.workspaceCwd), MODE)
|
||
await page.getByRole('button', { name: '全屏', exact: true }).click()
|
||
await view.getByRole('navigation').getByRole('button', { name: 'src/panel.ts', exact: true }).waitFor()
|
||
const fileTree = view.getByRole('navigation')
|
||
const treeIsLeft = async () => {
|
||
const tree = await fileTree.boundingBox()
|
||
const diff = await view.locator('[data-forge-changes-scroll]').boundingBox()
|
||
if (tree === null || diff === null) throw new Error('Tree and diff must be visible')
|
||
return tree.x < diff.x
|
||
}
|
||
expect(await treeIsLeft()).toBe(true)
|
||
const directoryName = await fileTree.getByText('src', { exact: true }).boundingBox()
|
||
const fileName = await fileTree.getByText('panel.ts', { exact: true }).boundingBox()
|
||
if (directoryName === null || fileName === null) throw new Error('Tree entries must be visible')
|
||
expect(fileName.x).toBeGreaterThan(directoryName.x)
|
||
await fileTree.getByRole('textbox', { name: '筛选文件…' }).fill('src')
|
||
await fileTree.getByRole('textbox', { name: '筛选文件…' }).fill('')
|
||
await fileTree.getByRole('button', { name: 'src', exact: true }).click()
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
expect(await treeIsLeft()).toBe(false)
|
||
expect(await fileTree.getByRole('button', { name: 'src', exact: true }).getAttribute('aria-expanded')).toBe('false')
|
||
await page.setViewportSize({ width: 390, height: 844 })
|
||
expect(await fileTree.isVisible()).toBe(false)
|
||
expect(await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).isVisible()).toBe(false)
|
||
await view.getByRole('button', { name: '全部 2 个文件', exact: true }).click()
|
||
await page.getByRole('menu').getByRole('textbox', { name: '筛选文件…' }).waitFor()
|
||
await page.keyboard.press('Escape')
|
||
await page.setViewportSize({ width: 1680, height: 1000 })
|
||
expect(await treeIsLeft()).toBe(false)
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
expect(await fileTree.isVisible()).toBe(false)
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
expect(await treeIsLeft()).toBe(true)
|
||
expect(await fileTree.getByRole('button', { name: 'src', exact: true }).getAttribute('aria-expanded')).toBe('false')
|
||
await fileTree.getByRole('textbox', { name: '筛选文件…' }).fill('src')
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
expect(await fileTree.getByRole('textbox', { name: '筛选文件…' }).inputValue()).toBe('src')
|
||
await compareOrRefreshGolden(join(EXPECTED, 'file-tree-toggle.expected.md'),
|
||
await captureStableAria(page, '[data-forge-changes="change"]', scaffold.workspaceCwd), MODE)
|
||
await fileTree.getByRole('textbox', { name: '筛选文件…' }).fill('')
|
||
await fileTree.getByRole('button', { name: 'src', exact: true }).click()
|
||
const resizeTree = view.getByRole('separator', { name: '调整文件树宽度', exact: true })
|
||
const originalWidth = Number(await resizeTree.getAttribute('aria-valuenow'))
|
||
const handle = await resizeTree.boundingBox()
|
||
if (handle === null) throw new Error('Tree resize handle must be visible')
|
||
await page.mouse.move(handle.x + handle.width / 2, handle.y + 100)
|
||
await page.mouse.down()
|
||
await page.mouse.move(handle.x + 80, handle.y + 100, { steps: 5 })
|
||
await page.mouse.up()
|
||
expect(Number(await resizeTree.getAttribute('aria-valuenow'))).toBeGreaterThan(originalWidth)
|
||
await resizeTree.press('Home')
|
||
expect(await fileTree.evaluate(element => element.scrollWidth <= element.clientWidth)).toBe(true)
|
||
const searchBounds = await fileTree.getByRole('textbox').boundingBox()
|
||
const treeBounds = await fileTree.boundingBox()
|
||
if (searchBounds === null || treeBounds === null) throw new Error('Tree search must be visible')
|
||
expect(searchBounds.x + searchBounds.width).toBeLessThanOrEqual(treeBounds.x + treeBounds.width)
|
||
await resizeTree.press('ArrowRight')
|
||
const resizedWidth = await resizeTree.getAttribute('aria-valuenow')
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
expect(await treeIsLeft()).toBe(false)
|
||
expect(await resizeTree.getAttribute('aria-valuenow')).toBe(resizedWidth)
|
||
await resizeTree.press('ArrowLeft')
|
||
expect(Number(await resizeTree.getAttribute('aria-valuenow'))).toBe(Number(resizedWidth) + 20)
|
||
await resizeTree.press('ArrowRight')
|
||
const rightHandle = await resizeTree.boundingBox()
|
||
if (rightHandle === null) throw new Error('Right tree resize handle must be visible')
|
||
await page.mouse.move(rightHandle.x + rightHandle.width / 2, rightHandle.y + 100)
|
||
await page.mouse.down()
|
||
await page.mouse.move(rightHandle.x - 80, rightHandle.y + 100, { steps: 5 })
|
||
await page.mouse.up()
|
||
expect(Number(await resizeTree.getAttribute('aria-valuenow'))).toBeGreaterThan(Number(resizedWidth))
|
||
const rightWidth = await resizeTree.getAttribute('aria-valuenow')
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
await view.getByRole('button', { name: /^(将文件树移到右侧|隐藏文件树|在左侧显示文件树)$/ }).click()
|
||
expect(await resizeTree.getAttribute('aria-valuenow')).toBe(rightWidth)
|
||
for (const side of ['old', 'new'] as const) {
|
||
const firstCode = panelFile.locator(`[data-review-code][data-${side}-line="2"]`)
|
||
const firstLine = await firstCode.boundingBox()
|
||
const lastLine = await panelFile.locator(`[data-review-code][data-${side}-line="4"]`).boundingBox()
|
||
if (firstLine === null || lastLine === null) throw new Error('Review text must be visible')
|
||
// Press on the first character, past the lane where the hovered row shows its comment plus.
|
||
const textStart = await firstCode.evaluate(element => Number.parseFloat(getComputedStyle(element).paddingLeft))
|
||
await page.mouse.move(firstLine.x + textStart + 1, firstLine.y + firstLine.height / 2)
|
||
await page.mouse.down()
|
||
await page.mouse.move(lastLine.x + 120, lastLine.y + lastLine.height / 2, { steps: 5 })
|
||
await page.mouse.up()
|
||
await panelFile.getByRole('button', { name: '添加评论', exact: true }).waitFor()
|
||
expect(await panelFile.getByRole('textbox', { name: '留下评论…' }).count()).toBe(0)
|
||
const opposite = panelFile.locator(`[data-diff-side="${side === 'old' ? 'R' : 'L'}"]`).first()
|
||
expect(await opposite.evaluate(element => getComputedStyle(element).userSelect)).toBe('none')
|
||
await page.keyboard.press('ControlOrMeta+c')
|
||
const copied = await page.evaluate(() => navigator.clipboard.readText())
|
||
expect(copied).toContain(side === 'old' ? 'n2 = 2' : "n2 = 'two'")
|
||
expect(copied).not.toContain(side === 'old' ? "n2 = 'two'" : 'n2 = 2')
|
||
expect(copied.match(/n3 = 3/g)).toHaveLength(1)
|
||
}
|
||
await panelFile.getByRole('button', { name: '添加评论', exact: true }).click()
|
||
await panelFile.getByRole('region', { name: '评论 R2–4', exact: true }).waitFor()
|
||
await panelFile.getByRole('textbox', { name: '留下评论…' }).fill('请核对边界条件')
|
||
await panelFile.getByRole('button', { name: 'GitHub 评论选项', exact: true }).click()
|
||
await page.getByRole('menuitem', { name: '发布单条评论', exact: true }).waitFor()
|
||
await page.keyboard.press('Escape')
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-composer.expected.md'),
|
||
await captureStableAria(page, '[data-forge-comment]', scaffold.workspaceCwd), MODE)
|
||
await page.getByRole('button', { name: '退出全屏', exact: true }).click()
|
||
const commentForm = panelFile.locator('[data-forge-comment]')
|
||
expect(await commentForm.evaluate(element => element.scrollWidth <= element.clientWidth)).toBe(true)
|
||
await page.getByRole('button', { name: '全屏', exact: true }).click()
|
||
await page.setViewportSize({ width: 390, height: 780 })
|
||
await commentForm.getByRole('textbox').focus()
|
||
expect(await commentForm.evaluate(element => element.scrollWidth <= element.clientWidth)).toBe(true)
|
||
const narrowComment = await commentForm.boundingBox()
|
||
if (narrowComment === null) throw new Error('Comment form must remain visible')
|
||
expect(narrowComment.x + narrowComment.width).toBeLessThanOrEqual(390)
|
||
await page.setViewportSize({ width: 1680, height: 1000 })
|
||
await panelFile.getByRole('button', { name: '开始评审', exact: true }).click()
|
||
// The comment starts the pending review on GitHub, and the threads read again show it there.
|
||
const pendingThread = panelFile.locator('[data-forge-thread="new-1"]')
|
||
await pendingThread.getByText('请核对边界条件', { exact: true }).waitFor({ timeout: 20_000 })
|
||
await pendingThread.getByText('待提交', { exact: true }).waitFor()
|
||
await page.setViewportSize({ width: 1680, height: 500 })
|
||
const changesScroll = view.locator('[data-forge-changes-scroll]')
|
||
await changesScroll.evaluate((element) => { element.scrollTop = element.scrollHeight })
|
||
const reviewScroll = await changesScroll.evaluate(element => element.scrollTop)
|
||
expect(reviewScroll).toBeGreaterThan(0)
|
||
await view.getByRole('button', { name: '提交评审 (1)', exact: true }).click()
|
||
const reviewDialog = page.getByRole('dialog', { name: '提交评审', exact: true })
|
||
await reviewDialog.waitFor()
|
||
expect(await reviewDialog.getByRole('textbox').count()).toBe(1)
|
||
expect(await reviewDialog.getByText('请核对边界条件', { exact: true }).count()).toBe(0)
|
||
expect(await changesScroll.evaluate(element => element.scrollTop)).toBe(reviewScroll)
|
||
await page.setViewportSize({ width: 390, height: 780 })
|
||
expect(await reviewDialog.evaluate(element => element.scrollWidth <= element.clientWidth)).toBe(true)
|
||
const narrowDialog = await reviewDialog.boundingBox()
|
||
if (narrowDialog === null) throw new Error('Review dialog must remain visible')
|
||
expect(narrowDialog.x + narrowDialog.width).toBeLessThanOrEqual(390)
|
||
await page.setViewportSize({ width: 1680, height: 500 })
|
||
await page.keyboard.press('Escape')
|
||
expect(await reviewDialog.count()).toBe(0)
|
||
await view.getByRole('button', { name: '提交评审 (1)', exact: true }).click()
|
||
await reviewDialog.getByRole('radio', { name: '请求更改', exact: true }).check()
|
||
await reviewDialog.getByText('请求更改时，请填写评审总结', { exact: true }).waitFor()
|
||
expect(await reviewDialog.getByRole('button', { name: '提交评审', exact: true }).isDisabled()).toBe(true)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-summary-required.expected.md'),
|
||
await captureStableAria(page, '[role="dialog"][aria-label="提交评审"]', scaffold.workspaceCwd), MODE)
|
||
await reviewDialog.getByRole('textbox', { name: '评审总结…', exact: true }).fill('需要补充边界检查')
|
||
await compareOrRefreshGolden(join(EXPECTED, 'submit-review.expected.md'),
|
||
await captureStableAria(page, '[role="dialog"][aria-label="提交评审"]', scaffold.workspaceCwd), MODE)
|
||
await reviewDialog.getByRole('button', { name: '提交评审', exact: true }).click()
|
||
await page.getByRole('alert').filter({ hasText: '已提交评审' }).waitFor()
|
||
await expect.poll(() => pendingThread.getByText('待提交', { exact: true }).count(), { timeout: 20_000 }).toBe(0)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-record.expected.md'),
|
||
await captureStableAria(page, '[data-forge-thread="new-1"]', scaffold.workspaceCwd), MODE)
|
||
const mutations = (await readFile(join(root, 'mutations.jsonl'), 'utf8')).trim().split('\n').map((line): unknown => JSON.parse(line))
|
||
expect(mutations).toEqual([
|
||
{ field: 'addPullRequestReview', variables: { pull: 'pull-7', commit: HEAD7,
|
||
threads: [{ path: 'src/panel.ts', body: '请核对边界条件', line: 4, side: 'RIGHT', startLine: 2, startSide: 'RIGHT' }] } },
|
||
{ field: 'submitPullRequestReview', variables: { review: 'review-1', event: 'REQUEST_CHANGES', body: '需要补充边界检查' } },
|
||
])
|
||
expect(existsSync(join(root, 'reviews.jsonl'))).toBe(false)
|
||
await page.getByRole('button', { name: '退出全屏', exact: true }).click()
|
||
await panelFile.getByRole('button', { name: '6 行未变更', exact: true }).click()
|
||
await panelFile.getByText('export const n6 = 6', { exact: true }).first().waitFor({ timeout: 20_000 })
|
||
await panelFile.getByRole('button', { name: '2 行未变更', exact: true }).waitFor()
|
||
await panelFile.getByRole('button', { name: 'panel.ts 的更多操作', exact: true }).click()
|
||
await page.getByRole('menuitem', { name: '复制路径', exact: true }).click()
|
||
await expect.poll(() => page.evaluate(() => navigator.clipboard.readText())).toBe('src/panel.ts')
|
||
const docsFile = view.locator('[data-forge-diff-file="docs/panel.md"]')
|
||
await docsFile.getByRole('button', { name: '收起 panel.md', exact: true }).click()
|
||
await page.setViewportSize({ width: 1280, height: 500 })
|
||
const scrollport = view.locator('[data-forge-changes-scroll]')
|
||
await scrollport.evaluate((element) => { element.scrollTop = 100; element.dispatchEvent(new Event('scroll')) })
|
||
await panelFile.locator('[data-forge-file-label]').click()
|
||
const position = await scrollport.evaluate(element => element.scrollTop)
|
||
expect(position).toBeGreaterThan(0)
|
||
const originalFile = await panelFile.elementHandle()
|
||
await page.getByRole('button', { name: /^(?:New session|新.*会话)$/ }).last().click()
|
||
await expect.poll(() => view.isVisible()).toBe(false)
|
||
await page.locator(`[data-row-key="session:${sessionId}"]`).click()
|
||
await panelFile.getByText('export const n6 = 6', { exact: true }).first().waitFor({ timeout: 20_000 })
|
||
expect(await panelFile.evaluate((element, original) => element === original, originalFile)).toBe(true)
|
||
await expect.poll(() => docsFile.getAttribute('data-expanded')).toBe(null)
|
||
await expect.poll(() => scrollport.evaluate(element => element.scrollTop)).toBe(position)
|
||
expect(await panelFile.locator('[data-forge-thread="new-1"]').count()).toBe(1)
|
||
await page.setViewportSize({ width: 1680, height: 1000 })
|
||
await page.locator('[data-dockkit-tab]').filter({ hasText: '#7 的变更' }).locator('[data-dockkit-tab-close]').click()
|
||
await expect.poll(() => view.count()).toBe(0)
|
||
if (await header.getAttribute('aria-pressed') !== 'true') await header.click()
|
||
await change.getByRole('button', { name: '查看 #7 的变更：新增 128 行，删除 14 行', exact: true }).click()
|
||
await panelFile.getByRole('button', { name: '6 行未变更', exact: true }).waitFor()
|
||
expect(await panelFile.locator('[data-forge-review-thread]').count()).toBe(0)
|
||
await view.getByRole('button', { name: '提交评审', exact: true }).click()
|
||
await reviewDialog.waitFor()
|
||
expect(await reviewDialog.getByRole('textbox').inputValue()).toBe('')
|
||
expect(await reviewDialog.getByRole('radio', { name: '评论', exact: true }).isChecked()).toBe(true)
|
||
await page.keyboard.press('Escape')
|
||
|
||
// Pull request 9 changes 301 files, more than the pull request diff endpoint accepts; the compare read shows every file.
|
||
scaffold.ctx.forgeSession.track(session, DRAFT)
|
||
await expect.poll(() => header.getAttribute('aria-pressed'), { timeout: 20_000 }).toBe('false')
|
||
await header.click()
|
||
const draft = page.locator(`[data-forge-change="${DRAFT}"]`)
|
||
await draft.getByRole('button', { name: '展开 #9', exact: true }).click()
|
||
await draft.getByRole('button', { name: '查看 #9 的变更：新增 30 行，删除 2 行', exact: true }).click({ timeout: 20_000 })
|
||
const wide = page.locator('[data-forge-changes="change"]').filter({ hasText: 'Add the merge button' })
|
||
await wide.getByRole('region', { name: '全部 301 个文件', exact: true }).waitFor({ timeout: 20_000 })
|
||
expect(await wide.locator('[data-forge-diff-file]').count()).toBe(301)
|
||
|
||
// A push moves the head to a commit whose diff GitHub refuses over its size limit, so a newly opened view offers the web page
|
||
// instead of a retry.
|
||
await page.locator('[data-dockkit-tab]').filter({ hasText: '#9 的变更' }).locator('[data-dockkit-tab-close]').click()
|
||
await expect.poll(() => wide.count()).toBe(0)
|
||
await writeFile(join(root, 'state.json'), JSON.stringify({ ready: false, mergedAt: null, head: 'd'.repeat(40) }))
|
||
await writeFile(join(root, 'pr-9.refused'), PR9_REFUSAL)
|
||
scaffold.ctx.forge.refresh({ repository: { forge: 'github', host: 'github.com', owner: 'octo', name: 'demo' }, number: 9 })
|
||
await expect.poll(() => scaffold.ctx.forge.latest({ repository: { forge: 'github', host: 'github.com', owner: 'octo', name: 'demo' }, number: 9 }),
|
||
{ timeout: 20_000 }).toMatchObject({ snapshot: { headSha: 'd'.repeat(40) } })
|
||
if (await header.getAttribute('aria-pressed') !== 'true') await header.click()
|
||
const expand = draft.getByRole('button', { name: '展开 #9', exact: true })
|
||
if (await expand.count() > 0) await expand.click()
|
||
await draft.getByRole('button', { name: '查看 #9 的变更：新增 30 行，删除 2 行', exact: true }).click({ timeout: 20_000 })
|
||
await wide.getByRole('status').filter({ hasText: '变更太大，无法在这里显示' }).waitFor({ timeout: 20_000 })
|
||
await wide.getByRole('button', { name: '在浏览器中查看', exact: true }).waitFor()
|
||
expect(await wide.getByRole('button', { name: '重试', exact: true }).count()).toBe(0)
|
||
|
||
const calls = (await readFile(join(root, 'calls.jsonl'), 'utf8')).trim().split('\n').map(line => JSON.parse(line) as string[])
|
||
const compared = (head: string) => [
|
||
'api', '--hostname', 'github.com', '--allow-escape-sequences', '-H', 'Accept: application/vnd.github.diff',
|
||
`repos/octo/demo/compare/${'e'.repeat(40)}...${head}`,
|
||
]
|
||
expect(calls).toContainEqual(compared(HEAD7))
|
||
expect(calls).toContainEqual(compared('b'.repeat(40)))
|
||
expect(calls).toContainEqual(compared('d'.repeat(40)))
|
||
expect(calls.some(call => call[0] === 'pr' && call[1] === 'diff')).toBe(false)
|
||
expect(calls).toContainEqual([
|
||
'api', '--hostname', 'github.com', '-H', 'Accept: application/vnd.github.raw+json', `repos/octo/demo/contents/src/panel.ts?ref=${HEAD7}`,
|
||
])
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
|
||
it.skipIf(MODE === 'record')('retains a wrapped code line and tree width across tab and Session switches', async () => {
|
||
const { page, scaffold, root, tripwire } = await launchPanel('web-e2e-forge-reading-position')
|
||
const paths = ['src/before-0.ts', 'src/before-1.ts', 'src/before-2.ts', 'src/server.ts', 'src/after.ts']
|
||
const patch = paths.map(path => [
|
||
`diff --git a/${path} b/${path}`, 'index 1111111..2222222 100644', `--- a/${path}`, `+++ b/${path}`,
|
||
'@@ -1,650 +1,650 @@', '-const oldValue = true;', '+const newValue = true;',
|
||
...Array.from({ length: 649 }, (_, index) => ` const value_${index + 2} = "${'x'.repeat(24 + (index + 2) % 70)}";`), '',
|
||
].join('\n')).join('\n')
|
||
await writeFile(join(root, 'pr-7.diff'), patch)
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('Session must stay loaded')
|
||
scaffold.ctx.forgeSession.track(session, PULL)
|
||
// Keep the file tree and the Session sidebar visible together on every platform.
|
||
await page.setViewportSize({ width: 2400, height: 700 })
|
||
await page.locator('[data-forge-header]').click()
|
||
await page.locator(`[data-forge-change="${PULL}"]`).getByRole('button', { name: /查看 #7 的变更/ }).click()
|
||
const view = page.locator('[data-forge-changes="change"]')
|
||
const scroll = view.locator('[data-forge-changes-scroll]')
|
||
const file = view.locator('[data-forge-diff-file="src/server.ts"]')
|
||
const code = file.locator('[data-review-code][data-new-line="300"]')
|
||
const separator = view.getByRole('separator', { name: '调整文件树宽度', exact: true })
|
||
const beforeFile = view.locator('[data-forge-diff-file="src/before-0.ts"]')
|
||
// ResizeObserver runs between rendering frames, including when an ancestor becomes hidden.
|
||
const layout = () => page.evaluate(() => new Promise<void>((resolve) => {
|
||
requestAnimationFrame(() => { requestAnimationFrame(() => { resolve() }) })
|
||
}))
|
||
const reading = () => file.evaluate((element) => {
|
||
const viewport = element.closest('[data-forge-changes-scroll]')!
|
||
const top = Math.max(viewport.getBoundingClientRect().top, element.firstElementChild!.getBoundingClientRect().bottom)
|
||
const line = [...element.querySelectorAll<HTMLElement>('[data-review-code][data-new-line]')]
|
||
.find(row => row.getBoundingClientRect().bottom > top + 1)!
|
||
return { path: element.getAttribute('data-forge-diff-file'), line: line.dataset.newLine,
|
||
offset: line.getBoundingClientRect().top - top, scrollTop: viewport.scrollTop }
|
||
})
|
||
// An expanded file draws its lines once the reader scrolls near it.
|
||
await file.scrollIntoViewIfNeeded()
|
||
await code.waitFor()
|
||
for (const width of [240, 320]) {
|
||
if (width === 320) {
|
||
for (let step = 0; step < 4; step += 1) await separator.press('ArrowRight')
|
||
await beforeFile.getByRole('button', { name: '收起 before-0.ts', exact: true }).click()
|
||
}
|
||
await layout()
|
||
await code.evaluate((element) => {
|
||
const viewport = element.closest('[data-forge-changes-scroll]')!
|
||
const header = element.closest('[data-forge-diff-file]')!.firstElementChild!
|
||
const top = viewport.getBoundingClientRect().top + header.getBoundingClientRect().height
|
||
viewport.scrollTop += element.getBoundingClientRect().top - top + 7
|
||
})
|
||
await layout()
|
||
const position = await reading()
|
||
expect(position.line).toBe('300')
|
||
expect(position.offset).toBe(-7)
|
||
for (const destination of ['tab', 'session', 'tab', 'session']) {
|
||
if (destination === 'tab') await page.getByRole('tab').filter({ hasText: '变更请求' }).click()
|
||
else await page.getByRole('button', { name: '新建会话', exact: true }).last().click()
|
||
await expect.poll(() => view.isVisible()).toBe(false)
|
||
await layout()
|
||
expect(await scroll.evaluate(element => element.clientWidth)).toBe(0)
|
||
if (destination === 'tab') await page.getByRole('tab').filter({ hasText: '#7 的变更' }).click()
|
||
else await page.locator(`[data-row-key="session:${sessionId}"]`).click()
|
||
await view.waitFor()
|
||
await layout()
|
||
expect(await separator.getAttribute('aria-valuenow')).toBe(String(width))
|
||
expect(await reading()).toEqual(position)
|
||
expect(await beforeFile.getAttribute('data-expanded')).toBe(width === 240 ? '' : null)
|
||
}
|
||
}
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('uses horizontal arrows to navigate files while preserving vertical scrolling and comment editing', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-file-keys')
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await mkdir(join(project, 'src'))
|
||
for (const path of ['src/a.txt', 'src/b.txt', 'README.md']) {
|
||
await writeFile(join(project, path), Array.from({ length: path === 'README.md' ? 1 : 80 }, (_, line) => `line ${line + 1}\n`).join(''))
|
||
}
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.locator('[data-forge-header]').click()
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
await page.locator('[data-forge-local]').getByRole('button', { name: /查看本会话的变更：3 个文件/ }).click()
|
||
const view = page.locator('[data-forge-changes="local"]')
|
||
const scroll = view.getByRole('region', { name: '全部 3 个文件', exact: true })
|
||
await scroll.waitFor()
|
||
await page.getByRole('button', { name: '全屏', exact: true }).click()
|
||
await page.setViewportSize({ width: 1280, height: 500 })
|
||
const tree = view.getByRole('navigation')
|
||
const files = view.locator('[data-forge-diff-file]')
|
||
const paths = await files.evaluateAll(elements => elements.map(element => element.getAttribute('data-forge-diff-file')))
|
||
expect(paths).toEqual(['src/a.txt', 'src/b.txt', 'README.md'])
|
||
expect(await tree.locator('button:not([aria-expanded])').evaluateAll(elements => elements.map(element => element.getAttribute('aria-label')))).toEqual(paths)
|
||
const a = view.locator('[data-forge-diff-file="src/a.txt"]')
|
||
const b = view.locator('[data-forge-diff-file="src/b.txt"]')
|
||
const c = view.locator('[data-forge-diff-file="README.md"]')
|
||
await b.getByRole('button', { name: '收起 b.txt', exact: true }).click()
|
||
await scroll.evaluate((element) => { element.scrollTop = 0 })
|
||
await scroll.focus()
|
||
await page.keyboard.press('ArrowLeft')
|
||
expect(await scroll.evaluate(element => element.scrollTop)).toBe(0)
|
||
expect(await scroll.evaluate(element => getComputedStyle(element).outlineStyle)).toBe('none')
|
||
await page.keyboard.press('ArrowDown')
|
||
await expect.poll(() => scroll.evaluate(element => element.scrollTop)).toBeGreaterThan(0)
|
||
await scroll.evaluate((element) => { element.scrollTop = 0 })
|
||
await page.keyboard.press('ArrowRight')
|
||
await expect.poll(() => tree.getByRole('button', { name: 'src/b.txt', exact: true }).getAttribute('aria-current')).toBe('true')
|
||
expect(await b.getAttribute('data-expanded')).toBe('')
|
||
expect(await scroll.evaluate(element => document.activeElement === element)).toBe(true)
|
||
await page.keyboard.press('ArrowRight')
|
||
await expect.poll(() => tree.getByRole('button', { name: 'README.md', exact: true }).getAttribute('aria-current')).toBe('true')
|
||
// The last file draws its lines after the jump, and scroll anchoring adjusts the position at the next layout.
|
||
await c.locator('[data-review-code]').first().waitFor()
|
||
await scroll.evaluate(() => new Promise<void>((resolve) => {
|
||
requestAnimationFrame(() => { requestAnimationFrame(() => { resolve() }) })
|
||
}))
|
||
const lastPosition = await scroll.evaluate(element => element.scrollTop)
|
||
const lastBox = await c.boundingBox(), viewport = await scroll.boundingBox()
|
||
if (lastBox === null || viewport === null) throw new Error('The last file and scroll viewport must be rendered')
|
||
expect(lastBox.y).toBeGreaterThan(viewport.y)
|
||
expect(lastBox.y).toBeLessThan(viewport.y + viewport.height)
|
||
await page.keyboard.press('ArrowRight')
|
||
expect(await scroll.evaluate(element => element.scrollTop)).toBe(lastPosition)
|
||
await page.keyboard.press('ArrowLeft')
|
||
await expect.poll(() => tree.getByRole('button', { name: 'src/b.txt', exact: true }).getAttribute('aria-current')).toBe('true')
|
||
await page.keyboard.press('ArrowLeft')
|
||
await expect.poll(() => tree.getByRole('button', { name: 'src/a.txt', exact: true }).getAttribute('aria-current')).toBe('true')
|
||
await b.evaluate((element) => {
|
||
const viewport = element.closest('[data-forge-changes-scroll]')!
|
||
viewport.scrollTop += element.getBoundingClientRect().top - viewport.getBoundingClientRect().top + 100
|
||
})
|
||
await page.keyboard.press('ArrowRight')
|
||
await expect.poll(() => tree.getByRole('button', { name: 'README.md', exact: true }).getAttribute('aria-current')).toBe('true')
|
||
await tree.getByRole('button', { name: 'src/a.txt', exact: true }).click()
|
||
await a.getByRole('button', { name: '选择第 R1 行', exact: true }).click()
|
||
await a.getByRole('button', { name: '添加评论', exact: true }).click()
|
||
const input = a.getByRole('textbox', { name: '留下评论…', exact: true })
|
||
await input.fill('keep editing')
|
||
await input.press('ArrowLeft')
|
||
expect(await input.evaluate(element => (element as HTMLTextAreaElement).selectionStart)).toBe(11)
|
||
await input.press('ArrowRight')
|
||
expect(await input.inputValue()).toBe('keep editing')
|
||
expect(await tree.getByRole('button', { name: 'src/a.txt', exact: true }).getAttribute('aria-current')).toBe('true')
|
||
expect(await input.evaluate(element => document.activeElement === element)).toBe(true)
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('opens a comment from the hover plus in one press without covering the line number or the code', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-hover-plus')
|
||
// notes.txt changes into context, a deletion followed by context, and an addition, so unified rows show both numbers.
|
||
await writeFile(join(project, 'notes.txt'), ['keep 1', 'keep 2', 'drop 3', 'keep 4', 'keep 5', 'keep 6'].map(line => `${line}\n`).join(''))
|
||
await git(project, 'add', 'notes.txt')
|
||
await git(project, 'commit', '--quiet', '-m', 'notes')
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await writeFile(join(project, 'README.md'), `changed\n${Array.from({ length: 8 }, (_, line) => `line ${line + 2}\n`).join('')}`)
|
||
await writeFile(join(project, 'notes.txt'), ['keep 1', 'keep 2', 'keep 4', 'keep 5', 'added', 'keep 6'].map(line => `${line}\n`).join(''))
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.locator('[data-forge-header]').click()
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
await page.locator('[data-forge-local]').getByRole('button', { name: /查看本会话的变更/ }).click()
|
||
const view = page.locator('[data-forge-changes="local"]')
|
||
const file = view.locator('[data-forge-diff-file="README.md"]')
|
||
const number = (name: string) => file.getByRole('button', { name: `选择第 ${name} 行`, exact: true })
|
||
const plus = (name: string) => file.locator(`[data-review-add="${name}"]`)
|
||
const code = (line: number) => file.locator(`[data-review-code][data-new-line="${line}"]`)
|
||
const draggable = async (from: string, to: string) => {
|
||
const start = await plus(from).boundingBox(), end = await number(to).boundingBox()
|
||
if (start === null || end === null) throw new Error('The plus and the line number must be rendered')
|
||
const x = start.x + start.width / 2
|
||
return { start: { x, y: start.y + start.height / 2 }, end: { x, y: end.y + end.height / 2 } }
|
||
}
|
||
await number('R3').waitFor()
|
||
|
||
// The plus appears only on the hovered side of the hovered row, for the code as for the line number.
|
||
expect(await plus('R3').isVisible()).toBe(false)
|
||
await code(3).hover()
|
||
expect(await plus('R3').isVisible()).toBe(true)
|
||
expect(await plus('R4').isVisible()).toBe(false)
|
||
expect(await plus('L1').isVisible()).toBe(false)
|
||
await number('L1').hover()
|
||
expect(await plus('L1').isVisible()).toBe(true)
|
||
expect(await plus('R3').isVisible()).toBe(false)
|
||
|
||
// Playwright refuses a click on a covered point, so these prove the hovered number and first character stay reachable.
|
||
await number('R3').hover()
|
||
await number('R3').click()
|
||
expect(await number('R3').getAttribute('aria-pressed')).toBe('true')
|
||
const first = await code(5).boundingBox()
|
||
const textStart = await code(5).evaluate(element => Number.parseFloat(getComputedStyle(element).paddingLeft))
|
||
if (first === null) throw new Error('Review text must be visible')
|
||
await page.mouse.move(first.x + textStart + 1, first.y + first.height / 2)
|
||
await page.mouse.down()
|
||
await page.mouse.move(first.x + textStart + 30, first.y + first.height / 2, { steps: 3 })
|
||
await page.mouse.up()
|
||
expect(await page.evaluate(() => document.getSelection()?.toString())).toMatch(/^li/)
|
||
await page.evaluate(() => { document.getSelection()?.removeAllRanges() })
|
||
|
||
// One press selects, a drag extends within the side, and the release opens the editor.
|
||
await code(6).hover()
|
||
const { start, end } = await draggable('R6', 'R8')
|
||
await page.mouse.move(start.x, start.y)
|
||
await page.mouse.down()
|
||
await page.mouse.move(end.x, end.y, { steps: 5 })
|
||
expect(await number('R8').getAttribute('aria-pressed')).toBe('true')
|
||
expect(await file.getByRole('textbox').count()).toBe(0)
|
||
await page.mouse.up()
|
||
await file.getByRole('region', { name: '评论 R6–8', exact: true }).waitFor()
|
||
// The open editor leaves the hover plus for the next comment.
|
||
await code(3).hover()
|
||
expect(await plus('R3').isVisible()).toBe(true)
|
||
await file.getByRole('button', { name: '取消', exact: true }).click()
|
||
await file.getByRole('textbox').waitFor({ state: 'detached' })
|
||
|
||
// The single-column layout keeps the same gesture on the line's own side.
|
||
await view.getByRole('button', { name: '左右对比', exact: true }).click()
|
||
await file.locator('[data-diff-line]').first().waitFor()
|
||
await code(4).hover()
|
||
expect(await plus('R4').isVisible()).toBe(true)
|
||
await number('R4').click()
|
||
expect(await number('R4').getAttribute('aria-pressed')).toBe('true')
|
||
|
||
// With both numbers shown, a deleted line's plus sits where a context line's does: in the sign column.
|
||
const notes = view.locator('[data-forge-diff-file="notes.txt"]')
|
||
const notesPlus = (name: string) => notes.locator(`[data-review-add="${name}"]`)
|
||
const notesCode = (side: 'old' | 'new', line: number) => notes.locator(`[data-review-code][data-${side}-line="${line}"]`)
|
||
await notesCode('new', 3).hover()
|
||
const contextPlus = await notesPlus('R3').boundingBox()
|
||
await notesCode('old', 3).hover()
|
||
const deletedPlus = await notesPlus('L3').boundingBox()
|
||
const nextRow = await notesCode('old', 4).boundingBox()
|
||
if (contextPlus === null || deletedPlus === null || nextRow === null) throw new Error('The pluses and the next row must be rendered')
|
||
expect(deletedPlus.x).toBe(contextPlus.x)
|
||
// A drag from the deleted line's plus extends through the context row below it on the old side.
|
||
const x = deletedPlus.x + deletedPlus.width / 2
|
||
await page.mouse.move(x, deletedPlus.y + deletedPlus.height / 2)
|
||
await page.mouse.down()
|
||
await page.mouse.move(x, nextRow.y + nextRow.height / 2, { steps: 5 })
|
||
await page.mouse.up()
|
||
await notes.getByRole('region', { name: '评论 L3–4', exact: true }).waitFor()
|
||
await notes.getByRole('button', { name: '取消', exact: true }).click()
|
||
await notes.getByRole('textbox').waitFor({ state: 'detached' })
|
||
// The labeled plus of a left context line stays reachable; Playwright refuses a covered target.
|
||
await notes.getByRole('button', { name: '选择第 L2 行', exact: true }).click()
|
||
expect((await notes.getByRole('button', { name: '添加评论', exact: true }).boundingBox())?.x).toBe(contextPlus.x)
|
||
await notes.getByRole('button', { name: '添加评论', exact: true }).click()
|
||
await notes.getByRole('region', { name: '评论 L2', exact: true }).waitFor()
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('keeps tall branch and changed-file menus aligned with their triggers', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-tall-menus')
|
||
await Promise.all(Array.from({ length: 45 }, (_, index) =>
|
||
git(project, 'update-ref', `refs/heads/worktree/long-menu-regression-${index}`, 'HEAD')))
|
||
const option = page.locator('[data-forge-worktree]')
|
||
await option.getByRole('checkbox', { name: '新建工作树', exact: true }).check()
|
||
const base = option.getByRole('button', { name: '基于 main', exact: true })
|
||
await base.click()
|
||
const menu = page.getByRole('menu')
|
||
await menu.getByRole('menuitem', { name: 'worktree/long-menu-regression-44', exact: true }).waitFor()
|
||
await expect.poll(async () => {
|
||
const trigger = await base.boundingBox()
|
||
const card = await menu.boundingBox()
|
||
return trigger === null || card === null ? Infinity : Math.abs(trigger.x + trigger.width - card.x - card.width)
|
||
}).toBeLessThan(1)
|
||
await page.keyboard.press('Escape')
|
||
expect(await base.getAttribute('aria-expanded')).toBe('false')
|
||
await option.getByRole('checkbox', { name: '新建工作树', exact: true }).uncheck()
|
||
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await mkdir(join(project, 'src'))
|
||
await Promise.all(Array.from({ length: 60 }, (_, index) =>
|
||
writeFile(join(project, 'src', `long-file-list-${index}.ts`), `export const value = ${index}\n`)))
|
||
await git(project, 'add', 'src')
|
||
await git(project, 'commit', '--quiet', '-m', 'long file list')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.locator('[data-forge-header]').click()
|
||
const panel = page.locator('[data-forge-panel]')
|
||
await panel.getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
await panel.getByRole('button', { name: /^查看本会话的变更：60 个文件/ }).click()
|
||
const changes = page.locator('[data-forge-changes="local"]')
|
||
const files = changes.getByRole('button', { name: '全部 60 个文件', exact: true })
|
||
await files.click()
|
||
await menu.getByRole('textbox', { name: '筛选文件…', exact: true }).waitFor()
|
||
await expect.poll(async () => {
|
||
const trigger = await files.boundingBox()
|
||
const card = await menu.boundingBox()
|
||
return trigger === null || card === null ? Infinity : Math.abs(trigger.x - card.x)
|
||
}).toBeLessThan(1)
|
||
await menu.getByRole('textbox', { name: '筛选文件…', exact: true }).fill('long-file-list-59')
|
||
expect(await menu.getByRole('menuitem', { name: 'src/long-file-list-59.ts', exact: true }).isVisible()).toBe(true)
|
||
await page.keyboard.press('Escape')
|
||
expect(await menu.count()).toBe(0)
|
||
await page.setViewportSize({ width: 390, height: 700 })
|
||
await files.click()
|
||
await menu.getByRole('textbox', { name: '筛选文件…', exact: true }).waitFor()
|
||
await expect.poll(() => menu.evaluate((node) => {
|
||
const rect = node.getBoundingClientRect()
|
||
return rect.left >= 12 && rect.right <= 378 && rect.top >= 12 && rect.bottom <= 688
|
||
})).toBe(true)
|
||
await page.keyboard.press('Escape')
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('keeps localized status columns separate and long file lists inside one vertical scroller', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-layout')
|
||
await page.locator('[data-forge-current-branch]').waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'worktree-option.expected.md'),
|
||
await captureStableAria(page, '[data-forge-worktree]', scaffold.workspaceCwd), MODE)
|
||
await page.getByRole('button', { name: '收起侧边栏', exact: true }).click()
|
||
await page.setViewportSize({ width: 390, height: 844 })
|
||
await expect.poll(() => page.locator('[data-forge-worktree]')
|
||
.evaluate(element => element.getBoundingClientRect().right)).toBeLessThanOrEqual(390)
|
||
await page.setViewportSize({ width: 1680, height: 1000 })
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await mkdir(join(project, 'src'))
|
||
await Promise.all(Array.from({ length: 60 }, (_, index) => writeFile(join(project, 'src', `file-${index}.ts`), `export const value = ${index}\n`)))
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const session = scaffold.ctx.sessions.get(await settled)
|
||
if (session === undefined) throw new Error('The Session must stay loaded')
|
||
scaffold.ctx.forgeSession.track(session, PULL)
|
||
await page.locator('[data-forge-header]').click()
|
||
const panel = page.locator('[data-forge-panel]')
|
||
await panel.getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
const local = panel.locator('[data-forge-local]')
|
||
await local.locator('button[aria-expanded]').click()
|
||
await expect.poll(() => local.locator('li').count(), { timeout: 20_000 }).toBe(60)
|
||
for (const width of [1280, 390]) {
|
||
await page.setViewportSize({ width, height: 700 })
|
||
const outerScrollers = await panel.evaluate((element) => {
|
||
const scrollers: string[] = []
|
||
for (let ancestor = element.parentElement; ancestor !== null; ancestor = ancestor.parentElement) {
|
||
if (/auto|scroll/.test(getComputedStyle(ancestor).overflowY) && ancestor.scrollHeight > ancestor.clientHeight + 1) {
|
||
scrollers.push(ancestor.className)
|
||
}
|
||
}
|
||
return scrollers
|
||
})
|
||
expect(outerScrollers).toEqual([])
|
||
expect(await panel.evaluate(element => element.scrollHeight > element.clientHeight)).toBe(true)
|
||
await local.locator('li').last().scrollIntoViewIfNeeded()
|
||
expect(await local.locator('li').last().isVisible()).toBe(true)
|
||
}
|
||
await local.locator('button[aria-expanded]').click()
|
||
const change = panel.locator(`[data-forge-change="${PULL}"]`)
|
||
for (const [locale, labels] of [
|
||
['zh', ['检查', '评审', '合并', '变更']],
|
||
['en', ['Checks', 'Review', 'Merge', 'Changes']],
|
||
['de', ['Prüfungen', 'Review', 'Zusammenführen', 'Änderungen']],
|
||
] as const) {
|
||
await scaffold.ctx.settings.update('locale', { preference: locale })
|
||
await change.getByText(labels[0], { exact: true }).waitFor()
|
||
if (locale === 'en') {
|
||
await compareOrRefreshGolden(join(EXPECTED, 'local-card.expected.md'),
|
||
await captureStableAria(page, '[data-forge-local]', scaffold.workspaceCwd), MODE)
|
||
}
|
||
for (const width of [1280, 390]) {
|
||
await page.setViewportSize({ width, height: 700 })
|
||
await expect.poll(() => change.evaluate(element => element.getBoundingClientRect().right)).toBeLessThanOrEqual(width)
|
||
await change.getByText(labels[3], { exact: true }).hover()
|
||
for (const label of labels) {
|
||
const geometry = await change.getByText(label, { exact: true }).evaluate((element) => {
|
||
const value = element.nextElementSibling
|
||
if (value === null) throw new Error('Status label must have a value')
|
||
const range = document.createRange()
|
||
range.selectNodeContents(element)
|
||
const name = range.getBoundingClientRect()
|
||
const content = value.getBoundingClientRect()
|
||
const row = element.parentElement!
|
||
const icon = element.previousElementSibling!
|
||
const rowRect = row.getBoundingClientRect()
|
||
return {
|
||
gap: content.left - name.right,
|
||
iconInset: icon.getBoundingClientRect().left - rowRect.left,
|
||
rowInset: rowRect.left - row.closest('[data-forge-change]')!.getBoundingClientRect().left,
|
||
labelWidth: element.getBoundingClientRect().width,
|
||
valueOffset: content.left - rowRect.left,
|
||
right: content.right,
|
||
width: document.documentElement.clientWidth,
|
||
}
|
||
})
|
||
expect(geometry.gap).toBeGreaterThanOrEqual(8)
|
||
expect(geometry.iconInset).toBe(8)
|
||
expect(geometry.rowInset).toBeGreaterThanOrEqual(6)
|
||
expect(geometry.rowInset).toBeLessThanOrEqual(7)
|
||
if (locale === 'zh') {
|
||
expect(geometry.labelWidth).toBe(32)
|
||
expect(geometry.valueOffset).toBe(76)
|
||
}
|
||
expect(geometry.right).toBeLessThanOrEqual(geometry.width)
|
||
}
|
||
}
|
||
}
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('keeps long branch details accessible by touch and keyboard across the hero row breakpoints', async () => {
|
||
const branch = 'feature/a-long-current-branch-name-for-mobile-review'
|
||
const { page, scaffold, tripwire } = await launchPanel('web-e2e-forge-branch-details', 'normal', { branch, hasTouch: true })
|
||
const option = page.locator('[data-forge-worktree]')
|
||
const chip = option.locator('[data-forge-current-branch]')
|
||
await chip.waitFor()
|
||
await page.getByRole('button', { name: '收起侧边栏', exact: true }).click()
|
||
for (const [locale, label] of [['zh', `当前分支：${branch}`], ['en', `Current branch: ${branch}`], ['de', `Aktueller Branch: ${branch}`]] as const) {
|
||
await scaffold.ctx.settings.update('locale', { preference: locale })
|
||
await option.getByRole('button', { name: label, exact: true }).waitFor()
|
||
for (const width of [390, 600, 601, 700, 1280]) {
|
||
await page.setViewportSize({ width, height: 844 })
|
||
await chip.scrollIntoViewIfNeeded()
|
||
await expect.poll(() => option.evaluate((element) => {
|
||
const row = element.closest('[class*="heroWorkspaceRow"]')!
|
||
const ancestors: Element[] = []
|
||
for (let node: Element | null = row; node !== null; node = node.parentElement) ancestors.push(node)
|
||
return {
|
||
fits: element.getBoundingClientRect().right <= innerWidth,
|
||
overflow: ancestors.filter(node => node.scrollWidth > node.clientWidth + 1).map(node => node.className),
|
||
}
|
||
})).toEqual({ fits: true, overflow: [] })
|
||
}
|
||
}
|
||
await scaffold.ctx.settings.update('locale', { preference: 'en' })
|
||
await option.getByRole('button', { name: `Current branch: ${branch}`, exact: true }).waitFor()
|
||
await page.setViewportSize({ width: 390, height: 844 })
|
||
expect(await chip.locator('span').evaluate(element => element.scrollWidth > element.clientWidth)).toBe(true)
|
||
const tooltip = page.getByRole('tooltip', { exact: true, name: `Current branch: ${branch}` })
|
||
await chip.tap()
|
||
await tooltip.waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'branch-details.expected.md'), await tooltip.ariaSnapshot(), MODE)
|
||
await chip.tap()
|
||
await tooltip.waitFor({ state: 'hidden' })
|
||
await chip.tap()
|
||
await tooltip.waitFor()
|
||
await page.locator('[class*="heroWorkspaceRow"]').tap({ position: { x: 1, y: 1 } })
|
||
await tooltip.waitFor({ state: 'hidden' })
|
||
await chip.focus()
|
||
await page.keyboard.press('Tab')
|
||
await page.keyboard.press('Shift+Tab')
|
||
await tooltip.waitFor()
|
||
await page.keyboard.press('Escape')
|
||
await tooltip.waitFor({ state: 'hidden' })
|
||
await page.keyboard.press('Enter')
|
||
await tooltip.waitFor()
|
||
await page.keyboard.press('Escape')
|
||
await tooltip.waitFor({ state: 'hidden' })
|
||
expect(await option.getByRole('checkbox').isChecked()).toBe(false)
|
||
expect(await page.getByRole('menu').count()).toBe(0)
|
||
await scaffold.ctx.settings.update('locale', { preference: 'zh' })
|
||
await option.getByRole('checkbox', { name: '新建工作树', exact: true }).waitFor()
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record').each(['darwin', 'win32'] as const)('closes diff menus when the %s desktop shortcut deactivates a retained tab', async (platform) => {
|
||
const { page, scaffold, project, tripwire } = await launchPanel(`web-e2e-forge-menu-${platform}`, 'normal', { desktop: platform })
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await writeFile(join(project, 'README.md'), 'review this change\n')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
await page.locator('[data-forge-header]').click()
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
await page.locator('[data-forge-local]').getByRole('button', { name: /查看本会话的变更：1 个文件/ }).click()
|
||
const view = page.locator('[data-forge-changes="local"]')
|
||
await view.locator('[data-forge-diff-file="README.md"]').waitFor()
|
||
for (const name of ['分支', '全部 1 个文件', 'README.md 的更多操作']) {
|
||
await view.getByRole('button', { name, exact: true }).click()
|
||
await page.getByRole('menu').waitFor()
|
||
await page.evaluate((mac) => { window.forgeKeyboard.deliver({
|
||
kind: 'keyboard', frameName: '', revision: window.forgeKeyboard.revision, code: 'KeyN',
|
||
meta: mac, control: !mac, alt: false, shift: false, repeat: false,
|
||
}) }, platform === 'darwin')
|
||
await expect.poll(() => view.isVisible()).toBe(false)
|
||
await expect.poll(() => page.getByRole('menu').count()).toBe(0)
|
||
await page.locator(`[data-row-key="session:${sessionId}"]`).click()
|
||
await view.waitFor()
|
||
await expect.poll(() => page.getByRole('menu').count()).toBe(0)
|
||
}
|
||
expect(tripwire.warnings).toEqual([])
|
||
})
|
||
|
||
|
||
it.skipIf(MODE === 'record')('archives a clean UI worktree and restores its retained branch', async () => {
|
||
const { scaffold, page, project, tripwire } = await requestReleaseWorktree('web-e2e-forge-archive')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('The completed Session was not retained')
|
||
const directory = scaffold.ctx.workingDirectory.get(session)
|
||
const branch = await git(directory, 'branch', '--show-current')
|
||
const head = await git(directory, 'rev-parse', 'HEAD')
|
||
const title = '工作树归档恢复'
|
||
await scaffold.ctx.sessionController.rename({ sessionId, title })
|
||
const row = page.getByRole('treeitem').filter({ has: page.getByText(title, { exact: true }) })
|
||
await row.hover()
|
||
await row.getByRole('button', { name: '归档会话', exact: true }).click()
|
||
await expect.poll(async () => {
|
||
try { await access(directory); return true } catch { return false }
|
||
}, { timeout: 20_000 }).toBe(false)
|
||
expect(scaffold.ctx.workspaceRegistry.archivedSessionIds).toContain(sessionId)
|
||
expect(await git(project, 'rev-parse', branch)).toBe(head)
|
||
await page.getByRole('button', { name: '视图选项', exact: true }).click()
|
||
await page.getByRole('menuitem', { name: '全部对话（显示已归档）', exact: true }).click()
|
||
await row.hover()
|
||
await row.getByRole('button', { name: '取消归档', exact: true }).click()
|
||
await row.click()
|
||
const missing = page.locator('[data-forge-missing]')
|
||
await missing.getByRole('button', { name: '恢复工作树', exact: true }).waitFor({ timeout: 20_000 })
|
||
await compareOrRefreshGolden(join(EXPECTED, 'archive-restore.expected.md'),
|
||
await captureStableAria(page, '[data-forge-missing]', scaffold.workspaceCwd, { replacements: [[branch, 'dsh-{{worktree}}']] }), MODE)
|
||
expect(scaffold.ctx.workingDirectory.get(session)).toBe(directory)
|
||
await missing.getByRole('button', { name: '恢复工作树', exact: true }).click()
|
||
await missing.waitFor({ state: 'detached', timeout: 20_000 })
|
||
expect(await git(directory, 'rev-parse', 'HEAD')).toBe(head)
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record').each([120, 4000])('types a review comment beside %i changed lines', async (count) => {
|
||
const { scaffold, page, root, tripwire } = await launchPanel('web-e2e-forge-review-typing')
|
||
const patch = ['diff --git a/src/typing.ts b/src/typing.ts', 'index 1111111..2222222 100644',
|
||
'--- a/src/typing.ts', '+++ b/src/typing.ts', `@@ -1,${count} +1,${count} @@`,
|
||
...Array.from({ length: count }, (_, index) => {
|
||
const context = index % 80 === 0 ? 'wrapped context '.repeat(600) : index % 5 === 0 ? 'context '.repeat(30) : ''
|
||
return `-export const value${index} = [${index}, '${context}']\n+export const value${index} = [${index + 1}, '${context}']`
|
||
}), ''].join('\n')
|
||
await writeFile(join(root, 'pr-7.diff'), patch)
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('Session must stay loaded')
|
||
scaffold.ctx.forgeSession.track(session, PULL)
|
||
await page.locator('[data-forge-header]').click()
|
||
const change = page.locator(`[data-forge-change="${PULL}"]`)
|
||
await change.getByRole('button', { name: '查看 #7 的变更：新增 128 行，删除 14 行', exact: true }).click()
|
||
const file = page.locator('[data-forge-diff-file="src/typing.ts"]')
|
||
const collapsed = file.getByRole('button', { name: /^文件较大，/ })
|
||
await file.waitFor()
|
||
if (count > 120) await collapsed.click()
|
||
await file.getByRole('button', { name: '选择第 R5 行', exact: true }).click()
|
||
await file.getByRole('button', { name: '添加评论', exact: true }).click()
|
||
const input = file.getByRole('textbox', { name: '留下评论…', exact: true })
|
||
await input.waitFor()
|
||
const field = await input.boundingBox()
|
||
if (field === null) throw new Error('Comment field must be visible')
|
||
await page.mouse.move(field.x + field.width - 3, field.y + field.height - 3)
|
||
await page.mouse.down()
|
||
await page.mouse.move(field.x + field.width - 3, field.y + field.height + 77, { steps: 5 })
|
||
await page.mouse.up()
|
||
const resized = await input.boundingBox()
|
||
if (resized === null) throw new Error('Resized comment field must remain visible')
|
||
expect(resized.height).toBeGreaterThan(field.height + 50)
|
||
await input.fill('Review a wrapped line. '.repeat(80))
|
||
expect(await input.evaluate(element => element.scrollHeight > element.clientHeight)).toBe(true)
|
||
expect(await input.evaluate(element => element.scrollWidth <= element.clientWidth)).toBe(true)
|
||
await input.fill('')
|
||
await page.keyboard.type('Check the boundary')
|
||
await page.keyboard.press('Enter')
|
||
const cdp = await page.context().newCDPSession(page)
|
||
try {
|
||
await cdp.send('Input.imeSetComposition', { text: '检查', selectionStart: 2, selectionEnd: 2 })
|
||
expect(await input.inputValue()).toBe('Check the boundary\n检查')
|
||
expect(await file.locator('[data-forge-review-thread]').count()).toBe(0)
|
||
await cdp.send('Input.insertText', { text: '检查边界条件' })
|
||
} finally { await cdp.detach() }
|
||
expect(await input.inputValue()).toBe('Check the boundary\n检查边界条件')
|
||
await input.fill(' \n')
|
||
expect(await file.getByRole('button', { name: '开始评审', exact: true }).isDisabled()).toBe(true)
|
||
await input.fill('检查边界条件')
|
||
await file.getByRole('button', { name: '开始评审', exact: true }).click()
|
||
await file.locator('[data-forge-thread]').getByText('检查边界条件', { exact: true }).waitFor({ timeout: 20_000 })
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
/** Open the change request view of pull request 7 in full screen, its tree on the left. */
|
||
async function openReview(page: Page, scaffold: WebScaffold): Promise<{ readonly view: ReturnType<Page['locator']>; readonly sessionId: SessionId }> {
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
const sessionId = await settled
|
||
const session = scaffold.ctx.sessions.get(sessionId)
|
||
if (session === undefined) throw new Error('Session must stay loaded')
|
||
scaffold.ctx.forgeSession.track(session, PULL)
|
||
await page.locator('[data-forge-header]').click()
|
||
await page.locator(`[data-forge-change="${PULL}"]`).getByRole('button', { name: '查看 #7 的变更：新增 128 行，删除 14 行', exact: true }).click()
|
||
await page.getByRole('button', { name: '全屏', exact: true }).click()
|
||
const view = page.locator('[data-forge-changes="change"]')
|
||
await view.locator('[data-forge-diff-file="src/panel.ts"]').waitFor({ timeout: 20_000 })
|
||
return { view, sessionId }
|
||
}
|
||
|
||
/** Paths of the diff sections a changes view shows, in order. */
|
||
async function shownPaths(view: ReturnType<Page['locator']>): Promise<(string | null)[]> {
|
||
return await view.locator('[data-forge-diff-file]').evaluateAll(sections => sections.map(section => section.getAttribute('data-forge-diff-file')))
|
||
}
|
||
|
||
it.skipIf(MODE === 'record')('reviews a change request by layer, hides test files, marks files viewed, and views chosen commits', async () => {
|
||
const { scaffold, page, root, tripwire } = await launchPanel('web-e2e-forge-review-layers')
|
||
await writeReviewFixture(root)
|
||
const { view } = await openReview(page, scaffold)
|
||
const lens = view.getByRole('radiogroup', { name: '分层透镜', exact: true })
|
||
const tree = view.getByRole('navigation')
|
||
await expect.poll(() => lens.getByRole('radio').allTextContents()).toEqual(['全部6', '接口1', '实现2', '测试3'])
|
||
// The lens spans the file tree with the filter field's insets, and its divider continues the tree's border.
|
||
const [lensBox, fieldBox, cellBox, treeBox] = await Promise.all([
|
||
lens.boundingBox(), tree.locator('input').locator('xpath=..').boundingBox(), lens.locator('xpath=..').boundingBox(), tree.locator('xpath=..').boundingBox(),
|
||
])
|
||
if (lensBox === null || fieldBox === null || cellBox === null || treeBox === null) throw new Error('Lens and tree must be visible')
|
||
expect([lensBox.x, lensBox.x + lensBox.width]).toEqual([fieldBox.x, fieldBox.x + fieldBox.width])
|
||
expect(cellBox.x + cellBox.width).toBe(treeBox.x + treeBox.width)
|
||
|
||
await lens.getByRole('radio', { name: /^接口/ }).click()
|
||
await expect.poll(() => shownPaths(view)).toEqual(['package.json'])
|
||
await lens.getByRole('radio', { name: /^测试/ }).click()
|
||
await expect.poll(() => shownPaths(view)).toEqual(['docs/schema.json', 'locale/zh.json', 'src/panel.spec.ts'])
|
||
await view.getByRole('switch', { name: '隐藏测试文件', exact: true }).click()
|
||
await expect.poll(() => shownPaths(view)).toEqual(['docs/panel.md', 'src/panel.ts', 'package.json'])
|
||
expect(await tree.getByRole('button', { name: 'src/panel.spec.ts', exact: true }).count()).toBe(0)
|
||
expect(await lens.getByRole('radio', { name: /^测试/ }).isDisabled()).toBe(true)
|
||
|
||
const progress = view.getByRole('progressbar', { name: '已审阅的文件', exact: true })
|
||
await expect.poll(() => progress.getAttribute('aria-valuetext')).toBe('已审阅 0 / 3')
|
||
const docs = view.locator('[data-forge-diff-file="docs/panel.md"]')
|
||
await docs.getByRole('checkbox', { name: '将 panel.md 标记为已审阅', exact: true }).check()
|
||
await expect.poll(() => docs.getAttribute('data-expanded')).toBe(null)
|
||
await expect.poll(() => progress.getAttribute('aria-valuetext')).toBe('已审阅 1 / 3')
|
||
const panel = view.locator('[data-forge-diff-file="src/panel.ts"]')
|
||
await panel.getByText('export const n2 = \'two\'', { exact: true }).first().click()
|
||
await page.keyboard.press('v')
|
||
await expect.poll(() => panel.getAttribute('data-viewed')).toBe('viewed')
|
||
await expect.poll(() => progress.getAttribute('aria-valuetext')).toBe('已审阅 2 / 3')
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-layers.expected.md'),
|
||
await captureStableAria(page, '[data-forge-changes="change"]', scaffold.workspaceCwd), MODE)
|
||
|
||
await view.getByRole('switch', { name: '隐藏测试文件', exact: true }).click()
|
||
const commits = view.getByRole('button', { name: '查看的提交：全部提交', exact: true })
|
||
await commits.click()
|
||
const menu = page.locator('[data-forge-commit-menu]')
|
||
await expect.poll(() => menu.getByRole('menuitem').evaluateAll(rows => rows.map(row => row.querySelector('[data-forge-commit]')?.getAttribute('data-forge-commit') ?? 'all')))
|
||
.toEqual(['all', '1'.repeat(40), '2'.repeat(40), HEAD7])
|
||
await menu.locator(`[data-forge-commit="${'2'.repeat(40)}"]`).click()
|
||
await expect.poll(() => shownPaths(view), { timeout: 20_000 }).toEqual(['locale/zh.json', 'src/panel.spec.ts'])
|
||
expect(await view.getByRole('button', { name: '提交评审', exact: true }).isDisabled()).toBe(true)
|
||
await view.getByRole('button', { name: '查看的提交：2222222', exact: true }).click()
|
||
await page.locator(`[data-forge-commit="${HEAD7}"]`).click({ modifiers: ['Shift'] })
|
||
await view.getByRole('button', { name: `查看的提交：2222222…${HEAD7.slice(0, 7)}`, exact: true }).waitFor()
|
||
await expect.poll(() => shownPaths(view), { timeout: 20_000 }).toEqual(['docs/schema.json', 'locale/zh.json', 'src/panel.spec.ts', 'package.json'])
|
||
await expect.poll(() => lens.getByRole('radio').allTextContents()).toEqual(['全部4', '接口1', '实现0', '测试3'])
|
||
const calls = (await readFile(join(root, 'calls.jsonl'), 'utf8')).split('\n').filter(line => line.length > 0).map(line => JSON.parse(line) as string[])
|
||
// The whole pull request is read from its recorded base; chosen commits are read from the first one's parent.
|
||
expect(calls.filter(args => args[0] === 'api' && args.includes('Accept: application/vnd.github.diff')).map(args => args.at(-1))
|
||
.filter(path => path?.includes(`/compare/${'e'.repeat(40)}...`) === false)).toEqual([
|
||
`repos/octo/demo/compare/${'1'.repeat(40)}...${'2'.repeat(40)}`, `repos/octo/demo/compare/${'1'.repeat(40)}...${HEAD7}`,
|
||
])
|
||
await view.getByRole('button', { name: `查看的提交：2222222…${HEAD7.slice(0, 7)}`, exact: true }).click()
|
||
await page.locator('[data-forge-commit-menu]').getByRole('menuitem', { name: /^全部提交/ }).click()
|
||
await expect.poll(() => shownPaths(view), { timeout: 20_000 }).toHaveLength(6)
|
||
await expect.poll(() => docs.getAttribute('data-viewed')).toBe('viewed')
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('keeps local viewed marks across reloads, clears a mark when the file changes again, and views branch commits', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-review-local', 'normal', { branch: 'feat' })
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'main')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await mkdir(join(project, 'src'))
|
||
for (const [path, text, message] of [
|
||
['src/app.ts', 'export const app = 1\n', 'Add the app'],
|
||
['src/app.spec.ts', 'it(\'runs\', () => {})\n', 'Test the app'],
|
||
] as const) {
|
||
await writeFile(join(project, path), text)
|
||
await git(project, 'add', path)
|
||
await git(project, 'commit', '--quiet', '-m', message)
|
||
}
|
||
await writeFile(join(project, 'notes.md'), 'note\n')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.getByRole('button', { name: '打开右侧边栏', exact: true }).click()
|
||
await page.locator('[data-sidebar-right-guide]').getByRole('button', { name: /^代码审查和变更/ }).click()
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
const card = page.locator('[data-forge-local]')
|
||
await card.getByRole('button', { name: /^查看本会话的变更：3 个文件/ }).click({ timeout: 20_000 })
|
||
const local = page.locator('[data-forge-changes="local"]')
|
||
const app = local.locator('[data-forge-diff-file="src/app.ts"]')
|
||
await app.getByRole('checkbox', { name: '将 app.ts 标记为已审阅', exact: true }).check({ timeout: 20_000 })
|
||
await expect.poll(() => app.getAttribute('data-expanded')).toBe(null)
|
||
|
||
await page.reload()
|
||
await page.locator('[data-forge-changes="local"] [data-forge-diff-file="src/app.ts"]').waitFor({ timeout: 20_000 })
|
||
await expect.poll(() => app.getAttribute('data-viewed')).toBe('viewed')
|
||
expect(await app.getAttribute('data-expanded')).toBe(null)
|
||
await writeFile(join(project, 'src', 'app.ts'), 'export const app = 2\n')
|
||
await local.getByRole('button', { name: '刷新变更', exact: true }).click()
|
||
await expect.poll(() => app.getAttribute('data-viewed'), { timeout: 20_000 }).toBe('changed')
|
||
await app.getByText('有新改动', { exact: true }).waitFor()
|
||
await expect.poll(() => app.getAttribute('data-expanded')).toBe('')
|
||
expect(await app.getByRole('checkbox', { name: '将 app.ts 标记为已审阅', exact: true }).isChecked()).toBe(false)
|
||
|
||
await local.getByRole('button', { name: '查看的提交：全部提交', exact: true }).click()
|
||
const menu = page.locator('[data-forge-commit-menu]')
|
||
await menu.getByRole('menuitem', { name: /Test the app/ }).click()
|
||
await expect.poll(() => shownPaths(local), { timeout: 20_000 }).toEqual(['src/app.spec.ts'])
|
||
// Without the file tree beside the diff, the toolbar offers the lens as a menu.
|
||
await local.getByRole('button', { name: '分层透镜：全部', exact: true }).click()
|
||
await expect.poll(() => page.getByRole('menu').getByRole('menuitem').allTextContents()).toEqual(['全部1', '接口0', '实现0', '测试1'])
|
||
await page.keyboard.press('Escape')
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
/**
|
||
* One review thread node of pull request 7 as the GraphQL thread read returns it, its comments by `lin`, the viewer, then
|
||
* `octo`, the pull request's author; the viewer may reply, resolve, and change their own comments.
|
||
*/
|
||
function threadNode(
|
||
id: string, fields: Record<string, unknown>, bodies: readonly string[], commit: string = HEAD7,
|
||
): Record<string, unknown> {
|
||
return {
|
||
id, isOutdated: false, isResolved: false, path: 'src/panel.ts', diffSide: 'RIGHT', startDiffSide: null, line: null, startLine: null,
|
||
originalLine: null, originalStartLine: null, subjectType: 'LINE', viewerCanReply: true, viewerCanResolve: true, viewerCanUnresolve: true, ...fields,
|
||
root: { nodes: [{ diffHunk: '@@ -1,5 +1,5 @@\n export const n1 = 1\n-export const n2 = 2\n+export const n2 = \'two\'',
|
||
commit: { oid: commit }, originalCommit: { oid: commit } }] },
|
||
comments: { pageInfo: { hasNextPage: false, endCursor: null }, nodes: bodies.map((body, index) => ({
|
||
id: `${id}-${index}`, state: 'SUBMITTED', createdAt: '2026-10-09T00:00:00Z', url: `${PULL}#discussion_${id}_${index}`, body,
|
||
viewerCanUpdate: index === 0, viewerCanDelete: index === 0, author: { __typename: 'User', login: index === 0 ? 'lin' : 'octo', avatarUrl: null },
|
||
})) },
|
||
}
|
||
}
|
||
|
||
/** Threads of pull request 7: on new line 2, on old line 15, resolved on new line 15, outdated, and on the whole of `docs/panel.md`. */
|
||
const THREADS = [
|
||
threadNode('on-line', { line: 2, originalLine: 2 }, ['Why **two**?', 'It reads better.']),
|
||
threadNode('old-side', { diffSide: 'LEFT', line: 15, originalLine: 15 }, ['The old fifteen was a number.']),
|
||
threadNode('resolved', { isResolved: true, line: 15, originalLine: 15 }, ['Settled.']),
|
||
threadNode('outdated', { isOutdated: true, originalLine: 9 }, ['This line moved.'], 'f'.repeat(40)),
|
||
threadNode('whole-file', { path: 'docs/panel.md', subjectType: 'FILE' }, ['Add a screenshot.']),
|
||
]
|
||
|
||
it.skipIf(MODE === 'record')('overlays the review threads of a change request and opens them from the thread list', async () => {
|
||
const { scaffold, page, root, tripwire } = await launchPanel('web-e2e-forge-review-threads', 'follow-up')
|
||
await writeFile(join(root, 'threads.json'), JSON.stringify(THREADS))
|
||
// Comments were written two hours before the browser's clock, so their relative times stay fixed.
|
||
await page.clock.setFixedTime(Date.parse('2026-10-09T02:00:00Z'))
|
||
const { view, sessionId } = await openReview(page, scaffold)
|
||
const panel = view.locator('[data-forge-diff-file="src/panel.ts"]')
|
||
const onLine = panel.locator('[data-forge-thread="on-line"]')
|
||
await onLine.getByText('two', { exact: true }).waitFor({ timeout: 20_000 })
|
||
// The thread follows the row of its last line, in the column of its side: under the new side and the old side.
|
||
const placement = (card: Element, number: string) => {
|
||
const row = card.closest('[data-forge-notes]')
|
||
const column = Array.from(row?.children ?? []).findIndex(cell => cell.contains(card))
|
||
return { line: row?.previousElementSibling?.querySelector(number)?.textContent, column }
|
||
}
|
||
expect(await onLine.evaluate(placement, '[data-new-line]')).toEqual({ line: 'export const n2 = \'two\'', column: 1 })
|
||
expect(await panel.locator('[data-forge-thread="old-side"]').evaluate(placement, '[data-old-line]')).toEqual({ line: 'export const n15 = 15', column: 0 })
|
||
await panel.locator('[data-forge-thread="resolved"]').getByText('已解决的讨论 · lin', { exact: true }).waitFor()
|
||
await panel.locator('[data-forge-outdated-threads]').getByText('1 条讨论已过期：所在代码已被后续提交修改', { exact: true }).waitFor()
|
||
await view.locator('[data-forge-diff-file="docs/panel.md"] [data-forge-thread="whole-file"]').getByText('文件级讨论', { exact: true }).waitFor()
|
||
const count = panel.getByRole('button', { name: 'panel.ts 有 3 条未解决的讨论，跳到下一条', exact: true })
|
||
await count.waitFor()
|
||
await view.getByRole('navigation').getByTitle('3 条未解决的讨论', { exact: true }).waitFor()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-threads.expected.md'),
|
||
await captureStableAria(page, '[data-forge-diff-file="src/panel.ts"]', scaffold.workspaceCwd), MODE)
|
||
|
||
// The count steps through the file's unresolved threads in display order: R2, L15, then the outdated one.
|
||
const centered = async (id: string): Promise<boolean> => await panel.locator(`[data-forge-thread="${id}"]`).evaluate((card) => {
|
||
const viewport = card.closest('[data-forge-changes-scroll]')!.getBoundingClientRect()
|
||
const box = card.getBoundingClientRect()
|
||
return box.top + box.height / 2 > viewport.top && box.top + box.height / 2 < viewport.bottom
|
||
})
|
||
for (const id of ['on-line', 'old-side', 'outdated']) {
|
||
await count.click()
|
||
await expect.poll(() => centered(id)).toBe(true)
|
||
}
|
||
expect(await view.locator('[data-forge-thread-list]').count()).toBe(0)
|
||
|
||
await view.getByRole('button', { name: '讨论列表，共 5 个', exact: true }).click()
|
||
const list = view.getByRole('complementary', { name: '讨论列表，共 5 个' })
|
||
await expect.poll(() => list.getByRole('radio', { checked: true }).allTextContents()).toEqual(['未解决4'])
|
||
await expect.poll(() => list.locator('[data-forge-thread-item]').evaluateAll(items => items.map(item => item.getAttribute('data-forge-thread-item'))))
|
||
.toEqual(['whole-file', 'on-line', 'old-side', 'outdated'])
|
||
await list.getByRole('radio', { name: /^已解决/ }).click()
|
||
await list.locator('[data-forge-thread-item="resolved"]').click()
|
||
// Opening a resolved thread unfolds it inside its file, and the docked list stays.
|
||
await panel.locator('[data-forge-thread="resolved"]').getByText('Settled.', { exact: true }).waitFor()
|
||
await list.getByRole('radio', { name: /^全部/ }).click()
|
||
await expect.poll(() => list.locator('[data-forge-thread-item]').count()).toBe(5)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-thread-list.expected.md'),
|
||
await captureStableAria(page, '[data-forge-thread-list]', scaffold.workspaceCwd), MODE)
|
||
// A view narrower than 480px gives the list the files' whole width and closes it before opening a thread.
|
||
await view.evaluate((element) => { element.style.width = '420px'; element.style.flex = 'none' })
|
||
await expect.poll(() => list.evaluate(element => [getComputedStyle(element).position, element.getBoundingClientRect().width]))
|
||
.toEqual(['absolute', 420])
|
||
await list.locator('[data-forge-thread-item="on-line"]').click()
|
||
await list.waitFor({ state: 'detached' })
|
||
await view.evaluate((element) => { element.style.width = ''; element.style.flex = '' })
|
||
|
||
await onLine.getByRole('button', { name: '添加到输入框', exact: true }).click()
|
||
await page.locator('[data-composer-input]').first().getByText('panel.ts R2', { exact: true }).first().waitFor()
|
||
const sent = scaffold.whenTurnSettled()
|
||
await page.locator('[data-composer-input]').first().press('Enter')
|
||
await sent
|
||
await page.getByText(FOLLOW_UP_REPLY, { exact: true }).waitFor()
|
||
// The quoted thread reaches the model only inside the ordinary logged user message.
|
||
const quotes = (await readPersistedEvents(scaffold, sessionId)).flatMap(event => event.type === 'user/message'
|
||
? event.data.content.flatMap(block => block.type === 'text' && block.text.includes('## Review Thread') ? [block.text] : []) : [])
|
||
expect(quotes).toHaveLength(1)
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-thread-message.expected.md'), quotes.join('').trimEnd(), MODE)
|
||
const calls = (await readFile(join(root, 'calls.jsonl'), 'utf8')).split('\n').filter(line => line.length > 0).map(line => JSON.parse(line) as string[])
|
||
const reads = calls.filter(args => args.some(arg => arg.startsWith('query=') && arg.includes('viewer { login }')))
|
||
expect(reads.length).toBeGreaterThan(0)
|
||
expect(reads[0]).toEqual(expect.arrayContaining(['owner=octo', 'name=demo', 'number=7', 'first=100']))
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('replies to, edits, deletes, and resolves review threads, and discards a pending review started from a reply', async () => {
|
||
const { scaffold, page, root, tripwire } = await launchPanel('web-e2e-forge-review-writes')
|
||
await writeFile(join(root, 'threads.json'), JSON.stringify(THREADS))
|
||
await page.clock.setFixedTime(Date.parse('2026-10-09T02:00:00Z'))
|
||
const { view } = await openReview(page, scaffold)
|
||
const panel = view.locator('[data-forge-diff-file="src/panel.ts"]')
|
||
const onLine = panel.locator('[data-forge-thread="on-line"]')
|
||
await onLine.getByText('two', { exact: true }).waitFor({ timeout: 20_000 })
|
||
|
||
await onLine.getByRole('button', { name: '回复…', exact: true }).click()
|
||
await onLine.getByRole('textbox', { name: '回复…', exact: true }).fill('已改为字符串')
|
||
await compareOrRefreshGolden(join(EXPECTED, 'review-thread-reply.expected.md'),
|
||
await captureStableAria(page, '[data-forge-thread="on-line"]', scaffold.workspaceCwd), MODE)
|
||
await onLine.getByRole('button', { name: '回复', exact: true }).click()
|
||
await onLine.getByText('已改为字符串', { exact: true }).waitFor({ timeout: 20_000 })
|
||
|
||
await onLine.getByRole('button', { name: 'lin 的评论操作', exact: true }).first().click()
|
||
await page.getByRole('menuitem', { name: '编辑', exact: true }).click()
|
||
await onLine.getByRole('textbox', { name: '编辑评论', exact: true }).fill('Why a **word**?')
|
||
await onLine.getByRole('button', { name: '保存', exact: true }).click()
|
||
await onLine.getByText('word', { exact: true }).waitFor({ timeout: 20_000 })
|
||
|
||
await onLine.getByRole('button', { name: 'lin 的评论操作', exact: true }).last().click()
|
||
await page.getByRole('menuitem', { name: '删除', exact: true }).click()
|
||
await onLine.getByRole('group', { name: '删除这条评论？', exact: true }).getByRole('button', { name: '删除', exact: true }).click()
|
||
await expect.poll(() => onLine.getByText('已改为字符串', { exact: true }).count(), { timeout: 20_000 }).toBe(0)
|
||
|
||
await onLine.getByRole('button', { name: '解决讨论', exact: true }).click()
|
||
await onLine.getByText('已解决的讨论 · lin', { exact: true }).waitFor({ timeout: 20_000 })
|
||
|
||
const oldSide = panel.locator('[data-forge-thread="old-side"]')
|
||
await oldSide.getByRole('button', { name: '回复…', exact: true }).click()
|
||
await oldSide.getByRole('textbox', { name: '回复…', exact: true }).fill('稍后一起提交')
|
||
await oldSide.getByRole('button', { name: '回复选项', exact: true }).click()
|
||
await page.getByRole('menuitem', { name: '开始评审', exact: true }).click()
|
||
await oldSide.getByText('待提交', { exact: true }).waitFor({ timeout: 20_000 })
|
||
await view.getByRole('button', { name: '提交评审 (1)', exact: true }).click()
|
||
const dialog = page.getByRole('dialog', { name: '提交评审', exact: true })
|
||
await dialog.getByRole('button', { name: '丢弃评审', exact: true }).click()
|
||
await compareOrRefreshGolden(join(EXPECTED, 'discard-review.expected.md'),
|
||
await captureStableAria(page, '[role="dialog"][aria-label="提交评审"]', scaffold.workspaceCwd), MODE)
|
||
await dialog.getByRole('group', { name: '丢弃评审', exact: true }).getByRole('button', { name: '丢弃评审', exact: true }).click()
|
||
await page.getByRole('alert').filter({ hasText: '已丢弃评审' }).waitFor()
|
||
await expect.poll(() => oldSide.getByText('稍后一起提交', { exact: true }).count(), { timeout: 20_000 }).toBe(0)
|
||
await view.getByRole('button', { name: '提交评审', exact: true }).waitFor()
|
||
|
||
const mutations = (await readFile(join(root, 'mutations.jsonl'), 'utf8')).trim().split('\n').map((line): unknown => JSON.parse(line))
|
||
expect(mutations).toEqual([
|
||
{ field: 'addPullRequestReviewThreadReply', variables: { thread: 'on-line', body: '已改为字符串', review: null } },
|
||
{ field: 'updatePullRequestReviewComment', variables: { comment: 'on-line-0', body: 'Why a **word**?' } },
|
||
{ field: 'deletePullRequestReviewComment', variables: { comment: 'on-line-reply-0' } },
|
||
{ field: 'resolveReviewThread', variables: { thread: 'on-line' } },
|
||
{ field: 'addPullRequestReview', variables: { pull: 'pull-7', commit: HEAD7, threads: null } },
|
||
{ field: 'addPullRequestReviewThreadReply', variables: { thread: 'old-side', body: '稍后一起提交', review: 'review-1' } },
|
||
{ field: 'deletePullRequestReview', variables: { review: 'review-1' } },
|
||
])
|
||
// Every write checked the head of pull request 7 first.
|
||
const calls = (await readFile(join(root, 'calls.jsonl'), 'utf8')).split('\n').filter(line => line.length > 0).map(line => JSON.parse(line) as string[])
|
||
expect(calls.filter(args => args.some(arg => arg.startsWith('query=') && arg.includes('reviews(states: PENDING') && !arg.includes('viewer { login }'))))
|
||
.toHaveLength(mutations.length - 1)
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('keeps a narrow file header\'s viewed mark and menu inside its card and its name under the pointer', async () => {
|
||
const { scaffold, page, project, tripwire } = await launchPanel('web-e2e-forge-narrow-header', 'normal', { branch: 'feat' })
|
||
const from = 'src/original-review-module-with-a-long-name.ts'
|
||
const to = 'src/renamed-review-module-with-an-even-longer-name.ts'
|
||
const body = Array.from({ length: 20 }, (_, index) => `export const value${index} = ${index}\n`).join('')
|
||
await mkdir(join(project, 'src'))
|
||
await writeFile(join(project, from), body)
|
||
await git(project, 'add', from)
|
||
await git(project, 'commit', '--quiet', '-m', 'Add the module')
|
||
// The base holds the old path, so the branch shows a rename.
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await git(project, 'mv', from, to)
|
||
await writeFile(join(project, to), `${body}export const extra = 1\n`)
|
||
await git(project, 'commit', '--quiet', '-am', 'Rename the module')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.getByRole('button', { name: '打开右侧边栏', exact: true }).click()
|
||
await page.locator('[data-sidebar-right-guide]').getByRole('button', { name: /^代码审查和变更/ }).click()
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
await page.locator('[data-forge-local]').getByRole('button', { name: /^查看本会话的变更/ }).click({ timeout: 20_000 })
|
||
const local = page.locator('[data-forge-changes="local"]')
|
||
const name = 'renamed-review-module-with-an-even-longer-name.ts'
|
||
const file = local.locator(`[data-forge-diff-file="${to}"]`)
|
||
const viewed = file.getByRole('checkbox', { name: `将 ${name} 标记为已审阅`, exact: true })
|
||
await viewed.check({ timeout: 20_000 })
|
||
await writeFile(join(project, to), `${body}export const extra = 2\n`)
|
||
await local.getByRole('button', { name: '刷新变更', exact: true }).click()
|
||
await expect.poll(() => file.getAttribute('data-viewed'), { timeout: 20_000 }).toBe('changed')
|
||
await file.getByText('由 original-review-module-with-a-long-name.ts 重命名', { exact: true }).waitFor()
|
||
|
||
// The changed tag, the rename badge, and the long path compete for one narrow header with the counts and actions.
|
||
await page.setViewportSize({ width: 390, height: 780 })
|
||
const label = file.locator('[data-forge-file-label]')
|
||
const [card, mark, menu, labelBox] = await Promise.all([
|
||
file.boundingBox(), viewed.boundingBox(), file.getByRole('button', { name: `${name} 的更多操作`, exact: true }).boundingBox(), label.boundingBox(),
|
||
])
|
||
if (card === null || mark === null || menu === null || labelBox === null) throw new Error('The header controls must be rendered')
|
||
expect(mark.x + mark.width).toBeLessThanOrEqual(card.x + card.width)
|
||
expect(menu.x + menu.width).toBeLessThanOrEqual(card.x + card.width)
|
||
expect(labelBox.width).toBeGreaterThan(40)
|
||
await label.hover()
|
||
await page.getByRole('tooltip').filter({ hasText: `${from} → ${to}` }).waitFor()
|
||
await viewed.check()
|
||
await expect.poll(() => file.getAttribute('data-viewed')).toBe('viewed')
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
/**
|
||
* Launch the panel on a branch whose README.md replaces its first line and adds eight more, so a side-by-side view
|
||
* pairs a deletion with an addition, then open the Session's local changes full screen.
|
||
* @param failureShot - screenshot name for a failure.
|
||
* @returns the launch and the local changes view.
|
||
*/
|
||
async function openLocalChanges(failureShot: string): Promise<PanelLaunch & { readonly view: Locator }> {
|
||
const launch = await launchPanel(failureShot)
|
||
const { scaffold, page, project } = launch
|
||
await git(project, 'update-ref', 'refs/remotes/origin/main', 'HEAD')
|
||
await git(project, 'symbolic-ref', 'refs/remotes/origin/HEAD', 'refs/remotes/origin/main')
|
||
await writeFile(join(project, 'README.md'), `changed\n${Array.from({ length: 8 }, (_, line) => `line ${line + 2}\n`).join('')}`)
|
||
await writeFile(join(project, 'notes.md'), 'note\n')
|
||
const { settled } = await sendPrompt(page, scaffold)
|
||
await settled
|
||
await page.locator('[data-forge-header]').click()
|
||
await page.locator('[data-forge-panel]').getByRole('button', { name: '刷新状态', exact: true }).click()
|
||
await page.locator('[data-forge-local]').getByRole('button', { name: /查看本会话的变更/ }).click()
|
||
const view = page.locator('[data-forge-changes="local"]')
|
||
await view.locator('[data-forge-diff-file="README.md"]').waitFor()
|
||
await page.getByRole('button', { name: '全屏', exact: true }).click()
|
||
return { ...launch, view }
|
||
}
|
||
|
||
it.skipIf(MODE === 'record')('keeps the changes toolbar and header on one line, folding view controls into the More menu as they narrow', async () => {
|
||
const { page, view, tripwire } = await openLocalChanges('web-e2e-forge-toolbar-fold')
|
||
const toolbar = view.locator('[data-fold]')
|
||
const more = toolbar.getByRole('button', { name: '更多视图选项', exact: true })
|
||
const create = view.getByRole('button', { name: '创建变更请求', exact: true })
|
||
const layout = () => toolbar.evaluate((row) => {
|
||
const header = row.closest('[data-forge-changes]')!.firstElementChild!
|
||
return { fold: row.getAttribute('data-fold'), overflow: row.scrollWidth - row.clientWidth, height: row.getBoundingClientRect().height,
|
||
header: header.getBoundingClientRect().height }
|
||
})
|
||
// The button keeps a fixed height when its label wraps, so the label's own height tells one line from two.
|
||
const labelHeight = () => create.evaluate((button) => {
|
||
const range = document.createRange()
|
||
range.selectNodeContents(button)
|
||
return Math.round(range.getBoundingClientRect().height)
|
||
})
|
||
const lineHeight = await labelHeight()
|
||
const seen: string[] = []
|
||
for (const width of [1680, 700, 560, 390, 340]) {
|
||
await page.setViewportSize({ width, height: 800 })
|
||
await expect.poll(async () => (await layout()).overflow).toBeLessThanOrEqual(0)
|
||
const { fold, height, header } = await layout()
|
||
// One 28px control row inside the toolbar's padding, and the header keeps its single-line height.
|
||
expect([width, height]).toEqual([width, 38])
|
||
expect([width, header]).toEqual([width, 44])
|
||
expect([width, await labelHeight()]).toEqual([width, lineHeight])
|
||
seen.push(`${width}:${fold}`)
|
||
}
|
||
expect(seen[0]).toBe('1680:0')
|
||
expect(seen.at(-1)).toBe('340:3')
|
||
expect(await more.isVisible()).toBe(true)
|
||
|
||
await page.setViewportSize({ width: 390, height: 800 })
|
||
await expect.poll(() => toolbar.getAttribute('data-fold')).toBe('2')
|
||
// Folded controls leave the row; the progress turns into the ring and the bare count.
|
||
expect(await toolbar.getByRole('button', { name: '左右对比', exact: true }).isVisible()).toBe(false)
|
||
expect(await toolbar.getByRole('switch', { name: '隐藏测试文件', exact: true }).isVisible()).toBe(false)
|
||
expect(await toolbar.locator('[data-forge-progress="compact"]').innerText()).toBe('0/2')
|
||
await more.click()
|
||
const menu = page.getByRole('menu')
|
||
expect(await menu.getByRole('menuitem').allTextContents()).toEqual(['全部折叠', '左右对比', '自动换行', '隐藏测试文件'])
|
||
const code = view.locator('[data-forge-diff-file="README.md"] [data-review]')
|
||
expect(await code.getAttribute('data-split')).toBe('')
|
||
await menu.getByRole('menuitem', { name: '左右对比', exact: true }).click()
|
||
await expect.poll(() => code.getAttribute('data-split')).toBe(null)
|
||
expect(await page.getByRole('menu').count()).toBe(0)
|
||
await page.setViewportSize({ width: 1680, height: 800 })
|
||
await expect.poll(() => toolbar.getAttribute('data-fold')).toBe('0')
|
||
expect(await more.isVisible()).toBe(false)
|
||
expect(await toolbar.getByRole('button', { name: '左右对比', exact: true }).getAttribute('aria-pressed')).toBe('false')
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|
||
|
||
it.skipIf(MODE === 'record')('writes a left and a right comment at once, each inside its own column of the side-by-side row', async () => {
|
||
const { page, view, tripwire } = await openLocalChanges('web-e2e-forge-side-comments')
|
||
const readme = view.locator('[data-forge-diff-file="README.md"]')
|
||
const open = async (name: string) => {
|
||
await readme.getByRole('button', { name: `选择第 ${name} 行`, exact: true }).click()
|
||
await readme.getByRole('button', { name: '添加评论', exact: true }).click()
|
||
return readme.getByRole('region', { name: `评论 ${name}`, exact: true })
|
||
}
|
||
const left = await open('L1')
|
||
const right = await open('R1')
|
||
await right.getByRole('textbox').fill('右侧的评论')
|
||
for (const width of [1680, 1000, 780]) {
|
||
await page.setViewportSize({ width, height: 900 })
|
||
const boxes = await readme.evaluate((section) => {
|
||
const pair = section.querySelector('[data-diff-pair]')!
|
||
const [l, r] = Array.from(pair.children, cell => cell.getBoundingClientRect())
|
||
const [a, b] = Array.from(section.querySelectorAll('[data-forge-comment]'), form => form.getBoundingClientRect())
|
||
return { l: [l!.left, l!.right], r: [r!.left, r!.right], a: [a!.left, a!.right, a!.top], b: [b!.left, b!.right, b!.top] }
|
||
})
|
||
// Each comment stays inside its side's column, and both share one row.
|
||
expect(boxes.a[0]!).toBeGreaterThan(boxes.l[0]!)
|
||
expect(boxes.a[1]!).toBeLessThan(boxes.l[1]!)
|
||
expect(boxes.b[0]!).toBeGreaterThan(boxes.r[0]!)
|
||
expect(boxes.b[1]!).toBeLessThan(boxes.r[1]!)
|
||
expect(boxes.a[2]).toBe(boxes.b[2])
|
||
}
|
||
await left.getByRole('button', { name: '取消', exact: true }).click()
|
||
expect(await left.count()).toBe(0)
|
||
expect(await right.getByRole('textbox').inputValue()).toBe('右侧的评论')
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
})
|