Yichen Jiang
d7d7b301d5
Agent presets: every card that composes carries a gear that opens the preset's detail page (breadcrumb, name, marks, description) and declares a `settings.agentPreset.detail` slot for the sections other plugins contribute. Plugin manager: the session-plugins group leaves the tab for the detail page's Capabilities section, with a red Delete on rows the person added and an Add menu over the installed modules the preset lacks; the manage tab now precedes the configuration tab. Plugin configuration: the scope switch is gone. The tab edits the values shared by all presets, and the same cards form the detail page's Settings section, registered under a second keyed slot (`settings.agentPreset.plugin.item`) and editing the preset's own scope while the page is open. The roster dependency the switch needed leaves with it. Web e2e goldens, both READMEs of each package, the Agent Note, the slot catalog, and the inspect catalog follow.
228 lines
11 KiB
TypeScript
228 lines
11 KiB
TypeScript
// Web e2e scenario: the configurable tab in Plugins settings — the cards a
|
|
// deployment's exposed host-plane namespaces produce, one field edited through the real
|
|
// wire down to `$DSH_HOME/settings.yaml`, and the override badge and reset
|
|
// that layering produces. Zero model calls: everything is client state plus
|
|
// the settings document on a blank frame, so there is no fixture and a stray
|
|
// stream would fail loud on the open llm seam.
|
|
import { readFile } from 'node:fs/promises'
|
|
import { fileURLToPath } from 'node:url'
|
|
import type { Browser, Page } from 'playwright'
|
|
import { chromium } from 'playwright'
|
|
import { afterAll, beforeAll, describe, expect, it, onTestFailed } from 'vitest'
|
|
import { join } from 'node:path'
|
|
import {
|
|
assertFixtureInventory, captureStableAria, compareOrRefreshGolden,
|
|
launchWebScaffold, watchConsole, webSnapshotMode, type WebScaffold,
|
|
} from './scaffold.ts'
|
|
import { ZH_BROWSER_LOCALE, saveFailureShot } from './support.ts'
|
|
|
|
const SNAPSHOT_DIR = fileURLToPath(new URL('./expected/plugin-config', import.meta.url))
|
|
const SECTION_EXPECTED = join(SNAPSHOT_DIR, 'section.expected.md')
|
|
const MODE = webSnapshotMode()
|
|
|
|
describe('web e2e: plugin configuration section', () => {
|
|
let scaffold: WebScaffold
|
|
let browser: Browser
|
|
let page: Page
|
|
let tripwire: ReturnType<typeof watchConsole>
|
|
|
|
beforeAll(async () => {
|
|
scaffold = await launchWebScaffold({})
|
|
browser = await chromium.launch()
|
|
// Chinese browser: the section asserts the localized copy the client
|
|
// derives from it, as the rest of the settings surface does.
|
|
page = await browser.newPage({ viewport: { width: 1680, height: 1000 }, locale: ZH_BROWSER_LOCALE })
|
|
tripwire = watchConsole(page)
|
|
await page.goto(scaffold.authenticatedUrl, { waitUntil: 'load' })
|
|
await page.waitForSelector('[class*="frame"]', { timeout: 30_000 })
|
|
}, 120_000)
|
|
|
|
afterAll(async () => {
|
|
await browser?.close()
|
|
await scaffold?.close()
|
|
})
|
|
|
|
/**
|
|
* Open the settings dialog on the Plugins section. The scenarios share one
|
|
* page so the settings document accumulates across them, so this leaves any
|
|
* dialog a previous scenario opened closed first — its mask would otherwise
|
|
* swallow the trigger click.
|
|
*/
|
|
async function openPlugins() {
|
|
if (await page.getByRole('dialog', { name: '设置' }).count() > 0) {
|
|
await page.keyboard.press('Escape')
|
|
await expect.poll(() => page.getByRole('dialog', { name: '设置' }).count(), { timeout: 5_000 }).toBe(0)
|
|
}
|
|
await page.getByRole('button', { name: '设置', exact: true }).click()
|
|
const dialog = page.getByRole('dialog', { name: '设置' })
|
|
await dialog.waitFor({ timeout: 10_000 })
|
|
await dialog.getByRole('button', { name: '插件', exact: true }).click()
|
|
await expect
|
|
.poll(() => dialog.getByRole('button', { name: '插件', exact: true }).getAttribute('aria-current'), { timeout: 5_000 })
|
|
.toBe('true')
|
|
await dialog.getByRole('tab', { name: '插件配置', exact: true }).click()
|
|
await expect
|
|
.poll(() => dialog.getByRole('tab', { name: '插件配置', exact: true }).getAttribute('aria-selected'), { timeout: 5_000 })
|
|
.toBe('true')
|
|
return dialog
|
|
}
|
|
|
|
/** The settings document as the Host has written it so far. */
|
|
async function settingsDocument(): Promise<string> {
|
|
return readFile(join(scaffold.harnessHome, 'settings.yaml'), 'utf8').catch(() => '')
|
|
}
|
|
|
|
it('shows one card per exposed host-plane namespace', async () => {
|
|
onTestFailed(() => saveFailureShot(page, 'web-e2e-plugin-config-cards'))
|
|
const dialog = await openPlugins()
|
|
|
|
// Every card the shipped web composition exposes: the shell executor, the
|
|
// agent loop, subagent selection, and the DeepSeek search provider.
|
|
await dialog.getByText('Subagent', { exact: true }).waitFor({ timeout: 10_000 })
|
|
expect(await dialog.getByRole('button', { name: '展开设置: Subagent' }).count()).toBe(1)
|
|
await dialog.getByText('终端', { exact: true }).waitFor({ timeout: 10_000 })
|
|
expect(await dialog.getByText('Agent 循环', { exact: true }).count()).toBe(1)
|
|
expect(await dialog.getByText('网页搜索', { exact: true }).count()).toBe(1)
|
|
// Collapsed: a card's fields appear only once it is expanded.
|
|
expect(await dialog.getByLabel('命令超时（毫秒）').count()).toBe(0)
|
|
|
|
const snapshot = await captureStableAria(page, '[role="dialog"]', scaffold.workspaceCwd)
|
|
await compareOrRefreshGolden(SECTION_EXPECTED, snapshot, MODE)
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
}, 60_000)
|
|
|
|
it('persists selected adapter routes as the subagent model allowlist', async () => {
|
|
onTestFailed(() => saveFailureShot(page, 'web-e2e-plugin-config-subagent-model-selection'))
|
|
const dialog = await openPlugins()
|
|
await dialog.getByText('Subagent', { exact: true }).click()
|
|
const toggle = dialog.getByRole('switch', { name: '允许 Agent 为 Subagent 选择模型' })
|
|
|
|
await toggle.click()
|
|
const models = dialog.getByRole('group', { name: 'Agent 可选择的模型' })
|
|
await models.waitFor({ timeout: 10_000 })
|
|
const firstModel = models.getByRole('checkbox').first()
|
|
await firstModel.check()
|
|
await dialog.getByRole('button', { name: '保存', exact: true }).click()
|
|
|
|
const expandSubagent = dialog.getByRole('button', { name: '展开设置: Subagent' })
|
|
await expandSubagent.waitFor({ timeout: 5_000 })
|
|
await expect.poll(async () => (await settingsDocument()).includes('subagent-model-selection:'), { timeout: 10_000 })
|
|
.toBe(true)
|
|
expect(await settingsDocument()).toContain('enabled: true')
|
|
expect(await settingsDocument()).toContain('allowedModels:')
|
|
expect(await settingsDocument()).toContain('provider:')
|
|
expect(await settingsDocument()).toContain('model:')
|
|
await expandSubagent.click()
|
|
await expect.poll(() => toggle.getAttribute('aria-checked'), { timeout: 5_000 }).toBe('true')
|
|
await expect.poll(() => dialog.getByRole('button', { name: '保存', exact: true }).isDisabled()).toBe(true)
|
|
expect(await dialog.getByText('未保存', { exact: true }).count()).toBe(0)
|
|
|
|
await toggle.click()
|
|
await dialog.getByRole('button', { name: '保存', exact: true }).click()
|
|
await expandSubagent.waitFor({ timeout: 5_000 })
|
|
await expect.poll(async () => (await settingsDocument()).includes('enabled: false'), { timeout: 10_000 })
|
|
.toBe(true)
|
|
expect(await settingsDocument()).toContain('allowedModels:')
|
|
expect(await settingsDocument()).toContain('provider:')
|
|
expect(await settingsDocument()).toContain('model:')
|
|
await expandSubagent.click()
|
|
await expect.poll(() => toggle.getAttribute('aria-checked'), { timeout: 5_000 }).toBe('false')
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
}, 60_000)
|
|
|
|
it('stages an edit and writes it only when saved', async () => {
|
|
onTestFailed(() => saveFailureShot(page, 'web-e2e-plugin-config-write'))
|
|
const dialog = await openPlugins()
|
|
await dialog.getByText('终端', { exact: true }).click()
|
|
|
|
const timeout = dialog.getByLabel('命令超时（毫秒）')
|
|
await timeout.waitFor({ timeout: 10_000 })
|
|
// The composed default this deployment ships, before any user layer.
|
|
expect(await timeout.inputValue()).toBe('60000')
|
|
await timeout.fill('12000')
|
|
await timeout.blur()
|
|
|
|
// Nothing crosses the wire until the user saves: leaving the control is
|
|
// not a decision to store the value.
|
|
expect(await settingsDocument()).not.toContain('timeoutMs')
|
|
const save = dialog.getByRole('button', { name: '保存', exact: true })
|
|
await expect.poll(() => save.isEnabled(), { timeout: 5_000 }).toBe(true)
|
|
await save.click()
|
|
|
|
await expect.poll(async () => (await settingsDocument()).includes('timeoutMs: 12000'), { timeout: 10_000 })
|
|
.toBe(true)
|
|
const expandTerminal = dialog.getByRole('button', { name: '展开设置: 终端' })
|
|
await expandTerminal.waitFor({ timeout: 5_000 })
|
|
await expandTerminal.click()
|
|
// Presence in the user layer is what the badge reports, and the reset is
|
|
// offered only for a field that has one.
|
|
await expect.poll(() => dialog.getByText('已覆盖').count(), { timeout: 5_000 }).toBe(1)
|
|
expect(await dialog.getByRole('button', { name: '恢复默认' }).count()).toBe(1)
|
|
// A settled form offers no save to repeat.
|
|
await expect.poll(() => save.isDisabled(), { timeout: 5_000 }).toBe(true)
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
}, 60_000)
|
|
|
|
it('drops a staged edit on discard without touching the document', async () => {
|
|
onTestFailed(() => saveFailureShot(page, 'web-e2e-plugin-config-discard'))
|
|
const dialog = await openPlugins()
|
|
await dialog.getByText('终端', { exact: true }).click()
|
|
const timeout = dialog.getByLabel('命令超时（毫秒）')
|
|
await timeout.waitFor({ timeout: 10_000 })
|
|
|
|
await timeout.fill('7000')
|
|
await dialog.getByRole('button', { name: '放弃修改' }).click()
|
|
|
|
await expect.poll(() => timeout.inputValue(), { timeout: 5_000 }).toBe('12000')
|
|
expect(await settingsDocument()).toContain('timeoutMs: 12000')
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
}, 60_000)
|
|
|
|
it('refuses to save a draft that is not a number', async () => {
|
|
onTestFailed(() => saveFailureShot(page, 'web-e2e-plugin-config-invalid'))
|
|
const dialog = await openPlugins()
|
|
await dialog.getByText('终端', { exact: true }).click()
|
|
const timeout = dialog.getByLabel('命令超时（毫秒）')
|
|
await timeout.waitFor({ timeout: 10_000 })
|
|
|
|
await timeout.fill('soon')
|
|
|
|
const save = dialog.getByRole('button', { name: '保存', exact: true })
|
|
await expect.poll(() => save.isDisabled(), { timeout: 5_000 }).toBe(true)
|
|
expect(await dialog.getByText('请填数字；留空表示使用默认值。').count()).toBe(1)
|
|
await dialog.getByRole('button', { name: '放弃修改' }).click()
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
}, 60_000)
|
|
|
|
it('clears the field back to the composed default on reset', async () => {
|
|
onTestFailed(() => saveFailureShot(page, 'web-e2e-plugin-config-reset'))
|
|
const dialog = await openPlugins()
|
|
await dialog.getByText('终端', { exact: true }).click()
|
|
const timeout = dialog.getByLabel('命令超时（毫秒）')
|
|
await timeout.waitFor({ timeout: 10_000 })
|
|
expect(await timeout.inputValue()).toBe('12000')
|
|
|
|
// The reset stages the composed default; the document still carries the
|
|
// override until the save lands.
|
|
await dialog.getByRole('button', { name: '恢复默认' }).click()
|
|
await expect.poll(() => timeout.inputValue(), { timeout: 5_000 }).toBe('60000')
|
|
expect(await settingsDocument()).toContain('timeoutMs: 12000')
|
|
|
|
await dialog.getByRole('button', { name: '保存', exact: true }).click()
|
|
|
|
await expect.poll(async () => (await settingsDocument()).includes('timeoutMs'), { timeout: 10_000 })
|
|
.toBe(false)
|
|
const expandTerminal = dialog.getByRole('button', { name: '展开设置: 终端' })
|
|
await expandTerminal.waitFor({ timeout: 5_000 })
|
|
await expandTerminal.click()
|
|
expect(await timeout.inputValue()).toBe('60000')
|
|
expect(await dialog.getByText('已覆盖').count()).toBe(0)
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
}, 60_000)
|
|
|
|
it.skipIf(MODE === 'record')('keeps the fixture inventory closed', async () => {
|
|
expect(tripwire.warnings).toEqual([])
|
|
await assertFixtureInventory(SNAPSHOT_DIR, ['section.expected.md'])
|
|
})
|
|
})
|