_Kerman
8c87f5b042
A silent package-manager run and a failed GitHub connection check now each show what failed in the dialog's details instead of an empty panel. The GitHub case configures no fallback registry so the plain failed screen renders, and the silent case stands Node in for pnpm so the run prints nothing. Both scenarios and the new golden are registered in the client and host TypeScript aggregates.
189 lines
11 KiB
TypeScript
189 lines
11 KiB
TypeScript
// Real Git reaches a controlled proxy failure or stall; the browser
|
|
// offers a mirror for a replacement spec, or another way once the install
|
|
// already asks the mirror, without retrying the failed address. Without a
|
|
// configured fallback registry the same failure keeps the plain failed
|
|
// screen, whose details name the check's own Git run and complete log.
|
|
import { once } from 'node:events'
|
|
import { mkdtemp, readFile, writeFile, rm } from 'node:fs/promises'
|
|
import { createServer, type Socket } from 'node:net'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { fileURLToPath } from 'node:url'
|
|
import { chromium } from 'playwright'
|
|
import { expect, it, onTestFinished } from 'vitest'
|
|
import { launchWebScaffold, captureStableAria, compareOrRefreshGolden, webSnapshotMode, watchConsole } from './scaffold.ts'
|
|
import { ZH_BROWSER_LOCALE } from './support.ts'
|
|
|
|
it.each(['network', 'timeout'] as const)('offers a mirror after a GitHub %s, then another way on the mirror, and waits for replacement input', async (failure) => {
|
|
const scratch = await mkdtemp(join(tmpdir(), 'dsh-install-github-'))
|
|
onTestFinished(() => rm(scratch, { recursive: true, force: true }))
|
|
const sockets = new Set<Socket>()
|
|
let connections = 0
|
|
const proxy = createServer((socket) => {
|
|
sockets.add(socket)
|
|
socket.on('error', () => {})
|
|
socket.once('close', () => { sockets.delete(socket) })
|
|
socket.once('data', () => { connections++; if (failure === 'network') socket.destroy() })
|
|
})
|
|
onTestFinished(async () => {
|
|
for (const socket of sockets) socket.destroy()
|
|
await new Promise<void>((resolve, reject) => { proxy.close((error) => { if (error) reject(error); else resolve() }) })
|
|
})
|
|
proxy.listen(0, '127.0.0.1')
|
|
await once(proxy, 'listening')
|
|
const address = proxy.address()
|
|
if (address === null || typeof address === 'string') throw new Error('proxy did not bind a TCP port')
|
|
const gitConfig = join(scratch, 'git.config')
|
|
await writeFile(gitConfig, `[http "https://github.com/"]\n proxy = http://127.0.0.1:${String(address.port)}\n`)
|
|
const overlay = join(scratch, 'cordis.patch.yml')
|
|
await writeFile(overlay, '- id: ui-plugin-manager\n config: { registryProbeEnabled: false }\n')
|
|
const scaffold = await launchWebScaffold({
|
|
profile: { packages: [], packageManager: { command: process.execPath, args: [], env: { GIT_CONFIG_GLOBAL: gitConfig, GIT_CONFIG_NOSYSTEM: '1' } } },
|
|
extraOverlayPath: overlay,
|
|
})
|
|
onTestFinished(() => scaffold.close())
|
|
const browser = await chromium.launch()
|
|
onTestFinished(() => browser.close())
|
|
const profile = join(scaffold.harnessHome, 'profiles', 'scaffold')
|
|
const manifestPath = join(profile, 'package.json')
|
|
const manifestBefore = await readFile(manifestPath, 'utf8')
|
|
await writeFile(join(profile, 'config'), 'console.log("https://registry.npmjs.org/")\n')
|
|
await writeFile(join(profile, '.attempts'), '')
|
|
await writeFile(join(profile, 'add'), `
|
|
const fs = require('node:fs');
|
|
fs.appendFileSync('.attempts', JSON.stringify(process.argv) + '\\n');
|
|
console.error('pnpm must not start after the GitHub connection check fails');
|
|
process.exitCode = 1;
|
|
`)
|
|
const page = await browser.newPage({ viewport: { width: 1280, height: 800 }, locale: ZH_BROWSER_LOCALE })
|
|
const tripwire = watchConsole(page)
|
|
await page.goto(scaffold.authenticatedUrl)
|
|
await page.waitForSelector('[class*="frame"]')
|
|
if (await page.getByRole('dialog', { name: '设置' }).count() > 0) await page.keyboard.press('Escape')
|
|
await page.getByRole('navigation', { name: '全局面板' }).getByRole('button', { name: '插件', exact: true }).click()
|
|
await page.getByRole('button', { name: '添加插件', exact: true }).click()
|
|
const spec = 'https://github.com/example/dsh-plugin.git'
|
|
const title = failure === 'timeout' ? '连接 GitHub 超时' : '无法访问 GitHub'
|
|
let dialog = page.getByRole('dialog', { name: '添加插件', exact: true })
|
|
await dialog.getByRole('button', { name: '安装源 npm 官方源', exact: true }).waitFor()
|
|
await dialog.getByRole('textbox', { name: '包名或地址' }).fill(spec)
|
|
expect(await page.getByText(title, { exact: true }).count()).toBe(0)
|
|
await dialog.getByRole('button', { name: '安装', exact: true }).click()
|
|
dialog = page.getByRole('dialog', { name: title, exact: true })
|
|
await dialog.waitFor()
|
|
expect(await page.getByRole('dialog').count()).toBe(1)
|
|
expect(await dialog.getByText('请尝试其他安装来源。', { exact: true }).count()).toBe(1)
|
|
await compareOrRefreshGolden(
|
|
fileURLToPath(new URL(`./expected/plugin-install-github/${failure === 'timeout' ? 'timeout' : 'failed'}.expected.md`, import.meta.url)),
|
|
await captureStableAria(page, '[role="dialog"]', scaffold.workspaceCwd), webSnapshotMode(),
|
|
)
|
|
const attempts = await readFile(join(profile, '.attempts'), 'utf8')
|
|
expect(attempts).toBe('')
|
|
expect(connections).toBeGreaterThan(0)
|
|
await expect.poll(() => sockets.size).toBe(0)
|
|
const checked = connections
|
|
await dialog.getByRole('button', { name: '改用国内镜像', exact: true }).click()
|
|
dialog = page.getByRole('dialog', { name: '添加插件', exact: true })
|
|
const input = dialog.getByRole('textbox', { name: '插件包名', exact: true })
|
|
await input.waitFor()
|
|
expect(await input.inputValue()).toBe('')
|
|
expect(await input.evaluate(element => element === document.activeElement)).toBe(true)
|
|
expect(await dialog.getByRole('button', { name: '安装', exact: true }).isDisabled()).toBe(true)
|
|
await dialog.getByRole('button', { name: '安装源 中国大陆镜像源', exact: true }).waitFor()
|
|
await compareOrRefreshGolden(
|
|
fileURLToPath(new URL('./expected/plugin-install-github/mirror.expected.md', import.meta.url)),
|
|
await captureStableAria(page, '[role="dialog"]', scaffold.workspaceCwd), webSnapshotMode(),
|
|
)
|
|
expect(await readFile(join(profile, '.attempts'), 'utf8')).toBe(attempts)
|
|
expect(connections).toBe(checked)
|
|
expect(await readFile(manifestPath, 'utf8')).toBe(manifestBefore)
|
|
await input.fill(spec)
|
|
await dialog.getByRole('button', { name: '安装', exact: true }).click()
|
|
dialog = page.getByRole('dialog', { name: title, exact: true })
|
|
await dialog.waitFor()
|
|
await compareOrRefreshGolden(
|
|
fileURLToPath(new URL(`./expected/plugin-install-github/${failure === 'timeout' ? 'timeout' : 'failed'}-on-mirror.expected.md`, import.meta.url)),
|
|
await captureStableAria(page, '[role="dialog"]', scaffold.workspaceCwd), webSnapshotMode(),
|
|
)
|
|
await dialog.getByRole('button', { name: '试试其他方式', exact: true }).click()
|
|
dialog = page.getByRole('dialog', { name: '添加插件', exact: true })
|
|
await dialog.getByRole('button', { name: '收起引导', exact: true }).waitFor()
|
|
expect(await input.inputValue()).toBe('')
|
|
expect(await input.evaluate(element => element === document.activeElement)).toBe(true)
|
|
await compareOrRefreshGolden(
|
|
fileURLToPath(new URL('./expected/plugin-install-github/another-way.expected.md', import.meta.url)),
|
|
await captureStableAria(page, '[role="dialog"]', scaffold.workspaceCwd), webSnapshotMode(),
|
|
)
|
|
await input.fill(spec)
|
|
await dialog.getByRole('button', { name: '安装', exact: true }).click()
|
|
dialog = page.getByRole('dialog', { name: title, exact: true })
|
|
await dialog.getByRole('button', { name: '取消', exact: true }).click()
|
|
await dialog.waitFor({ state: 'detached' })
|
|
expect(await readFile(join(profile, '.attempts'), 'utf8')).toBe('')
|
|
expect(connections).toBeGreaterThan(checked)
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
})
|
|
|
|
it("shows the failed check's Git run and complete log in the installation details when no mirror is offered", async () => {
|
|
const scratch = await mkdtemp(join(tmpdir(), 'dsh-install-github-details-'))
|
|
onTestFinished(() => rm(scratch, { recursive: true, force: true }))
|
|
const sockets = new Set<Socket>()
|
|
const proxy = createServer((socket) => {
|
|
sockets.add(socket)
|
|
socket.on('error', () => {})
|
|
socket.once('close', () => { sockets.delete(socket) })
|
|
socket.once('data', () => socket.destroy())
|
|
})
|
|
onTestFinished(async () => {
|
|
for (const socket of sockets) socket.destroy()
|
|
await new Promise<void>((resolve, reject) => { proxy.close((error) => { if (error) reject(error); else resolve() }) })
|
|
})
|
|
proxy.listen(0, '127.0.0.1')
|
|
await once(proxy, 'listening')
|
|
const address = proxy.address()
|
|
if (address === null || typeof address === 'string') throw new Error('proxy did not bind a TCP port')
|
|
const gitConfig = join(scratch, 'git.config')
|
|
await writeFile(gitConfig, `[http "https://github.com/"]\n proxy = http://127.0.0.1:${String(address.port)}\n`)
|
|
// Without a configured fallback registry the Host has no mirror to offer, so the failure keeps the
|
|
// plain failed screen whose details name the check's own run.
|
|
const overlay = join(scratch, 'cordis.patch.yml')
|
|
await writeFile(overlay, '- id: ui-plugin-manager\n config: { registryProbeEnabled: false }\n- id: plugin-manager\n config: { fallbackRegistries: [] }\n')
|
|
const scaffold = await launchWebScaffold({
|
|
profile: { packages: [], packageManager: { command: process.execPath, args: [], env: { GIT_CONFIG_GLOBAL: gitConfig, GIT_CONFIG_NOSYSTEM: '1' } } },
|
|
extraOverlayPath: overlay,
|
|
})
|
|
onTestFinished(() => scaffold.close())
|
|
const browser = await chromium.launch()
|
|
onTestFinished(() => browser.close())
|
|
const profile = join(scaffold.harnessHome, 'profiles', 'scaffold')
|
|
const attempts = join(profile, '.attempts')
|
|
await writeFile(join(profile, 'config'), 'console.log("https://registry.npmjs.org/")\n')
|
|
await writeFile(attempts, '')
|
|
await writeFile(join(profile, 'add'), `
|
|
const fs = require('node:fs');
|
|
fs.appendFileSync('.attempts', JSON.stringify(process.argv) + '\\n');
|
|
process.exitCode = 1;
|
|
`)
|
|
const page = await browser.newPage({ viewport: { width: 1280, height: 800 }, locale: ZH_BROWSER_LOCALE })
|
|
const tripwire = watchConsole(page)
|
|
await page.goto(scaffold.authenticatedUrl)
|
|
await page.waitForSelector('[class*="frame"]')
|
|
if (await page.getByRole('dialog', { name: '设置' }).count() > 0) await page.keyboard.press('Escape')
|
|
await page.getByRole('navigation', { name: '全局面板' }).getByRole('button', { name: '插件', exact: true }).click()
|
|
await page.getByRole('button', { name: '添加插件', exact: true }).click()
|
|
const spec = 'https://github.com/example/dsh-plugin.git'
|
|
let dialog = page.getByRole('dialog', { name: '添加插件', exact: true })
|
|
await dialog.getByRole('textbox', { name: '包名或地址' }).fill(spec)
|
|
await dialog.getByRole('button', { name: '安装', exact: true }).click()
|
|
dialog = page.getByRole('dialog', { name: '插件安装失败', exact: true })
|
|
await dialog.waitFor()
|
|
expect(await dialog.getByText('无法连接 github.com', { exact: false }).count()).toBe(1)
|
|
// The details carry the failed check's own Git run and the complete log, not an empty terminal.
|
|
await dialog.getByRole('button', { name: '查看安装详情', exact: true }).click()
|
|
await dialog.getByText(/git -c credential\.helper= ls-remote -- https:\/\/github\.com\/example\/dsh-plugin\.git HEAD/).waitFor()
|
|
await dialog.getByText(/fatal: unable to access/).waitFor()
|
|
expect(await dialog.getByText(/^完整日志：.*github-connection-.*git\.log$/).count()).toBe(1)
|
|
expect(await readFile(attempts, 'utf8')).toBe('')
|
|
expect(tripwire.pageErrors).toEqual([])
|
|
})
|