/** * `dsh plugin add` and `remove` through the shared installer: a temporary * harness home, a fake pnpm that stages packages and edits the manifest the * way the real one does, and a static metadata reader. Nothing boots. */ import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs' import { tmpdir } from 'node:os' import { join } from 'node:path' import { PassThrough } from 'node:stream' import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' import { readProfileManifest, resolveProfileDir, type readPackageMetadata } from '@deepseek-ai/dsh-app-boot' import type { SpawnLike } from '@deepseek-ai/dsh-plugin-manager' import { runPlugin } from '../src/plugin.ts' let home: string let previousHome: string | undefined let stderr: string let stdout: string /** The FORCE_COLOR each fake pnpm run was spawned with. */ let spawnEnvs: (string | undefined)[] = [] beforeEach(() => { home = mkdtempSync(join(tmpdir(), 'dsh-plugin-command-')) previousHome = process.env.DSH_HOME process.env.DSH_HOME = home stderr = '' stdout = '' spawnEnvs = [] vi.spyOn(process.stderr, 'write').mockImplementation((chunk) => { stderr += String(chunk); return true }) vi.spyOn(process.stdout, 'write').mockImplementation((chunk) => { stdout += String(chunk); return true }) }) afterEach(() => { vi.restoreAllMocks() if (previousHome === undefined) delete process.env.DSH_HOME else process.env.DSH_HOME = previousHome rmSync(home, { recursive: true, force: true }) }) /** Stage one package under the profile's node_modules and record it as a dependency, as `pnpm add` does. */ function install(profileDir: string, name: string, bundle: boolean): void { const dir = join(profileDir, 'node_modules', name) mkdirSync(dir, { recursive: true }) writeFileSync(join(dir, 'package.json'), JSON.stringify({ name, version: '1.0.0', type: 'module', ...bundle ? { dsh: { bundle: { patch: './cordis.patch.yml' } } } : {}, })) if (bundle) writeFileSync(join(dir, 'cordis.patch.yml'), '- insert:\n - id: hello\n name: cordis:good\n') const path = join(profileDir, 'package.json') const manifest = JSON.parse(readFileSync(path, 'utf8')) as { dependencies?: Record } writeFileSync(path, JSON.stringify({ ...manifest, dependencies: { ...manifest.dependencies, [name]: '1.0.0' } }, null, 2)) } /** Forget one package, as `pnpm remove` does. */ function uninstall(profileDir: string, name: string): void { const path = join(profileDir, 'package.json') const manifest = JSON.parse(readFileSync(path, 'utf8')) as { dependencies?: Record } const { [name]: _gone, ...remaining } = manifest.dependencies ?? {} writeFileSync(path, JSON.stringify({ ...manifest, dependencies: remaining }, null, 2)) rmSync(join(profileDir, 'node_modules', name), { recursive: true, force: true }) } /** A pnpm that installs `ext-bundle` as a bundle and everything else as a plain library, or fails as told. */ function fakePnpm(calls: string[][], failWith?: { code: number } | { error: NodeJS.ErrnoException }): SpawnLike { return (spec) => { const [, ...args] = spec.argv calls.push([...args]) spawnEnvs.push(spec.env?.FORCE_COLOR) const stdout = new PassThrough() const stderr = new PassThrough() const done = Promise.resolve().then(() => { try { if (failWith !== undefined && 'error' in failWith) throw failWith.error if (failWith !== undefined) { stderr.write('ERR_PNPM_FETCH\n') return { exitCode: failWith.code, signal: null } } const [verb, target] = args if (verb === 'add' && target !== undefined) install(spec.cwd, target, target === 'ext-bundle') if (verb === 'remove' && target !== undefined) uninstall(spec.cwd, target) stdout.write(`\u001b[32m${verb === 'add' ? '+' : '-'}\u001b[39m ${String(target)}\n`) return { exitCode: 0, signal: null } } finally { stdout.end(); stderr.end() } }) return { stdin: undefined, stdout, stderr, control: undefined, collected: {}, done, terminate() {}, waitForExit: () => done.then(() => true, () => true), } } } /** Static fixture declarations: a bundle or an unknown package. */ const fakeMetadata: typeof readPackageMetadata = (options) => { const manifest = JSON.parse(readFileSync(join(options.profileDir, 'node_modules', options.packageName, 'package.json'), 'utf8')) as { dsh?: { bundle?: unknown } } return { packageName: options.packageName, kind: manifest.dsh?.bundle === undefined ? 'unknown' : 'bundle', cordisSameCopy: null, rows: [], overrides: [], addable: [], } } describe('dsh plugin', () => { it.each(['SIGINT', 'SIGTERM'] as const)('waits for an install interrupted by %s and removes its listener', async (signal) => { const before = process.listeners(signal) const done = Promise.withResolvers<{ exitCode: null; signal: 'SIGTERM' }>() const started = Promise.withResolvers() const stdout = new PassThrough() const stderr = new PassThrough() const run = runPlugin('web', ['add', 'slow'], { spawn: (spec) => { spec.signal?.addEventListener('abort', () => { stdout.end(); stderr.end(); done.resolve({ exitCode: null, signal: 'SIGTERM' }) }, { once: true }) started.resolve(undefined) return { stdin: undefined, stdout, stderr, control: undefined, collected: {}, done: done.promise, terminate() {}, waitForExit: () => done.promise.then(() => true), } } }) await started.promise const owned = process.listeners(signal).find(listener => !before.includes(listener)) expect(owned).toBeDefined() // Invoke only this command's listener; do not signal the test runner or other listeners. owned?.(signal) expect(await run).toBe(signal === 'SIGINT' ? 130 : 143) expect(process.listeners(signal)).toEqual(before) }) it('lets pnpm colour its output when stdout is a terminal', async () => { const calls: string[][] = [] const descriptor = Object.getOwnPropertyDescriptor(process.stdout, 'isTTY') Object.defineProperty(process.stdout, 'isTTY', { value: true, configurable: true }) try { expect(await runPlugin('web', ['add', 'ext-bundle'], { spawn: fakePnpm(calls), metadata: fakeMetadata })).toBe(0) } finally { if (descriptor === undefined) delete (process.stdout as { isTTY?: boolean }).isTTY else Object.defineProperty(process.stdout, 'isTTY', descriptor) } expect(spawnEnvs).toEqual(['1']) expect(stdout).toContain('\u001b[32m+\u001b[39m ext-bundle') }) it('add enables the new bundle and retains an undeclared dependency', async () => { const calls: string[][] = [] const code = await runPlugin('web', ['add', 'ext-bundle', 'ext-lib'], { spawn: fakePnpm(calls), metadata: fakeMetadata }) expect(code).toBe(0) const profileDir = resolveProfileDir('web', home) expect(stderr).toContain(`dsh: initialized profile web at ${profileDir}`) expect(calls).toEqual([['add', 'ext-bundle'], ['add', 'ext-lib']]) const manifest = readProfileManifest('dsh', profileDir) expect(Object.keys(manifest.dependencies ?? {})).toContain('ext-bundle') expect(Object.keys(manifest.dependencies ?? {})).toContain('ext-lib') expect(manifest.dsh?.profile?.bundles).toContain('ext-bundle') // The log reaches its readers plain: colours are off for the child and stripped from what it still prints. expect(spawnEnvs).toEqual(['0', '0']) expect(stdout).toContain('+ ext-bundle') expect(stdout).not.toContain('\u001b[') expect(stderr).toContain('ext-lib declares no dsh.bundle') expect(existsSync(join(profileDir, '.dsh-plugins', 'ext-bundle.json'))).toBe(false) }) it('remove goes through the installer and forgets the probe record', async () => { const calls: string[][] = [] await runPlugin('web', ['add', 'ext-bundle'], { spawn: fakePnpm(calls), metadata: fakeMetadata }) const code = await runPlugin('web', ['remove', 'ext-bundle'], { spawn: fakePnpm(calls), metadata: fakeMetadata }) expect(code).toBe(0) expect(calls).toEqual([['add', 'ext-bundle'], ['remove', 'ext-bundle']]) const profileDir = resolveProfileDir('web', home) const manifest = readProfileManifest('dsh', profileDir) expect(Object.keys(manifest.dependencies ?? {})).not.toContain('ext-bundle') expect(manifest.dsh?.profile?.bundles).not.toContain('ext-bundle') expect(existsSync(join(profileDir, '.dsh-plugins', 'ext-bundle.json'))).toBe(false) }) it('reports a failed pnpm run with its exit code, the git hint, and a missing pnpm as 127', async () => { const failed = await runPlugin('web', ['add', 'github:acme/plugin'], { spawn: fakePnpm([], { code: 1 }), metadata: fakeMetadata }) expect(failed).toBe(1) expect(stderr).toContain('dsh: pnpm failed in profile directory') expect(stderr).toContain('git-hosted plugins build on install via their prepare script') const error = Object.assign(new Error('spawn pnpm ENOENT'), { code: 'ENOENT' }) const missing = await runPlugin('web', ['add', 'ext-bundle'], { spawn: fakePnpm([], { error }), metadata: fakeMetadata }) expect(missing).toBe(127) expect(stderr).toContain('dsh: pnpm not found on PATH') }) })