From f3bb36263def15e21e0092c6a108edd2ffbdd271 Mon Sep 17 00:00:00 2001 From: yudshj Date: Fri, 9 Oct 2026 15:34:01 +0800 Subject: [PATCH] fix(client): complete hover-card coverage and steering golden --- packages/client/ui-primitives/tests/hover-card.client.spec.tsx | 2 ++ .../ui-user-questions/src/client/QuestionComposer.module.css | 1 + snapshots/web/steering/mid-steer.expected.md | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/client/ui-primitives/tests/hover-card.client.spec.tsx b/packages/client/ui-primitives/tests/hover-card.client.spec.tsx index e1730702db..a555826d23 100644 --- a/packages/client/ui-primitives/tests/hover-card.client.spec.tsx +++ b/packages/client/ui-primitives/tests/hover-card.client.spec.tsx @@ -913,6 +913,8 @@ it('scrolls an open callout with the focused anchor keyboard controls', () => { const scroll = document.querySelector('[data-hover-card-scroll]') as HTMLElement Object.defineProperty(scroll, 'clientHeight', { configurable: true, value: 160 }) Object.defineProperty(scroll, 'scrollHeight', { configurable: true, value: 640 }) + expect(fireEvent.keyDown(scroll, { key: 'PageDown' })).toBe(true) + expect(scroll.scrollTop).toBe(0) for (const [key, top] of [['ArrowDown', 20], ['ArrowUp', 0], ['PageDown', 160], ['PageUp', 0], ['End', 640], ['Home', 0]] as const) { expect(fireEvent.keyDown(anchor, { key })).toBe(false) expect(scroll.scrollTop).toBe(top) diff --git a/packages/client/ui-user-questions/src/client/QuestionComposer.module.css b/packages/client/ui-user-questions/src/client/QuestionComposer.module.css index 730be0fa6f..80841b8c3b 100644 --- a/packages/client/ui-user-questions/src/client/QuestionComposer.module.css +++ b/packages/client/ui-user-questions/src/client/QuestionComposer.module.css @@ -409,6 +409,7 @@ height: 16px; border: 1px solid currentColor; border-radius: 50%; + corner-shape: round; } .descriptionPreview { diff --git a/snapshots/web/steering/mid-steer.expected.md b/snapshots/web/steering/mid-steer.expected.md index 1527155f0b..267dbd18d5 100644 --- a/snapshots/web/steering/mid-steer.expected.md +++ b/snapshots/web/steering/mid-steer.expected.md @@ -16,9 +16,9 @@ - button "Copy" - region "Ready to continue?": - text: Checkpoint - - heading "Ready to continue?" [level=2] - button "Collapse the question card" [expanded] - button "Dismiss all questions" + - heading "Ready to continue?" [level=2] - radiogroup: - radio "Yes": 1 Yes - radio "No": 2 No