From 29541194cc5e58930597cc918e9b1e5b62f3ba8a Mon Sep 17 00:00:00 2001 From: Yichen Jiang Date: Mon, 9 Nov 2026 13:10:00 +0800 Subject: [PATCH] fix(forge-panel): keep thread avatars round and rebind the scrollbar on resolved cards The repository's stylesheet gates require a full-round radius to pair `corner-shape: round`, so the avatar and its image stay circles where corners are smoothed, and a scrolling surface on an elevated background to rebind the scrollbar thumb to the l2 pair. A resolved thread card paints `--dsw-alias-bg-layer-2` and holds the hunk excerpt and the file at that commit, which scroll, so it now sets `--dsh-scrollbar-thumb` and `--dsh-scrollbar-thumb-hover`. --- .../src/client/ReviewThreads.module.css | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/experimental/client-ui-forge/src/client/ReviewThreads.module.css b/packages/experimental/client-ui-forge/src/client/ReviewThreads.module.css index 6e2a9f2574..f241559196 100644 --- a/packages/experimental/client-ui-forge/src/client/ReviewThreads.module.css +++ b/packages/experimental/client-ui-forge/src/client/ReviewThreads.module.css @@ -29,7 +29,13 @@ margin-inline-start: clamp(10px, calc(100% - 740px), calc(50% + 10px)); } -.card[data-resolved] { background: var(--dsw-alias-bg-layer-2); } +.card[data-resolved] { + /* An elevated surface: the excerpt and the file at that commit scroll inside it, so the thumb takes the l2 pair, + which inherits down to them (see ui-theme styles/scrollbar.css for the rebinding contract). */ + --dsh-scrollbar-thumb: var(--dsw-alias-scrollbar-bg-l2); + --dsh-scrollbar-thumb-hover: var(--dsw-alias-scrollbar-hover-l2); + background: var(--dsw-alias-bg-layer-2); +} .folded { display: flex; @@ -114,6 +120,7 @@ justify-content: center; overflow: hidden; border-radius: 50%; + corner-shape: round; background: var(--dsw-alias-interactive-bg-hover); color: var(--dsw-alias-label-secondary); font-weight: 500; @@ -126,6 +133,7 @@ width: 100%; height: 100%; border-radius: 50%; + corner-shape: round; object-fit: cover; }