From 7e4045c4c070cbddb17ffba16fbb4ed014b9006d Mon Sep 17 00:00:00 2001 From: imccyu <276526105+imccyu@users.noreply.github.com> Date: Sat, 19 Sep 2026 12:54:14 +0800 Subject: [PATCH] test(client): align sidebar interactions and browser snapshots --- apps/web/tests/chat-long-interactions.e2e.ts | 2 +- apps/web/tests/chat-scroll-contract.e2e.ts | 2 +- apps/web/tests/composer-tab-geometry.e2e.ts | 2 +- .../created.expected.md | 1 - .../damaged.expected.md | 1 - .../section.expected.md | 1 - .../cards.expected.md | 1 - .../conversation-expanded.expected.md | 4 +- .../conversation.expected.md | 4 +- .../stored-error.expected.md | 1 - .../catalog-inputs.expected.md | 1 - .../models-settings/configured.expected.md | 1 - .../models-settings/declared-edit.expected.md | 1 - .../models-settings/declared.expected.md | 1 - .../models-settings/empty.expected.md | 1 - .../default-models.expected.md | 1 - .../models.expected.md | 1 - .../dismissed.expected.md | 1 - .../settings-chrome/dialog-en.expected.md | 1 - .../settings-chrome/dialog.expected.md | 1 - .../grouping-options.expected.md | 4 ++ apps/web/tests/message-actions.e2e.ts | 7 ++- apps/web/tests/navigation-panes.e2e.ts | 4 +- apps/web/tests/pwsh-terminal.e2e.ts | 2 +- apps/web/tests/rail-search-expand.e2e.ts | 2 +- apps/web/tests/schedule-after.e2e.ts | 2 +- apps/web/tests/session-unarchive.e2e.ts | 55 ++++--------------- apps/web/tests/subagent-conversation.e2e.ts | 3 +- .../tests/trajectory-virtualization.e2e.ts | 2 +- .../tests/tooltip-node.client.spec.ts | 10 ++++ .../tests/tooltip.client.spec.tsx | 17 ++++++ .../web/lifecycle-chrome/hero.expected.md | 2 +- .../plan-active-zh.expected.md | 2 +- .../lifecycle-chrome/plan-active.expected.md | 2 +- .../web/turn-tail-actions/settled.expected.md | 1 - 35 files changed, 67 insertions(+), 77 deletions(-) create mode 100644 packages/client/ui-primitives/tests/tooltip-node.client.spec.ts diff --git a/apps/web/tests/chat-long-interactions.e2e.ts b/apps/web/tests/chat-long-interactions.e2e.ts index 33c8046779..fe8a284967 100644 --- a/apps/web/tests/chat-long-interactions.e2e.ts +++ b/apps/web/tests/chat-long-interactions.e2e.ts @@ -83,7 +83,7 @@ async function openSeed(page: Page): Promise { // Search collapsed into a header action; expand it before filling. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByRole('textbox', { name: 'Search sessions...', exact: true }) + const search = page.getByRole('textbox', { name: 'Search session names', exact: true }) await search.fill(FIXTURE.markers.user(1)) const results = page.getByRole('tree', { name: 'Search results' }).getByRole('treeitem') await results.first().waitFor({ timeout: 60_000 }) diff --git a/apps/web/tests/chat-scroll-contract.e2e.ts b/apps/web/tests/chat-scroll-contract.e2e.ts index 17485b10bc..2a13b8ef3e 100644 --- a/apps/web/tests/chat-scroll-contract.e2e.ts +++ b/apps/web/tests/chat-scroll-contract.e2e.ts @@ -291,7 +291,7 @@ async function openSeed(page: Page, fixture: ChatScrollFixture, tailMarker?: str // Search collapsed into a header action; expand it before filling. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByRole('textbox', { name: 'Search sessions...', exact: true }) + const search = page.getByRole('textbox', { name: 'Search session names', exact: true }) // Cold summaries initially show the temporary workspace basename, so the // persisted first-prompt marker is the stable user-facing identity. The // query itself triggers lazy content-index reconciliation; no transient diff --git a/apps/web/tests/composer-tab-geometry.e2e.ts b/apps/web/tests/composer-tab-geometry.e2e.ts index ee8c9a07df..9eda0bb603 100644 --- a/apps/web/tests/composer-tab-geometry.e2e.ts +++ b/apps/web/tests/composer-tab-geometry.e2e.ts @@ -192,7 +192,7 @@ async function openSeededSession(page: Page): Promise { // Search collapsed into a header action; expand it before filling. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByRole('textbox', { name: 'Search sessions...', exact: true }) + const search = page.getByRole('textbox', { name: 'Search session names', exact: true }) await search.fill(FIXTURE.markers.user(1)) const results = page.getByRole('tree', { name: 'Search results' }).getByRole('treeitem') const deadline = Date.now() + 60_000 diff --git a/apps/web/tests/expected/agent-preset-authoring/created.expected.md b/apps/web/tests/expected/agent-preset-authoring/created.expected.md index 033bf298ae..f55d4098d2 100644 --- a/apps/web/tests/expected/agent-preset-authoring/created.expected.md +++ b/apps/web/tests/expected/agent-preset-authoring/created.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "Agent 预设" [level=2] diff --git a/apps/web/tests/expected/agent-preset-authoring/damaged.expected.md b/apps/web/tests/expected/agent-preset-authoring/damaged.expected.md index c28c733b10..2d4db679fb 100644 --- a/apps/web/tests/expected/agent-preset-authoring/damaged.expected.md +++ b/apps/web/tests/expected/agent-preset-authoring/damaged.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "Agent 预设" [level=2] diff --git a/apps/web/tests/expected/agent-preset-authoring/section.expected.md b/apps/web/tests/expected/agent-preset-authoring/section.expected.md index 471f6bbada..077c88b625 100644 --- a/apps/web/tests/expected/agent-preset-authoring/section.expected.md +++ b/apps/web/tests/expected/agent-preset-authoring/section.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "Agent 预设" [level=2] diff --git a/apps/web/tests/expected/deepseek-messages-settings/cards.expected.md b/apps/web/tests/expected/deepseek-messages-settings/cards.expected.md index 2a879d6b31..7df4c7ce8a 100644 --- a/apps/web/tests/expected/deepseek-messages-settings/cards.expected.md +++ b/apps/web/tests/expected/deepseek-messages-settings/cards.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/github-ready-review/conversation-expanded.expected.md b/apps/web/tests/expected/github-ready-review/conversation-expanded.expected.md index 610d173e1e..6618682d61 100644 --- a/apps/web/tests/expected/github-ready-review/conversation-expanded.expected.md +++ b/apps/web/tests/expected/github-ready-review/conversation-expanded.expected.md @@ -1,8 +1,10 @@ - tree "Sessions": - treeitem "{{workspace}}" [expanded] - - treeitem "Review deepseek-ai/deepseek-harness#314 Session actions for Review deepseek-ai/deepseek-harness#314" [selected]: + - treeitem "Review deepseek-ai/deepseek-harness#314 Session actions for Review deepseek-ai/deepseek-harness#314 Archive session Pin session" [selected]: - text: Review deepseek-ai/deepseek-harness#314 - button "Session actions for Review deepseek-ai/deepseek-harness#314" + - button "Archive session" + - button "Pin session" --- diff --git a/apps/web/tests/expected/github-ready-review/conversation.expected.md b/apps/web/tests/expected/github-ready-review/conversation.expected.md index 7167daea13..87b48ef41c 100644 --- a/apps/web/tests/expected/github-ready-review/conversation.expected.md +++ b/apps/web/tests/expected/github-ready-review/conversation.expected.md @@ -1,8 +1,10 @@ - tree "Sessions": - treeitem "{{workspace}}" [expanded] - - treeitem "Review deepseek-ai/deepseek-harness#314 Session actions for Review deepseek-ai/deepseek-harness#314" [selected]: + - treeitem "Review deepseek-ai/deepseek-harness#314 Session actions for Review deepseek-ai/deepseek-harness#314 Archive session Pin session" [selected]: - text: Review deepseek-ai/deepseek-harness#314 - button "Session actions for Review deepseek-ai/deepseek-harness#314" + - button "Archive session" + - button "Pin session" --- diff --git a/apps/web/tests/expected/models-settings-recovery/stored-error.expected.md b/apps/web/tests/expected/models-settings-recovery/stored-error.expected.md index 782e523ddb..69e631f4cd 100644 --- a/apps/web/tests/expected/models-settings-recovery/stored-error.expected.md +++ b/apps/web/tests/expected/models-settings-recovery/stored-error.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/models-settings/catalog-inputs.expected.md b/apps/web/tests/expected/models-settings/catalog-inputs.expected.md index aa803a766c..e30e6cc2dd 100644 --- a/apps/web/tests/expected/models-settings/catalog-inputs.expected.md +++ b/apps/web/tests/expected/models-settings/catalog-inputs.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/models-settings/configured.expected.md b/apps/web/tests/expected/models-settings/configured.expected.md index 3758c2af62..f294ff5977 100644 --- a/apps/web/tests/expected/models-settings/configured.expected.md +++ b/apps/web/tests/expected/models-settings/configured.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/models-settings/declared-edit.expected.md b/apps/web/tests/expected/models-settings/declared-edit.expected.md index e8b2579203..fcaeb76e56 100644 --- a/apps/web/tests/expected/models-settings/declared-edit.expected.md +++ b/apps/web/tests/expected/models-settings/declared-edit.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/models-settings/declared.expected.md b/apps/web/tests/expected/models-settings/declared.expected.md index 4844a60cfa..d752bbb42a 100644 --- a/apps/web/tests/expected/models-settings/declared.expected.md +++ b/apps/web/tests/expected/models-settings/declared.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/models-settings/empty.expected.md b/apps/web/tests/expected/models-settings/empty.expected.md index 6a369b9267..8ce2f31098 100644 --- a/apps/web/tests/expected/models-settings/empty.expected.md +++ b/apps/web/tests/expected/models-settings/empty.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/onboarding-deepseek-config/default-models.expected.md b/apps/web/tests/expected/onboarding-deepseek-config/default-models.expected.md index 4920e310b8..be77e20835 100644 --- a/apps/web/tests/expected/onboarding-deepseek-config/default-models.expected.md +++ b/apps/web/tests/expected/onboarding-deepseek-config/default-models.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/onboarding-deepseek-config/models.expected.md b/apps/web/tests/expected/onboarding-deepseek-config/models.expected.md index 8bccdd9d12..9e344cc148 100644 --- a/apps/web/tests/expected/onboarding-deepseek-config/models.expected.md +++ b/apps/web/tests/expected/onboarding-deepseek-config/models.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/onboarding-usable-provider/dismissed.expected.md b/apps/web/tests/expected/onboarding-usable-provider/dismissed.expected.md index 76ba608af1..0279600e91 100644 --- a/apps/web/tests/expected/onboarding-usable-provider/dismissed.expected.md +++ b/apps/web/tests/expected/onboarding-usable-provider/dismissed.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - heading "模型" [level=2] diff --git a/apps/web/tests/expected/settings-chrome/dialog-en.expected.md b/apps/web/tests/expected/settings-chrome/dialog-en.expected.md index ace79f9802..41d6462e11 100644 --- a/apps/web/tests/expected/settings-chrome/dialog-en.expected.md +++ b/apps/web/tests/expected/settings-chrome/dialog-en.expected.md @@ -5,7 +5,6 @@ - button "Models" - button "Built-in plugins" - button "Agent presets" - - button "Archived sessions" - button "Open configuration file" - button "Close" - text: Permission Choose the default permission mode for new sessions diff --git a/apps/web/tests/expected/settings-chrome/dialog.expected.md b/apps/web/tests/expected/settings-chrome/dialog.expected.md index 212fabd235..9a3776bcb7 100644 --- a/apps/web/tests/expected/settings-chrome/dialog.expected.md +++ b/apps/web/tests/expected/settings-chrome/dialog.expected.md @@ -5,7 +5,6 @@ - button "模型" - button "内置插件" - button "Agent 预设" - - button "已归档会话" - button "打开配置文件" - button "关闭" - text: 权限 选择新会话的默认权限模式 diff --git a/apps/web/tests/expected/workspace-management/grouping-options.expected.md b/apps/web/tests/expected/workspace-management/grouping-options.expected.md index 4652128ef7..2a91c7813d 100644 --- a/apps/web/tests/expected/workspace-management/grouping-options.expected.md +++ b/apps/web/tests/expected/workspace-management/grouping-options.expected.md @@ -7,3 +7,7 @@ - text: Order by - menuitem "Manual" - menuitem "Last updated" + - separator + - text: Filter sessions + - menuitem "Show archived" + - menuitem "Archived only" diff --git a/apps/web/tests/message-actions.e2e.ts b/apps/web/tests/message-actions.e2e.ts index 85a16c58a5..2530ec0497 100644 --- a/apps/web/tests/message-actions.e2e.ts +++ b/apps/web/tests/message-actions.e2e.ts @@ -241,9 +241,10 @@ describe('web e2e: message IconActions and clocks on settled history', () => { () => branchButtons.evaluateAll(buttons => buttons.map(button => button.getAttribute('aria-disabled'))), { timeout: 5_000 }, ).toEqual(['true', null, null]) - await branchButtons.first().focus() - await expect.poll(() => page.getByRole('tooltip').textContent(), { timeout: 5_000 }) - .toBe('Available only on the last message of a completed turn') + await branchButtons.first().press('Shift+Tab') + await page.keyboard.press('Tab') + await expect.poll(() => page.getByRole('tooltip').allTextContents(), { timeout: 5_000 }) + .toEqual(['Available only on the last message of a completed turn']) await expect.poll(() => page.getByRole('button', { name: 'Edit' }).count(), { timeout: 5_000 }).toBe(0) }, 60_000) diff --git a/apps/web/tests/navigation-panes.e2e.ts b/apps/web/tests/navigation-panes.e2e.ts index 22d35431e1..4ab75b3ba0 100644 --- a/apps/web/tests/navigation-panes.e2e.ts +++ b/apps/web/tests/navigation-panes.e2e.ts @@ -62,7 +62,7 @@ async function ensureSeedOpen(page: Page): Promise { // Search is a collapsed header action; expand it so the input is actionable. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByPlaceholder('Search sessions', { exact: false }) + const search = page.getByPlaceholder('Search session names', { exact: false }) if (await chat.count() === 0) { await search.fill('WATERFALL') const result = page.getByRole('tree', { name: 'Search results' }).getByRole('treeitem') @@ -188,7 +188,7 @@ describe('web e2e: navigation & panes over a rich seeded session', () => { // Search is a collapsed header action; expand it so the input is actionable. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByPlaceholder('Search sessions', { exact: false }) + const search = page.getByPlaceholder('Search session names', { exact: false }) // The cold row has not been opened, so only the persisted log can satisfy // this query. First search lazily reconciles the SQLite content index. await search.fill('zzzqx-no-such-session') diff --git a/apps/web/tests/pwsh-terminal.e2e.ts b/apps/web/tests/pwsh-terminal.e2e.ts index 6069367555..3cefc1f0d4 100644 --- a/apps/web/tests/pwsh-terminal.e2e.ts +++ b/apps/web/tests/pwsh-terminal.e2e.ts @@ -72,7 +72,7 @@ describe.skipIf(MODE === 'record' || !HAS_PWSH)('web e2e: pwsh calls use the bas // collapsed header action; expand it so the input is actionable. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByPlaceholder('Search sessions', { exact: false }) + const search = page.getByPlaceholder('Search session names', { exact: false }) await search.fill('Run a PowerShell command') const result = page.getByRole('tree', { name: 'Search results' }).getByRole('treeitem') await expect.poll(() => result.count(), { timeout: 15_000 }).toBe(1) diff --git a/apps/web/tests/rail-search-expand.e2e.ts b/apps/web/tests/rail-search-expand.e2e.ts index df0130ff67..9070437dcb 100644 --- a/apps/web/tests/rail-search-expand.e2e.ts +++ b/apps/web/tests/rail-search-expand.e2e.ts @@ -53,7 +53,7 @@ describe('web e2e: rail search click survives its own document-level bubble', () const wideSearch = page.getByRole('button', { name: 'Search sessions' }) await expect.poll(async () => wideSearch.getAttribute('aria-expanded'), { timeout: 10_000 }).toBe('true') - const input = page.getByPlaceholder('Search sessions...') + const input = page.getByPlaceholder('Search session names') await expect.poll( async () => input.evaluate(el => document.activeElement === el), { timeout: FOCUS_SETTLE_MS + 10_000 }, diff --git a/apps/web/tests/schedule-after.e2e.ts b/apps/web/tests/schedule-after.e2e.ts index f20752bece..8b3e954d58 100644 --- a/apps/web/tests/schedule-after.e2e.ts +++ b/apps/web/tests/schedule-after.e2e.ts @@ -681,7 +681,7 @@ describe.skipIf(MODE === 'record')('web e2e: active Schedule catalog', () => { expect(await catalogRow.getByRole('img', { name: ACTIVE_SCHEDULE_LABEL }).count()).toBe(1) await page.getByRole('button', { name: 'Search sessions' }).click() - const search = page.getByPlaceholder('Search sessions', { exact: false }) + const search = page.getByPlaceholder('Search session names', { exact: false }) await search.fill(CATALOG_TITLE) const result = page.getByRole('tree', { name: 'Search results' }) .getByRole('treeitem', { name: new RegExp(CATALOG_TITLE) }) diff --git a/apps/web/tests/session-unarchive.e2e.ts b/apps/web/tests/session-unarchive.e2e.ts index 81fd5da3cb..068f5c0b6b 100644 --- a/apps/web/tests/session-unarchive.e2e.ts +++ b/apps/web/tests/session-unarchive.e2e.ts @@ -1,8 +1,5 @@ -// Web e2e scenario: the archived-session Settings page restores a Session -// through the real wire, from its row menu through the archive set, the page, -// and the reload that rebuilds state from the host baseline. Zero model calls: -// both verbs are host RPCs and the page reads already-loaded Session summaries, -// so no replay fixture mounts and a stray model stream fails loud. +// Archive and restore through sidebar row menus and the archived filter, +// then reload from the Host baseline. This flow makes no model calls. import { readFile } from 'node:fs/promises' import { fileURLToPath } from 'node:url' import type { Browser, Locator, Page } from 'playwright' @@ -19,7 +16,7 @@ import { newEnglishPage, saveFailureShot } from './support.ts' const SEED = fileURLToPath(new URL('../../../snapshots/web/seeded-history/session.v3.jsonl', import.meta.url)) const SEED_ID = 'session-unarchive-web-e2e' -describe('web e2e: archived sessions are restored from the Settings page', () => { +describe('web e2e: archived sessions are restored from the sidebar filter', () => { let scaffold: WebScaffold let browser: Browser let page: Page @@ -76,7 +73,7 @@ describe('web e2e: archived sessions are restored from the Settings page', () => await scaffold?.close() }) - it('archives the seed, unarchives it from Settings, and keeps it restored across reload', async () => { + it('archives the seed, restores it through the sidebar filter, and keeps it restored across reload', async () => { onTestFailed(() => saveFailureShot(page, 'web-e2e-session-unarchive')) // Select the only visible Session, then give it a user-owned title: the // locator binds to the seed's own copy on both sides of the round trip. @@ -104,46 +101,18 @@ describe('web e2e: archived sessions are restored from the Settings page', () => expect((await scaffold.ctx.sessionPersistence.list()).map(snapshot => snapshot.header.id)) .toContain(SessionId(SEED_ID)) - // The Settings page lists the archived Session behind its own search box. - await page.getByRole('button', { name: 'Settings', exact: true }).click() - const dialog = page.getByRole('dialog', { name: 'Settings' }) - await dialog.waitFor({ timeout: 10_000 }) - await dialog.getByRole('button', { name: 'Archived sessions' }).click() - const search = dialog.getByRole('searchbox', { name: 'Search archived sessions' }) - await search.waitFor({ timeout: 10_000 }) - const unarchiveRow = dialog.getByRole('button', { name: `Unarchive ${title}` }) - await expect.poll(() => unarchiveRow.count(), { timeout: 10_000 }).toBe(1) - expect(await dialog.getByText(title, { exact: true }).count()).toBe(1) - expect(await dialog.getByText(/^Ungrouped · /).count()).toBe(1) - expect(await dialog.getByText('No archived sessions.', { exact: true }).count()).toBe(0) - // The search box filters these rows in both directions. - await search.fill('zzz-no-such-archived-session') - await expect.poll( - () => dialog.getByText('No matching sessions.', { exact: true }).count(), - { timeout: 5_000 }, - ).toBe(1) - expect(await unarchiveRow.count()).toBe(0) - await search.fill(title) - await expect.poll(() => unarchiveRow.count(), { timeout: 5_000 }).toBe(1) - expect(await dialog.getByText('No matching sessions.', { exact: true }).count()).toBe(0) - await search.fill('') - await expect.poll(() => unarchiveRow.count(), { timeout: 5_000 }).toBe(1) - - // Unarchive: the durable set empties (the row's own RPC), the page row - // leaves with the empty status, and the Session row is back in the sidebar. - await unarchiveRow.click() + await page.getByRole('button', { name: 'View options' }).click() + await page.getByRole('menuitem', { name: 'Show archived', exact: true }).click() + await ungroupedSection() + await expect.poll(() => sessionRow.count(), { timeout: 10_000 }).toBe(1) + await clickHoverAction(sessionRow, `Session actions for ${title}`) + await page.getByRole('menuitem', { name: 'Unarchive session' }).click() await expect.poll( () => [...scaffold.ctx.workspaceRegistry.archivedSessionIds], { timeout: 10_000 }, ).toEqual([]) - await expect.poll(() => unarchiveRow.count(), { timeout: 10_000 }).toBe(0) - expect(await dialog.getByText(title, { exact: true }).count()).toBe(0) - await expect.poll( - () => dialog.getByText('No archived sessions.', { exact: true }).count(), - { timeout: 10_000 }, - ).toBe(1) - await dialog.getByRole('button', { name: 'Close' }).last().click() - await dialog.waitFor({ state: 'hidden', timeout: 10_000 }) + await page.getByRole('button', { name: 'View options' }).click() + await page.getByRole('menuitem', { name: 'Show archived', exact: true }).click() await ungroupedSection() await expect.poll(() => sessionRow.count(), { timeout: 15_000 }).toBe(1) diff --git a/apps/web/tests/subagent-conversation.e2e.ts b/apps/web/tests/subagent-conversation.e2e.ts index 4530b1f040..d78c935cec 100644 --- a/apps/web/tests/subagent-conversation.e2e.ts +++ b/apps/web/tests/subagent-conversation.e2e.ts @@ -595,7 +595,8 @@ describe('web e2e: persisted subagent conversation and human continuation', () = () => page.getByRole('tree', { name: 'Sessions' }).getByRole('treeitem').count(), { timeout: 15_000 }, ).toBe(3) - expect(await page.getByText('Ungrouped', { exact: true }).count()).toBe(0) + expect(await page.getByRole('tree', { name: 'Sessions' }) + .getByRole('treeitem', { name: 'Ungrouped', exact: true }).count()).toBe(0) const hierarchy = page.getByRole('navigation', { name: 'Session hierarchy' }) await expect.poll(() => hierarchy.getByRole('button').count()).toBe(1) await compareOrRefreshGolden( diff --git a/apps/web/tests/trajectory-virtualization.e2e.ts b/apps/web/tests/trajectory-virtualization.e2e.ts index 20a8ee340c..31a2c773db 100644 --- a/apps/web/tests/trajectory-virtualization.e2e.ts +++ b/apps/web/tests/trajectory-virtualization.e2e.ts @@ -71,7 +71,7 @@ async function openSeed(page: Page): Promise { // Search collapsed into a header action; expand it before filling. const searchButton = page.getByRole('button', { name: 'Search sessions' }) if (await searchButton.getAttribute('aria-expanded') !== 'true') await searchButton.click() - const search = page.getByRole('textbox', { name: 'Search sessions...', exact: true }) + const search = page.getByRole('textbox', { name: 'Search session names', exact: true }) await search.fill(FIXTURE.markers.user(1)) const result = page.getByRole('tree', { name: 'Search results' }).getByRole('treeitem') await expect.poll(() => result.count(), { timeout: 60_000 }).toBe(1) diff --git a/packages/client/ui-primitives/tests/tooltip-node.client.spec.ts b/packages/client/ui-primitives/tests/tooltip-node.client.spec.ts new file mode 100644 index 0000000000..c0026ecdbd --- /dev/null +++ b/packages/client/ui-primitives/tests/tooltip-node.client.spec.ts @@ -0,0 +1,10 @@ +// @vitest-environment node +import { describe, expect, it } from 'vitest' +import { Tooltip } from '../src/Tooltip.tsx' + +describe('Tooltip module in Node', () => { + it('loads without installing browser input listeners', () => { + expect(typeof window).toBe('undefined') + expect(Tooltip).toBeTypeOf('function') + }) +}) diff --git a/packages/client/ui-primitives/tests/tooltip.client.spec.tsx b/packages/client/ui-primitives/tests/tooltip.client.spec.tsx index e17eaf532b..3f1c4f059c 100644 --- a/packages/client/ui-primitives/tests/tooltip.client.spec.tsx +++ b/packages/client/ui-primitives/tests/tooltip.client.spec.tsx @@ -95,6 +95,23 @@ describe('Tooltip', () => { const rect = (left: number, right: number): DOMRect => ({ left, right, top: 0, bottom: 20, width: right - left, height: 20, x: left, y: 0, toJSON: () => ({}) }) + it('aligns the end of a bottom tooltip with the anchor right edge', () => { + const spy = vi.spyOn(Element.prototype, 'getBoundingClientRect').mockReturnValue(rect(100, 200)) + try { + render( + + + , + ) + fireEvent.mouseEnter(screen.getByText('anchor')) + const bubble = screen.getByRole('tooltip') + expect(bubble.getAttribute('data-align')).toBe('end') + expect(bubble.style.left).toBe('200px') + } finally { + spy.mockRestore() + } + }) + it('caps the bubble width where the label would otherwise slab across the surface', () => { render( diff --git a/snapshots/web/lifecycle-chrome/hero.expected.md b/snapshots/web/lifecycle-chrome/hero.expected.md index fb7a487585..ce6698be33 100644 --- a/snapshots/web/lifecycle-chrome/hero.expected.md +++ b/snapshots/web/lifecycle-chrome/hero.expected.md @@ -5,7 +5,7 @@ - button "Plugins" - text: Workspaces - button "Search sessions" -- textbox "Search sessions..." +- textbox "Search session names" - button "View options" - button "Add workspace" - tree "Sessions": diff --git a/snapshots/web/lifecycle-chrome/plan-active-zh.expected.md b/snapshots/web/lifecycle-chrome/plan-active-zh.expected.md index 14104cb63f..c01c19bc4b 100644 --- a/snapshots/web/lifecycle-chrome/plan-active-zh.expected.md +++ b/snapshots/web/lifecycle-chrome/plan-active-zh.expected.md @@ -5,7 +5,7 @@ - button "插件" - text: 工作区 - button "搜索会话" -- textbox "搜索会话…" +- textbox "搜索会话名称" - button "视图选项" - button "添加工作区" - tree "会话": diff --git a/snapshots/web/lifecycle-chrome/plan-active.expected.md b/snapshots/web/lifecycle-chrome/plan-active.expected.md index 9f0c91f1c3..dee04dc9e8 100644 --- a/snapshots/web/lifecycle-chrome/plan-active.expected.md +++ b/snapshots/web/lifecycle-chrome/plan-active.expected.md @@ -5,7 +5,7 @@ - button "Plugins" - text: Workspaces - button "Search sessions" -- textbox "Search sessions..." +- textbox "Search session names" - button "View options" - button "Add workspace" - tree "Sessions": diff --git a/snapshots/web/turn-tail-actions/settled.expected.md b/snapshots/web/turn-tail-actions/settled.expected.md index 4312288efa..c04c99e14e 100644 --- a/snapshots/web/turn-tail-actions/settled.expected.md +++ b/snapshots/web/turn-tail-actions/settled.expected.md @@ -14,7 +14,6 @@ - paragraph: partial - text: Stopped - button "Copy" -- tooltip "Copy" - button "Good response" - button "Bad response" - button "Branch into a new conversation"