From 6861ac745992a970910d8ca90cc35529ce46aded Mon Sep 17 00:00:00 2001 From: Tianyi Cui <53024+tianyicui@users.noreply.github.com> Date: Sun, 6 Sep 2026 14:47:31 +0800 Subject: [PATCH] refactor(client): trust narrowed surface event markers The in-operator narrows SessionEvent to events whose surfaceOp is required. Remove redundant undefined checks from both target Definitions; retain append-versus-replacement discrimination and shared prompt interpretation. This deletes dead conditions reported by the full type-aware CI lint gate without adding fallback behavior. Validation: both Chat and Trajectory definition regression suites pass with the simplified predicates. --- .../ui-chat/src/client/conversation-nodes/request-prompt.ts | 2 +- .../src/client/trajectory-request-header-definition.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/client/ui-chat/src/client/conversation-nodes/request-prompt.ts b/packages/client/ui-chat/src/client/conversation-nodes/request-prompt.ts index b974a4bb6b..60b251b478 100644 --- a/packages/client/ui-chat/src/client/conversation-nodes/request-prompt.ts +++ b/packages/client/ui-chat/src/client/conversation-nodes/request-prompt.ts @@ -66,7 +66,7 @@ export function systemMessageDefinition(inspect: SystemPromptInspector): Convers kind: 'system-message', target: 'chat', match: event => event.type === 'system/message' - || ('surfaceOp' in event && event.surfaceOp !== undefined && event.surfaceOp !== 'append') + || ('surfaceOp' in event && event.surfaceOp !== 'append') ? { id: String(event.seq), role: 'start' } : null, start: (_context, match, reader) => { diff --git a/packages/client/ui-trajectory/src/client/trajectory-request-header-definition.ts b/packages/client/ui-trajectory/src/client/trajectory-request-header-definition.ts index 130031718e..d8e8a754dc 100644 --- a/packages/client/ui-trajectory/src/client/trajectory-request-header-definition.ts +++ b/packages/client/ui-trajectory/src/client/trajectory-request-header-definition.ts @@ -34,7 +34,7 @@ function trajectorySystemMessageDefinition(inspect: SystemPromptInspector): Conv kind: 'trajectory-system-message', target: 'trajectory', match: event => event.type === 'system/message' - || ('surfaceOp' in event && event.surfaceOp !== undefined && event.surfaceOp !== 'append') + || ('surfaceOp' in event && event.surfaceOp !== 'append') ? { id: String(event.seq), role: 'start' } : null, start: (_context, match, reader) => {