From 449a4610d7fe906a69ca3e666dbd008d4d62ece2 Mon Sep 17 00:00:00 2001 From: liukx0205 Date: Tue, 15 Sep 2026 13:52:49 +0800 Subject: [PATCH] fix(client): keep the browser ring on the focused menu row The menu family was the only place that suppressed the browser's default focus ring. It keeps that ring now, like the app's other controls, on top of the hover fill a walked row already carried. --- packages/client/ui-primitives/src/Menu.module.css | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/client/ui-primitives/src/Menu.module.css b/packages/client/ui-primitives/src/Menu.module.css index 29f985b00b..fd61361bb6 100644 --- a/packages/client/ui-primitives/src/Menu.module.css +++ b/packages/client/ui-primitives/src/Menu.module.css @@ -117,12 +117,10 @@ } /* Arrow navigation moves real focus, so the row the keyboard is on carries the - same fill the pointer gets: without it nothing shows which row is current. - The fill replaces the browser's default ring — the composer's other triggers - suppress theirs the same way — so no blue outline frames the row. */ + same fill the pointer gets on top of the browser's own focus ring, which the + app's other controls keep too. */ .item:focus-visible:not(:disabled) { background: var(--dsw-alias-interactive-bg-hover); - outline: none; } .denseList .item { @@ -219,7 +217,6 @@ .danger:focus-visible:not(:disabled) { background: var(--dsw-alias-interactive-bg-hover-danger); - outline: none; } /* Heading row: non-interactive small grey text, padding aligned with items. */