Miles WardandClaude Opus 4.8
674a69f93b
Final cleanup before hardware testing. No behaviour changes; 248 tests green, clippy clean. #1 AppError newtype (http-api/src/error.rs) with one IntoResponse mapping (NotFound→404, Invalid→400, _→500) + From<core::Error>/From<io::Error>. Converted the clearly-safe handlers (sso_put, unattended_upload, branding_clear) to `?`; intentionally left handlers with bespoke status semantics (Invalid→404 on category, 409 on duplicate share / open upload) explicit so no asserted status changes. #2 figment-based Config::load (defaults → TOML → env). Keeps the historical flat OPENPXE_* names (Unraid/entrypoint compatible) AND adds the nested OPENPXE_SECTION__FIELD form; now covers every field (apply_env had silently skipped unattended_dir + bind addrs). 6 Jail tests prove backward-compat. Removed the hand-rolled apply_env. #3 thiserror 1→2; dropped unused mime/mime_guess/once_cell deps. #4 Re-evaluated: Duration::from_hours/from_mins are stable on the pinned 1.95 toolchain and clippy prefers them — kept the readable form (the "unstable" premise didn't hold; MSRV is intentionally 1.95). #5 insta snapshot of the rendered iPXE menu (version-filtered) + wiremock coverage of the SAML metadata-URL fetch (200 + non-2xx). #6 api_status → typed StatusResponse struct (was a 25-key json! blob) with a full_flow guard test asserting every UI key + the started_at string shape. Deferred the /api/docs typed conversion (lowest value, highest churn, zero functional benefit). #7 pct_encode/xml_escape de-duplicated into openpxe_core::encoding (were copied across app.rs + the SAML modules). No new crates. #8 UploadSessions registry → parking_lot::RwLock (sync, never held across .await); per-session lock stays tokio::Mutex. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
30 lines
1.0 KiB
Rust
30 lines
1.0 KiB
Rust
//! HTTP server — single axum app that serves:
|
|
//! - `/` the web UI (static assets from `openpxe-webui`)
|
|
//! - `/api/*` JSON API for the web UI
|
|
//! - `/boot.ipxe` the generated top-level iPXE boot menu
|
|
//! - `/boot/<entry>.ipxe` per-entry iPXE scripts (one per boot target)
|
|
//! - `/ipxe/<file>` bundled iPXE binaries (for UEFI HTTP boot)
|
|
//! - `/iso/<id>.iso` raw ISO file (with Range support)
|
|
//! - `/iso/<id>/<path>` files inside the ISO (for wimboot WIM fetches
|
|
//! and Linux kernel/initrd, without having to
|
|
//! re-extract on every request)
|
|
//!
|
|
//! The `<id>/<path>` handler uses a read-only ISO9660 shim (see `iso_fs`)
|
|
//! that lseeks into the ISO on disk — so we never keep extracted copies.
|
|
#![forbid(unsafe_code)]
|
|
|
|
pub mod app;
|
|
pub mod auth;
|
|
pub mod error;
|
|
pub mod ipxe_script;
|
|
pub mod iso_fs;
|
|
pub mod log_stream;
|
|
pub mod notify;
|
|
pub mod saml_routes;
|
|
pub mod state;
|
|
pub mod terminal;
|
|
pub mod uploads;
|
|
|
|
pub use app::build_router;
|
|
pub use state::AppState;
|