OpenPXE

26 Commits 1 Branch 41 Tags

2 Commits

Include renames

Author	SHA1	Message	Date
Miles WardandClaude Opus 4.8	2f12a2ae84	v0.4.68: fix NFS secure-export mount, logo cache-bust, dashboard disk card, NFS form spacing Four operator-reported issues from v0.4.67 validation. ## 1. NFS MNT3ERR_ACCES even with the host IP allow-listed Root cause: Linux kernel nfsd (what UniFi UNAS / Synology / TrueNAS all run underneath) exports with the `secure` option by default, which only accepts mount/NFS requests from a privileged source port (<1024). v0.4.67 explicitly connected from a non-privileged port on the mistaken assumption that uid 10001 can't bind low ports — but the binary carries CAP_NET_BIND_SERVICE (granted via setcap for the DHCP/TFTP/HTTP low-port binds), which also covers privileged source ports for outbound connects. Fix: build_connection now tries a privileged source port first (the common case for every appliance NAS), then falls back to a non-privileged port for `insecure` exports or capability-less environments. Each attempt has its own connect timeout; a timeout on the first attempt skips the fallback (the server isn't answering — a retry would just double the wait). Also: hint_for now recognizes MNT3ERR_ACCES distinctly from NFS3ERR_ACCES and explains both the allow-list and the secure/insecure angle, with the UniFi /var/nfs/shared/<share> path convention called out. ## 2. Custom logo didn't update the top-left brand mark The brand <img> and favicon were pinned to ?v=<app-version>, which only changes on upgrade — so uploading a new logo left the cached bundled SVG in place. Added a monotonic `rev` counter to BrandingStore that bumps on every set/clear, persisted across restarts, surfaced through index_html as an extra &r=<rev> cache-bust token on the brand mark + favicon URLs. Since index.html is served no-cache, the fresh token lands on the next reload after upload and the new logo appears immediately. (Note: this updates the WebUI brand mark. The PXE boot menu still shows the ASCII wordmark — painting the operator's PNG there needs the IMAGE_PNG-enabled iPXE rebuild that remains queued for native x86_64 hardware. The /branding/pxe-logo compositor is ready for when it lands.) ## 3. Disk-space card on the Dashboard Extracted the Storage tab's disk card into a shared diskSpaceCard(disk) helper and added it to the Dashboard grid under the stat strip. Dashboard fetches /api/storage/disk with the same graceful-degradation fallback the Storage tab uses. ## 4. NFS "Add share" button touching the form field The NFS card has a single form row (vs SMB's two), so the button butted right against it. Added margin-top:14px to match SMB's effective spacing. Tests: 162 passing (+2 — logo_rev bump, MNT3ERR_ACCES hint). clippy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>	2026-05-28 21:34:41 -04:00
Miles WardandClaude Opus 4.7	3f9d8568f0	v0.4.67: NFSv3 alongside SMB (in-process via nfs3_client crate) NFS is back — done right this time. v0.4.67 ships a pure-Rust NFSv3 client (`nfs3_client` 0.9 from the xetdata/Vaiz crate family) running in-process inside the openpxe binary. No `mount.nfs`, no kernel modules, no `CAP_SYS_ADMIN`, no subprocess. Works in every container that the v0.4.65 SMB path works in (Unraid included). The v0.4.65 SMB path stays as-is. Operators get both protocols side-by-side and pick whichever their NAS prefers — or use both together. NFSv3 has one architectural advantage over the SMB userspace path: HTTP Range requests work for NFS-sourced ISOs because NFSv3 READ3 takes an explicit offset. SMB-sourced ISOs still return 416 for ranges (smbclient CLI can't seek mid-stream). ## What's new - `crates/iso-store/src/nfs_share.rs` — `NfsShareManager` mirroring `SmbShareManager` structurally. Lists ISOs via READDIR3+LOOKUP3+ GETATTR3, streams files via READ3 in 64 KiB chunks piped to axum body streams. Uses `connect_from_privileged_port(false)` because the openpxe binary runs as uid 10001 — most modern NFS servers allow that; a server that demands privileged ports needs `insecure` in /etc/exports, and the hint translation calls that out specifically. - `IsoSource::Nfs { share_id, relative_path }` variant alongside the existing `Smb`. `IsoStore::iso_path_for` returns None for both; the HTTP handler dispatches to the right share manager. - `/api/nfs-shares` CRUD + scan endpoints, parallel to `/api/smb-shares`. `POST` body: `{ server, export, port? }`. - `nfs` terminal command back (this time as in-process, not kernel mount): `list \| add <srv>:<export> [port] \| remove \| scan`. The v0.4.64 `nfs` command name pointing at kernel mount is moot history — same name, completely different mechanism. - Storage tab: a new NFS shares card sits directly below the SMB shares card. The form is simpler (no auth fields) since NFSv3 uses AUTH_SYS and access is gated server-side by client IP. - Dashboard "Images available" tile sums SMB + NFS reachable shares into a generic "N remote shares" line. ## What's the same - The structured `{error, stderr, hint}` JSON shape on failures matches the SMB API exactly, so the UI's error banner renders identically. - Hint translation: NFS3ERR_ACCES → "exports list", NFS3ERR_NOENT → "export path doesn't exist", `mount denied` → "/etc/exports may need `insecure`", timeouts → "check IP/port/firewall". - Persistence: `<work_dir>/nfs_shares.json`. No conflict with the long-dead v0.4.64 `nfs.json`. ## Why nfs3_client User picked it: pure-Rust matches the architecture, NFSv3 covers the real-world cases, AUTH_SYS keeps the UI simple. The crate is at 0.9.0, MIT/Unlicense, rust-version 1.88 (we're on 1.95). Tokio feature flag enabled. Image size unchanged at compile time — single musl static binary, no extra OS packages. ## Tests 160 passing (was 150 in v0.4.66, +10): - nfs_share parser: stable share ids, server normalization (smb://, cifs://, \\, // all stripped). - hint_for(): NFS3ERR_ACCES, NFS3ERR_NOENT, mount denied, unknown. - status_label() covers the common nfsstat3 codes. - HTTP integration: nfs-shares list starts empty, missing server rejected, export without leading slash rejected. `cargo clippy --workspace --all-targets -- -D warnings` clean. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>	2026-05-28 12:56:46 -04:00

Author

SHA1

Message

Date

Miles WardandClaude Opus 4.8

2f12a2ae84

v0.4.68: fix NFS secure-export mount, logo cache-bust, dashboard disk card, NFS form spacing

Four operator-reported issues from v0.4.67 validation.

## 1. NFS MNT3ERR_ACCES even with the host IP allow-listed

Root cause: Linux kernel nfsd (what UniFi UNAS / Synology / TrueNAS all
run underneath) exports with the `secure` option by default, which only
accepts mount/NFS requests from a privileged source port (<1024). v0.4.67
explicitly connected from a non-privileged port on the mistaken assumption
that uid 10001 can't bind low ports — but the binary carries
CAP_NET_BIND_SERVICE (granted via setcap for the DHCP/TFTP/HTTP low-port
binds), which also covers privileged *source* ports for outbound connects.

Fix: build_connection now tries a privileged source port first (the common
case for every appliance NAS), then falls back to a non-privileged port
for `insecure` exports or capability-less environments. Each attempt has
its own connect timeout; a timeout on the first attempt skips the fallback
(the server isn't answering — a retry would just double the wait).

Also: hint_for now recognizes MNT3ERR_ACCES distinctly from NFS3ERR_ACCES
and explains both the allow-list and the secure/insecure angle, with the
UniFi /var/nfs/shared/<share> path convention called out.

## 2. Custom logo didn't update the top-left brand mark

The brand <img> and favicon were pinned to ?v=<app-version>, which only
changes on upgrade — so uploading a new logo left the cached bundled SVG
in place. Added a monotonic `rev` counter to BrandingStore that bumps on
every set/clear, persisted across restarts, surfaced through index_html as
an extra &r=<rev> cache-bust token on the brand mark + favicon URLs. Since
index.html is served no-cache, the fresh token lands on the next reload
after upload and the new logo appears immediately.

(Note: this updates the WebUI brand mark. The PXE *boot menu* still shows
the ASCII wordmark — painting the operator's PNG there needs the
IMAGE_PNG-enabled iPXE rebuild that remains queued for native x86_64
hardware. The /branding/pxe-logo compositor is ready for when it lands.)

## 3. Disk-space card on the Dashboard

Extracted the Storage tab's disk card into a shared diskSpaceCard(disk)
helper and added it to the Dashboard grid under the stat strip. Dashboard
fetches /api/storage/disk with the same graceful-degradation fallback the
Storage tab uses.

## 4. NFS "Add share" button touching the form field

The NFS card has a single form row (vs SMB's two), so the button butted
right against it. Added margin-top:14px to match SMB's effective spacing.

Tests: 162 passing (+2 — logo_rev bump, MNT3ERR_ACCES hint). clippy clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

2026-05-28 21:34:41 -04:00

Miles WardandClaude Opus 4.7

3f9d8568f0

v0.4.67: NFSv3 alongside SMB (in-process via nfs3_client crate)

NFS is back — done right this time. v0.4.67 ships a pure-Rust NFSv3
client (`nfs3_client` 0.9 from the xetdata/Vaiz crate family) running
in-process inside the openpxe binary. No `mount.nfs`, no kernel
modules, no `CAP_SYS_ADMIN`, no subprocess. Works in every container
that the v0.4.65 SMB path works in (Unraid included).

The v0.4.65 SMB path stays as-is. Operators get both protocols
side-by-side and pick whichever their NAS prefers — or use both
together. NFSv3 has one architectural advantage over the SMB
userspace path: HTTP Range requests work for NFS-sourced ISOs
because NFSv3 READ3 takes an explicit offset. SMB-sourced ISOs still
return 416 for ranges (smbclient CLI can't seek mid-stream).

## What's new

- `crates/iso-store/src/nfs_share.rs` — `NfsShareManager` mirroring
  `SmbShareManager` structurally. Lists ISOs via READDIR3+LOOKUP3+
  GETATTR3, streams files via READ3 in 64 KiB chunks piped to axum
  body streams. Uses `connect_from_privileged_port(false)` because
  the openpxe binary runs as uid 10001 — most modern NFS servers
  allow that; a server that demands privileged ports needs
  `insecure` in /etc/exports, and the hint translation calls that
  out specifically.
- `IsoSource::Nfs { share_id, relative_path }` variant alongside the
  existing `Smb`. `IsoStore::iso_path_for` returns None for both;
  the HTTP handler dispatches to the right share manager.
- `/api/nfs-shares` CRUD + scan endpoints, parallel to
  `/api/smb-shares`. `POST` body: `{ server, export, port? }`.
- `nfs` terminal command back (this time as in-process, not kernel
  mount): `list | add <srv>:<export> [port] | remove | scan`. The
  v0.4.64 `nfs` command name pointing at kernel mount is moot
  history — same name, completely different mechanism.
- Storage tab: a new NFS shares card sits directly below the SMB
  shares card. The form is simpler (no auth fields) since NFSv3
  uses AUTH_SYS and access is gated server-side by client IP.
- Dashboard "Images available" tile sums SMB + NFS reachable shares
  into a generic "N remote shares" line.

## What's the same

- The structured `{error, stderr, hint}` JSON shape on failures
  matches the SMB API exactly, so the UI's error banner renders
  identically.
- Hint translation: NFS3ERR_ACCES → "exports list", NFS3ERR_NOENT →
  "export path doesn't exist", `mount denied` → "/etc/exports may
  need `insecure`", timeouts → "check IP/port/firewall".
- Persistence: `<work_dir>/nfs_shares.json`. No conflict with the
  long-dead v0.4.64 `nfs.json`.

## Why nfs3_client

User picked it: pure-Rust matches the architecture, NFSv3 covers the
real-world cases, AUTH_SYS keeps the UI simple. The crate is at
0.9.0, MIT/Unlicense, rust-version 1.88 (we're on 1.95). Tokio
feature flag enabled. Image size unchanged at compile time — single
musl static binary, no extra OS packages.

## Tests

160 passing (was 150 in v0.4.66, +10):
- nfs_share parser: stable share ids, server normalization (smb://,
  cifs://, \\, // all stripped).
- hint_for(): NFS3ERR_ACCES, NFS3ERR_NOENT, mount denied, unknown.
- status_label() covers the common nfsstat3 codes.
- HTTP integration: nfs-shares list starts empty, missing server
  rejected, export without leading slash rejected.

`cargo clippy --workspace --all-targets -- -D warnings` clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

2026-05-28 12:56:46 -04:00