mward4/OpenPXE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 40 Wiki Activity

v0.5.7: skip PNG boot-menu background on legacy BIOS clients

Browse Source 
The menu emitted `console --picture … || console`, relying on the
trailing `|| console` to recover on iPXE builds without IMAGE_PNG +
CONSOLE_FRAMEBUFFER. On legacy BIOS (`undionly.kpxe`, no PNG) the
`--picture` attempt misbehaves before the fallback can recover — it
tries to set a framebuffer mode the BIOS console can't honour — so the
boot menu fails to render on BIOS clients.

Fix: gate the command on `iseq ${platform} efi`, so BIOS (`pcbios`)
clients never issue `console --picture` at all and drop straight to the
plain text menu, while UEFI clients still get the graphical background.
This is automatic and per-client — a mixed BIOS+UEFI fleet each gets the
right treatment with no operator toggle. A PNG-less UEFI build (upstream
i386-efi) still falls back gracefully through the same `|| console`.

Menu snapshot updated to match. 254 tests pass, clippy clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This commit is contained in:
Miles Ward
2026-06-03 19:28:02 -04:00
co-authored by Claude Opus 4.8
parent c0d17fa9ca
commit ac433b30e9
4 changed files with 26 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Cargo.lock
Generated
+8 -8
View File
@@ -2669,7 +2669,7 @@ checksum = "c08d65885ee38876c4f86fa503fb49d7b507c2b62552df7c70b2fce627e06381"
[[package]]
name = "openpxe"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"anyhow",
"axum",
@@ -2691,7 +2691,7 @@ dependencies = [
[[package]]
name = "openpxe-core"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"anyhow",
"base64",
@@ -2718,7 +2718,7 @@ dependencies = [
[[package]]
name = "openpxe-dhcp-proxy"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"anyhow",
"bytes",
@@ -2732,7 +2732,7 @@ dependencies = [
[[package]]
name = "openpxe-http-api"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"anyhow",
"axum",
@@ -2768,7 +2768,7 @@ dependencies = [
[[package]]
name = "openpxe-ipxe-assets"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"openpxe-core",
"rust-embed",
@@ -2778,7 +2778,7 @@ dependencies = [
[[package]]
name = "openpxe-iso-store"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"anyhow",
"bcrypt",
@@ -2807,7 +2807,7 @@ dependencies = [
[[package]]
name = "openpxe-tftp"
version = "0.5.6"
version = "0.5.7"
dependencies = [
"anyhow",
"bytes",
@@ -2821,7 +2821,7 @@ dependencies = [
[[package]]
name = "openpxe-webui"
version = "0.5.6"
version = "0.5.7"
[[package]]
name = "p256"